-
Notifications
You must be signed in to change notification settings - Fork 15
introduce variable $EESSI_INIT_PREFIX for overriding location of init directory
#93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
|
New job on instance
|
|
Removed the ready-to-deploy label, need to do a similar change to the bash init scripts (that's what the CI is complaining about). |
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
|
New job on instance
|
|
Tested the additional changes in the init scripts with the EESSI container on a RISC-V system: 2023.06: 2025.06: 2025.06-1: |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| echo "" | ||
| fi | ||
| elif [[ "${EESSI_VERSION_DEFAULT}" == "2025.06" ]]; then | ||
| export EESSI_CVMFS_REPO="${EESSI_CVMFS_REPO_OVERRIDE:=/cvmfs/dev.eessi.io/riscv}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bedroge Can you make sure that https://www.eessi.io/docs/repositories/riscv.eessi.io/ gets updated accordingly?
|
@bedroge |
|
staging PR merged for We should wait to trigger those builds until updated |
Oh, yes, you're absolutely right, totally overlooked that! |
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen3 |
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
2nd staging PR merged, so |
This doesn't change any default behavior, but it's needed for the RISC-V bot: RISC-V software is built for
/cvmfs/dev.eessi.io/riscv, while using the compat layer and scripts fromsoftware.eessi.io.$EESSI_PREFIXis a bit ambiguous in that case, and is currently pointing to/cvmfs/dev.eessi.io/riscv, meaning that the EESSI-extend module will also look there for the init dir (that's where it expects the EB hooks file). This new variable allows us to to override that location.These two changes were tested in EESSI/dev.eessi.io-riscv#1 (comment), along with some additional changes in https://github.com/EESSI/dev.eessi.io-scripts/blob/main/bot/bot-build-dev.eessi.io.slurm (this needs to actually set that variable).
edit: though not really required, I figured it would be clean to have the EESSI module set
EESSI_INIT_PREFIXas well, so I've added that in 1ff11e3. For consistency, I also renamed the local variableeessi_archdetect_prefixtoeessi_init_prefix.