Skip to content

Conversation

@boegel
Copy link
Contributor

@boegel boegel commented Jun 14, 2025

Default behavior is left unchanged.

unionfs looks promising, haven't observed the Permission denied issues we've been seeing when creating overlay with fuse-overlays, but it needs to be battle-tested before we jump ship.

Tested with:

./eessi_container.sh --container docker://ghcr.io/eessi/build-node:debian12 --overlay-tool unionfs --access rw

(see also EESSI/filesystem-layer#226)

@boegel boegel added the enhancement New feature or request label Jun 14, 2025
Copy link
Contributor

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions

echo 'source /software-layer/scripts/utils.sh' >> ${test_script}
echo 'source /software-layer/init/eessi_environment_variables' >> ${test_script}
echo 'ls -l /software-layer-scripts/' >> ${test_script}
echo 'sed -i "s/__EESSI_VERSION_DEFAULT__/${{matrix.EESSI_VERSION}}/g" init/eessi_defaults
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual fix is here, this looks more complicated than it should because of software-layer -> software-layer-scripts rename...

@boegel boegel force-pushed the eessi_container_unionfs branch from 3aaa438 to c9b81ba Compare June 17, 2025 18:53
@bedroge
Copy link
Contributor

bedroge commented Jun 24, 2025

@boegel the CI is still failing because of:

ERROR: /cvmfs/software.eessi.io/versions/__EESSI_VERSION_DEFAULT__/compat/linux/x86_64 does not exist!

Any idea why the EESSI_VERSION_OVERRIDE is not working?

edit: quickly tried to reproduce that locally, but it worked fine for me...

@boegel
Copy link
Contributor Author

boegel commented Jun 24, 2025

@boegel the CI is still failing because of:

ERROR: /cvmfs/software.eessi.io/versions/__EESSI_VERSION_DEFAULT__/compat/linux/x86_64 does not exist!

Any idea why the EESSI_VERSION_OVERRIDE is not working?

edit: quickly tried to reproduce that locally, but it worked fine for me...

I've been trying to figure out why it's not working as it should, but I'm puzzled too...

@bedroge
Copy link
Contributor

bedroge commented Jun 25, 2025

I tried it again, I think it's because run_in_compat_layer_env.sh does a source ${base_dir}/init/eessi_defaults. That's before you're overriding EESSI_VERSION_OVERRIDE, so then EESSI_VERSION gets set to that placeholder string.

out="${PWD}/test_create_lmodsitepackage.out"
./eessi_container.sh --mode run --verbose /software-layer/run_in_compat_layer_env.sh /software-layer/test_lmod_sitepackage.sh 2>&1 | tee ${out}
for pattern in "^Site Pkg location.*/software-layer/.lmod/SitePackage.lua" "LMOD_SITEPACKAGE_LOCATION.*/software-layer/.lmod/SitePackage.lua"; do
./eessi_container.sh --mode run --verbose /software-layer-scripts/run_in_compat_layer_env.sh /software-layer-scripts/test_lmod_sitepackage.sh 2>&1 | tee ${out}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$EESSI_VERSION_OVERRIDE should also be set for this step

@boegel boegel force-pushed the eessi_container_unionfs branch from a4e7200 to 0ec75f1 Compare June 27, 2025 13:49
Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bedroge bedroge merged commit 3ceef12 into EESSI:main Jun 27, 2025
47 checks passed
@boegel boegel deleted the eessi_container_unionfs branch June 27, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants