-
Notifications
You must be signed in to change notification settings - Fork 14
add support to eessi_container.sh for using unionfs overlay tool
#9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions
…iner.sh script Co-authored-by: Thomas Röblitz <[email protected]>
…layer-scripts into eessi_container_unionfs
.github/workflows/tests_scripts.yml
Outdated
| echo 'source /software-layer/scripts/utils.sh' >> ${test_script} | ||
| echo 'source /software-layer/init/eessi_environment_variables' >> ${test_script} | ||
| echo 'ls -l /software-layer-scripts/' >> ${test_script} | ||
| echo 'sed -i "s/__EESSI_VERSION_DEFAULT__/${{matrix.EESSI_VERSION}}/g" init/eessi_defaults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actual fix is here, this looks more complicated than it should because of software-layer -> software-layer-scripts rename...
3aaa438 to
c9b81ba
Compare
…AULT__ placeholder in init/eessi_defaults in CI workflow to test load_easybuild_module.sh script
|
@boegel the CI is still failing because of: Any idea why the edit: quickly tried to reproduce that locally, but it worked fine for me... |
I've been trying to figure out why it's not working as it should, but I'm puzzled too... |
|
I tried it again, I think it's because |
Co-authored-by: Bob Dröge <[email protected]>
| out="${PWD}/test_create_lmodsitepackage.out" | ||
| ./eessi_container.sh --mode run --verbose /software-layer/run_in_compat_layer_env.sh /software-layer/test_lmod_sitepackage.sh 2>&1 | tee ${out} | ||
| for pattern in "^Site Pkg location.*/software-layer/.lmod/SitePackage.lua" "LMOD_SITEPACKAGE_LOCATION.*/software-layer/.lmod/SitePackage.lua"; do | ||
| ./eessi_container.sh --mode run --verbose /software-layer-scripts/run_in_compat_layer_env.sh /software-layer-scripts/test_lmod_sitepackage.sh 2>&1 | tee ${out} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$EESSI_VERSION_OVERRIDE should also be set for this step
a4e7200 to
0ec75f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Default behavior is left unchanged.
unionfslooks promising, haven't observed thePermission deniedissues we've been seeing when creating overlay withfuse-overlays, but it needs to be battle-tested before we jump ship.Tested with:
(see also EESSI/filesystem-layer#226)