Move check result to target repo (bot/check-result.sh script) #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-layer into add_171_on_top_of_172
app.cfg.example - polished/clarified notes about comment templates - more control over format for details eessi_bot_job_manager.py - support for more control over format for details in PR comment - handling case that no result file is found tools/pr_comments.py - support for more control over format for details in PR comment
- we assume that the check-result.sh script provides a fully defined HTML string
the bot can just dump as is into the column in the status table (no further
processing is needed)
- changes separated for each file
- app.cfg.example:
- removed *_fmt settings for summary, details and artefacts
- added new format for when result is UNKNOWN (ie no result
file found or no pre-formatted comment_details found)
- eessi_bot_job_manager.py:
- replaced existing constants with new constants
- updated comment explaining expected format of result file
- updated processing of result file (got much simpler --> complexity/work
moved to target respository)
- only needs to retain some code then result is not defined/unknown (format
of this is defined via `app.cfg`)
- scripts/bot-build.slurm:
- adjusted format of result file that is generated if the target repository
does not provide the bot/check-result.sh
- tools/pr_comments.py:
- removed function make_html_list_items which is not used/needed any longer
…ove_check_result_to_target_repo
trz42
pushed a commit
to trz42/eessi-bot-software-layer
that referenced
this pull request
Jun 17, 2023
…com/trz42/eessi-bot-software-layer into update_eessi_with_PR174_182_185 - tools/job_metadata.py - added create_metadata_file (introduced by EESSI#174) - added read_metadata_file (introduced by EESSI#174) - let read_job_metadata_from_file use read_metadata_file - eessi_bot_job_manager.py - made use of read_job_metadata_from_file in read_job_pr_metadata
boegel
requested changes
Jun 19, 2023
…ult` file created by `bot-build.slurm` when no `bot/check-result.sh` script was found
boegel
changed the title
boegel
approved these changes
Jun 20, 2023
Contributor
boegel
left a comment
boegel
left a comment
There was a problem hiding this comment.
Tested along with EESSI/software-layer#241 via boegel/software-layer#25, works like a charm.
Thanks (again) for all the effort on this @trz42!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR on top of #172 to improve analysing the result of a bot job. It intends to move any repository specific code for checking the result of a build job to the target repository (what the bot is used to build for). The two major changes are
bot/check-result.shprovided by the target repository (e.g., EESSI/software-layer or EESSI/compatibility-layer or any other "software" repository)process_finished_jobfunction use a result file produced by the abovecheck-result.shscript to update a comment in the PR with aSUCCESS/FAILURE/UNKNOWNmessage and detailed informationAt the moment, the code still includes the old method for analysing a job's result. Once the software-layer and compatibility-layer repositories have been updated to providebot/check-result.shscript this can be removed. A draft version of such a script is included in EESSI/compatibility-layer#179Rather removed all that code in favour of having a clean cut/change. Matching PRs for compatibility layer (EESSI/compatibility-layer#179) and software layer (EESSI/software-layer#241) need to be updated.
Update June 18:
bot/check-result.sh)TODOs