Skip to content

Conversation

@MalteKurz
Copy link
Member

Description

In alignment with the Python package (see DoubleML/doubleml-for-py#131), in this PR the abstract methods are renamed:

  • ml_nuisance_and_score_elements --> nuisance_est
  • ml_nuisance_tuning --> nuisance_tuning

Comments

Blocked by #161 (derived from there to prevent merge conflicts).

PR Checklist

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • The code passes R CMD check and all (unit) tests.
  • The changes adhere to the "mlr-style" standards.

@MalteKurz MalteKurz merged commit bf78c51 into master Jun 14, 2022
@MalteKurz MalteKurz deleted the m-rename-abstract-methods branch June 15, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants