Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
4f7617e
adapt nuisance estimation for the IV type score in the PLR model (par…
MalteKurz Apr 22, 2022
9aba914
ignore NA's for the estimation of the initial theta guess
MalteKurz Apr 22, 2022
baeb9dd
adapt unit test after 4f7617e368614738c97732141cc67016ad335975
MalteKurz Apr 22, 2022
2ea12e1
tuning with adapted nuisance estimation for the IV type score in the …
MalteKurz Apr 22, 2022
eacca32
apply styler
MalteKurz Apr 22, 2022
da37e64
update in the API documentation
MalteKurz Apr 26, 2022
5956dd6
extend the prediction export unit test to g_hat for PLR with IV-type …
MalteKurz Apr 26, 2022
ff9547c
PLR: Rename ml_g to ml_L; Add additional learner ml_g for IV-type score
MalteKurz May 2, 2022
9ba0841
apply styler
MalteKurz May 2, 2022
c66447e
add some deprecation warning
MalteKurz May 2, 2022
f322f0f
bug fix; typo in pkg name
MalteKurz May 2, 2022
4aac7d6
bug fix; typo in pkg name
MalteKurz May 2, 2022
5aac1a2
bug fix; Method tune() should be callable with the default tune_setti…
MalteKurz May 2, 2022
b59add5
transfer the bug fix 5aac1a2 which is also needed for the deprecation…
MalteKurz May 2, 2022
9d3d06d
add unit tests for the deprecation warnings
MalteKurz May 2, 2022
0ab343a
refactor the check and set learner part of the initializer
MalteKurz May 3, 2022
96fd8aa
minor adaptions and fixes in the unit tests
MalteKurz May 3, 2022
71f3223
rename learner ml_g into ml_l for the PLIV model
MalteKurz May 4, 2022
0792b49
add deprecation warning for renamed learner
MalteKurz May 4, 2022
8555c7f
apply styler
MalteKurz May 4, 2022
be116a6
apply styler
MalteKurz May 4, 2022
553e8b5
Merge branch 'm-plr-api' of github.com:DoubleML/doubleml-for-r into m…
MalteKurz May 4, 2022
bf73b8f
implementation of the IV-type score for the PLIV model
MalteKurz May 4, 2022
a5d69f6
complement renaming of ml_g to ml_l at some more places
MalteKurz May 4, 2022
ad790af
Merge branch 'm-plr-api' of github.com:DoubleML/doubleml-for-r into m…
MalteKurz May 4, 2022
e7ccf69
prefer to not have positional arguments followed by named arguments f…
MalteKurz May 4, 2022
b6316ce
apply styler
MalteKurz May 4, 2022
9697bf0
add unit tests for the new IV-type score of the PLIV model
MalteKurz May 4, 2022
4fd4d4a
finalize IV-type score implementation & apply styler
MalteKurz May 4, 2022
b82b074
add unit tests for new deprecation warnings for the PLIV model
MalteKurz May 4, 2022
f8cb241
add missing score parameter in the cran setting
MalteKurz May 4, 2022
420ef01
fix unit test: Renaming of ml_g to ml_l
MalteKurz May 4, 2022
b2fcc3d
apply styler
MalteKurz May 13, 2022
5923e4c
update docu
MalteKurz May 18, 2022
07fee0e
always use the same order for the nuisance parts in the unit test imp…
MalteKurz May 18, 2022
b1e4071
always use the same order for the nuisance parts in the unit test imp…
MalteKurz May 18, 2022
4401467
Merge branch 'm-plr-api' of github.com:DoubleML/doubleml-for-r into m…
MalteKurz May 18, 2022
f389710
always use the same order for the nuisance parts in the unit test imp…
MalteKurz May 18, 2022
d6bc37b
Merge branch 'm-plr-api' of github.com:DoubleML/doubleml-for-r into m…
MalteKurz May 18, 2022
bb20d4c
update docu
MalteKurz May 18, 2022
424eac5
Merge branch 'm-fix-bugs' of github.com:DoubleML/doubleml-for-r into …
MalteKurz May 19, 2022
1eede1d
Merge branch 'm-plr-api' of github.com:DoubleML/doubleml-for-r into m…
MalteKurz May 19, 2022
a276cb1
apply styler
MalteKurz May 19, 2022
c032e94
docu update
MalteKurz May 20, 2022
8f83daa
updated signature for callable scores
MalteKurz May 20, 2022
8c6486e
provide all arguments as keyword arguments to callable scores
MalteKurz May 20, 2022
e8aeac2
Merge branch 'master' of github.com:DoubleML/doubleml-for-r into m-pl…
MalteKurz May 20, 2022
e6d7dcf
Merge branch 'm-plr-api' of github.com:DoubleML/doubleml-for-r into m…
MalteKurz May 20, 2022
e4e41ff
IV type score is new for PLIV; no need to warn; instead throw an exce…
MalteKurz May 20, 2022
6c3e913
no need to initialize task_type for each nuisance part, see #157
MalteKurz May 20, 2022
cdb7778
add an additional exception handling unit test for pliv IV-type with …
MalteKurz May 20, 2022
af8940d
further extend unit tests for exception handling
MalteKurz May 20, 2022
968dde4
docu updates
MalteKurz May 20, 2022
5dfe618
PhilippBach Jun 9, 2022
0b7b8f9
Apply suggestions from code review: remove redundant z assignments
MalteKurz Jun 10, 2022
c9ecd39
Consistent format if score is a character
MalteKurz Jun 10, 2022
a2e2326
Consistent format if score is a character
MalteKurz Jun 10, 2022
dbb2a75
re-build docu
MalteKurz Jun 10, 2022
f4362f8
apply styler
MalteKurz Jun 10, 2022
c793960
add a warning if a learner ml_g is specified (but not needed) with sc…
MalteKurz Jun 10, 2022
53ca073
adapt unit test for new warning if ml_g is set with score partialling…
MalteKurz Jun 10, 2022
1a508dd
add a unit test for the new warning if ml_g is set with score partial…
MalteKurz Jun 10, 2022
9449286
fix unit test
MalteKurz Jun 10, 2022
ecd05c2
apply styler
MalteKurz Jun 10, 2022
bfc9c91
PhilippBach Jun 10, 2022
46b5929
Merge pull request #162 from DoubleML/p-suggest-change-pliv
MalteKurz Jun 13, 2022
b96ac05
apply styler
MalteKurz Jun 13, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions R/double_ml_iivm.R
Original file line number Diff line number Diff line change
Expand Up @@ -366,8 +366,10 @@ DoubleMLIIVM = R6Class("DoubleMLIIVM",
"ml_r1" = r1_hat)
return(res)
},
score_elements = function(y, z, d, g0_hat, g1_hat, m_hat, r0_hat,
r1_hat, smpls) {
score_elements = function(y = y, z = z, d = d,
g0_hat = g0_hat, g1_hat = g1_hat, m_hat = m_hat,
r0_hat = r0_hat, r1_hat = r1_hat,
smpls = smpls) {

u0_hat = y - g0_hat
u1_hat = y - g1_hat
Expand Down
5 changes: 4 additions & 1 deletion R/double_ml_irm.R
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,10 @@ DoubleMLIRM = R6Class("DoubleMLIRM",
}
psis = list(psi_a = psi_a, psi_b = psi_b)
} else if (is.function(self$score)) {
psis = self$score(y, d, g0_hat, g1_hat, m_hat, smpls)
psis = self$score(
y = y, d = d,
g0_hat = g0_hat, g1_hat = g1_hat, m_hat = m_hat,
smpls = smpls)
}
return(psis)
},
Expand Down
521 changes: 420 additions & 101 deletions R/double_ml_pliv.R

Large diffs are not rendered by default.

363 changes: 332 additions & 31 deletions R/double_ml_plr.R

Large diffs are not rendered by default.

174 changes: 157 additions & 17 deletions man/DoubleMLPLIV.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading