Add setting to pass proxies to requests #209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for cases where PK is not .id.
Added environment option to skip compilation of translation files.
…king not instance.pk is insufficient. It can have a PK but not be saved in the DB yet, which will call this to fail.
Handle case where an instance has a PK but isn't saved yet.
Was raising a `RuntimeWarning: DateTimeField Url.last_checked received a naive datetime ... while time zone support is active.`
Since we're using sqlite as the test db backend, we can't effectively test the `Url` objects being saved in the `ThreadPoolExecutor` futures, but there's enough test coverage that under the hood `Url.check_url` is doing the right thing
check_links: add concurrent version to speed up the `check_links` task
|
Thanks for the various fixes, but please create one pull request per concern, so we can properly review each improvement/fix separately. |
Yes, will do. |
|
@claudep I've split our changes into: |
|
Great, I will try to find some time to review soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LINKCHECK_PROXIESso that proxies can be passed to the requestsLINKCHECK_TRUST_PROXY_SSLto give the option to turn off SSL verificationlinklist["object"].idtolinklist["object"].pkso that this is able to work with models whose PK is notidLINKCHECK_SKIP_TRANSLATIONSto skip compilation of translation files when they are not needed.instance._state.addingtoinstance_pre_saveas checkingnot instance.pkis insufficient. In cases involving concrete model inheritance it can have a PK set but not be saved in the DB yet, which will call this to fail.