Skip to content

SIP script for stability pool subsidies #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

SIP script for stability pool subsidies #498

wants to merge 4 commits into from
+6,700 −6

Conversation

@cwsnt
Copy link
Contributor

@cwsnt cwsnt commented Apr 26, 2023

No description provided.

@cwsnt cwsnt requested review from ororopickpocket and tjcloa April 26, 2023 09:20
ororopickpocket
ororopickpocket reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@ororopickpocket ororopickpocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Is the APR already set to 5% at this point? and the reward manager to exchequer? is there a script for it?

@cwsnt
Copy link
Contributor Author

cwsnt commented Apr 26, 2023 •
edited
Loading

Looks good so far. Is the APR already set to 5% at this point? and the reward manager to exchequer? is there a script for it?

Yes, The APR will be set at the contract initialization of community issuance, as well as the reward manager address right after it.
Those will be set before this SIP execution

tjcloa
tjcloa requested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@tjcloa tjcloa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use hh sip scripts
otherwise it is pretty hard to do QA testing

@cwsnt
Copy link
Contributor Author

cwsnt commented Apr 27, 2023

pls use hh sip scripts otherwise it is pretty hard to do QA testing

Added sip scripts for HH

@cwsnt cwsnt requested a review from tjcloa April 27, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ororopickpocket ororopickpocket ororopickpocket approved these changes

@tjcloa tjcloa Awaiting requested review from tjcloa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cwsnt @ororopickpocket @tjcloa