Feature/issue/55 #58
Merged
Feature/issue/55 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the input files of sfrnip2vrms. Now the program receives only rnip file with the same dimensions of stacked section. Because of that is no longer required to receive the stacked section as input
Use define LOGGING macro to allow logging and warning option during program compilation. Someone only have to comment or uncomment the line with the macro definition to use or not the warnings during the program execution. This option is for degub purpose only. To verbose execution, use verb parameter available for sfrnip2vrms
…nto feature/issue/55
1. Conditional builds in travis CI Configure .travis.yml to allow conditional builds of the stages with environment variables evaluated as true. Each job has its own name. 2. Include unit tests in the .travis.yml file Now, travis will run 3 stages of tests, unit tests calling make in the TDD directory; modeling step, calling the unittest module for each test script in the TDD directory; and deploy stage, that should be written. This is done with test_travis_docker.sh script, that generate a docker container with cregatherstack:1.0.0 image where Madagascar is installed and pre configured. This script is called in the .travis.yml file 3. New tests for negative values The function calculateVrmsSectionForRnipVector returns 0 for negative values. It is added a test for this condition and a test for a random set of rnip values in the test suite
Madagascar recipes kimodel.py and pefInterpolation.py are installed in the image cregatherstack:1.0.0 used during the building with travis CI and the installation process of these recipes is no longer required
The script test_travis_docker.sh that runs docker containers of the unit tests is moved to TDD directory. This script is called from .travis.yml configuration file
Build a parameters cube with the parameters of zero offset CRS, extracted from data cube during VFSA global optimization. Window RNIP from parameters cube and use it as input to the program sfrnip2vrms, that estimate VRMS from rnip values of each (t0,m0) pair in the stacked section
Use Makefile conditional to allow building tests for CENTOS distribution in HOSTGATOR VPS using the following command: ~$ make CENTOS=1 The value for CENTOS variable is not important, the conditional verifies if it is defined or not
The docker image repository used in the test is updated
Dirack
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📤 Pull Request
Description
New program sfrnip2vrms to convert RNIP values to VRMS velocity for each (t0,m0) pair in the stacked section.
The program sfrnip2vrms now receives only one input, RNIP file.
Unit tests of the new program.
Update Travis CI tests.
Resolve #55
Type of change
Please delete options that are not relevant.
Add images bellow and additional context if needed