Fix playwright tests, liveview and feature selection #4042

ealmloff · 2025-04-25T13:55:11Z

Liveview broke with the 0.8 axum upgrade which is now causing the playwright tests to fail. This PR fixes the issue by updating the router definition

This PR also fixes a bug in the CLI that is causing the wrong features to activate which breaks the playwright test

Fixes #4046

ealmloff · 2025-04-28T16:53:17Z

The wasm split feature is failing with this error after fixing the dependency issues:

11:52:35 [dev] Emitting main bundle split module
11:52:36 [dev] Build failed: Other(Failed to write main executable

Caused by:
    0: Failed to read module
    1: [parse exception: invalid code after misc prefix: 17 (at 0:441310)])

davehorner · 2025-04-29T03:03:55Z

gh pr checkout 4042

This does not fix #4046 for me.

37Target origin: SingleFile("\\\\?\\C:\\working\\rust\\demos\\dioxus\\examples\\hello_world.rs")
Manifest path: C:\working\rust\demos\dioxus\Cargo.toml
Execution directory (same as manifest folder): C:\working\rust\demos\dioxus
Running: C:\Users\dhorner\.cargo\bin\dx.exe serve --example hello_world
23:02:17 [dev] -----------------------------------------------------------------
                Serving your Dioxus app: hello_world
                • Press `ctrl+c` to exit the server
                • Press `r` to rebuild the app
                • Press `p` to toggle automatic rebuilds
                • Press `v` to toggle verbose logging
                • Press `/` for more commands and shortcuts
                Learn more at https://dioxuslabs.com/learn/0.6/getting_started
               ----------------------------------------------------------------
23:02:25 [cargo] error[E0433]: failed to resolve: use of unresolved module or unlinked crate `dioxus_fullstack`
   --> packages\dioxus\src\launch.rs:346:20
    |
346 |             return dioxus_fullstack::server::launch::launch(app, contexts, configs);
    |                    ^^^^^^^^^^^^^^^^ use of unresolved module or unlinked crate `dioxus_fullstack`
    |
    = help: if you wanted to use a crate named `dioxus_fullstack`, use `cargo add dioxus_fullstack` to add it to your `Cargo.toml`

23:02:25 [cargo] For more information about this error, try `rustc --explain E0433`.
23:02:25 [cargo] error: could not compile `dioxus` (lib) due to 1 previous error
23:02:25 [dev] Build failed: Other(Cargo build failed, signaled by the compiler. Toggle tracing mode (press `t`) for more information.)
╭────────────────────────────────────────────────────────────────────────────────────────── /:more ╮
│  App:     ━━━━━━━━━━━━━━━━━━━━━━━━━━  ❌            Platform: Desktop Windows + fullstack         │
│  Server:  ━━━━━━━━━━━━━━━━━━━━━━━━━━  ❌            App features: ["desktop"]                     │
│  Status:  Failed                                   ServerFns at: http://127.0.0.1:43412          │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯

ealmloff · 2025-04-29T19:42:32Z

gh pr checkout 4042

This does not fix #4046 for me.

This PR changes the CLI to fix the issue so you will need to either install the CLI on the branch or run the CLI package. This command works on for me on macos with this branch:

cargo run --package dioxus-cli -- serve --example dynamic_asset --features desktop

davehorner · 2025-04-30T02:23:32Z

cargo run --package dioxus-cli -- serve --example dynamic_asset --features desktop
I can verify that the PR does fix the problem and produce a working build. The same command does not work on the latest dioxus repo. I'm confused on how the axum playwright affect the hello_world dynamic_asset examples.

Thanks for fixing this. I'd like to understand what happened all the examples were building OK and then all my machines give me errors about unresolved module or unlinked crate dioxus_fullstack

ealmloff · 2025-04-30T11:51:28Z

cargo run --package dioxus-cli -- serve --example dynamic_asset --features desktop I can verify that the PR does fix the problem and produce a working build. The same command does not work on the latest dioxus repo. I'm confused on how the axum playwright affect the hello_world dynamic_asset examples.

Thanks for fixing this. I'd like to understand what happened all the examples were building OK and then all my machines give me errors about unresolved module or unlinked crate dioxus_fullstack

The same issue that was causing playwright tests to fail also broke running the example. When you run an app with dioxus, we try to detect if it is a fullstack app. That logic was broken, so the CLI included fullstack even when fullstack was not enabled

davehorner · 2025-04-30T13:39:26Z

Thanks very much for the fix and explanation.
https://crates.io/crates/cargo-e/
I'm working on tool that helps people run dioxus examples; when this occurs in a random user's project, I guess the only solution is to upgrade the dx cli when this fix becomes available.

we might update this PR's title to reflect the fact that it fixes basic examples too.

nicoburns · 2025-05-02T19:30:14Z

For me, this PR is fixing just regular dx serve for any Dioxus example which is broken on main.

jkelleyrtp · 2025-05-02T19:42:35Z

For me, this PR is fixing just regular dx serve for any Dioxus example which is broken on main.

Another issue with the CLI currently is that we don't set workspace=true when running cargo metadata so a number of our examples / packages don't show up in the list even when they should. I have that enabled in #3797 but it needs better dynamic detection.

…server/client hot-reload (#3797) Enable runtime rust hot patching. * roll back wry to 0.45 * cleanup rustc * wip * wip: fix client/server * get the subsecond cli thing working again * back to list of builds but with accessors * migrate some methods to workspace, clean up impl a bit * pass mode through build context * use a build context, similar to cargo/rustc * merge BuildUpdate and HandleUpdate into BuilderUpdate * Move more resolution of args into runner * migrate some methods to runner * hoist out fullstack * fix build request resolver * yay request is cleaned up * fixup resolution a bit * spawn off the build! * re-wire android autodetection * re-wire android autodetection * wire back up a few more things * re-wire tooling verification * I think it's mostly in the right condition for regular app * add depinfo parser * yay okay works with regular apps again * full rebuilds are back * rewire file wtcher * wire patch! * yayyyyyy patching works and is really fast * yay android works * clean up stdout piping * yayyy memap on android so we don't need root * create a static wasm jump table * wip: global offset table for wasm * wip... thinking about making the patches relocatable * wip: customized relocation * YESSSSSS RELOCATABLE WASM * clean up impl a bit * lil bit more cleanup * lil bit more * lil bit more cleanup * lil bit more cleanup, support 32 bit platforms * sick, wasm is completely pic * hmmmm not quite working yet * woooo, patches loading from rust+wasm * integrated into the cli 😎 * condense a bit * cleaned up request a bit * bust fingerprints * Make the file diffing logic a bit more sensible * still working through a few issues, server launches but is acting weird * fix merge conflict * more merge issues * remove stuff we don't want anymore * revert name change * wip: server not working anymore :( * split apart "dioxus fullstack" into "dioxus server" and "dioxus web" * fixup a few more compile errors * grrr opening server * simultaneous frontend and backend patching * use rustc wrapper * wip: passing assets to jumptable * migrate project-like examples * patchy patchy server fns! * rollback some random changes * unwind the js files * rollback hash * no need for patch * more cleanups * lil bit more cleanup, remove some old cruft * allow patching when wasm webpage is closed * tiny bit more robust * lil bit of clean up * clean up ws code * bit more clean ups * condense * undo file moves * move back other project * move other project * migrate out harness and janky CLI * fix compile * anonymize some files, heavily document others * lots more documentation, for posterity! * ton more docs * clean up the cli a bit more * more ws cleanup * more cleanup * migrate build id to cli-config * add command file handling * random small cleanups * wip.... * wip.... * fix: use workspace for krate discovery * fix panic logging on serve by placing it *after* the logs * reorder logging to be sensible on success * bring back swc * ws cruft * small patches to relocs in loader * bump krates * hoist main funcs into the ifunc table, fixing wasm * fix tui output for long lines * add more linker logging * wow, incredible, we build fat binaries, holy heckkkkk * fix args for frontend/backend * small cleanups * properly send along build IDs to clients * fix workspace compiles * clean up jump table work a bit * clean up logging a bit * open existing * fixup some commands * open existing browser integration * wire up the new dx serve client/server syntax * fixup `dx run` command * bring back some old functionality * fix serverfn feature sets * remove toast animation and simplify its code a bit * less intrusive toast * dont change build status when patching on web * add proper cache busting to vcomponent * clean up the patch file a bit * more lints/checks cleaned up * go back to TargetArgs but a BuildTargets resolved struct * clean up more nits * use an atomicptr for jumptable * fix interaction with initial web load + suspense * don't run asset system on wasm/bindgen js in dev * reduce blast radius of PR * use profile to determine if we're in release * cleanup prod html template * cleanup profiles * fix feature resolution of fullstack * if fullstack is explicitly false, don't use it * light cleanups * drop carg config2 * pass along linker args properly * make workspace examples compile with dx again * fewer unwraps and better error loggign * bit more error handlign * small cleanup * drive-by cleanups * use queries instead of initialize for aslr stuff * fix hotpatch with higher opt level * fix aslr bug from multiple clients * fix merge conflict * fix typos * clippy * fix miscompile * fix doctest * properly rollback wry to 0.45 * fix markdown path issues, other test issues * fix test in router * fix release mode test * fix some more tests, clean up a few more items * use fnptr instead of typeid * clean up memozation via subsecond in core * use "main" as sentinel * fix imports and re-exports * get off __rust_alloc for aslr offset detection * wip * wip... fixing unoptimized web * hmmmm mmmm * close,ish, still missing the wasmbindgen dynaimc imports * aha! full wasm works now - disable externref when compilng patch modules - manually link wasm instrinsics - displace the __wbindgen_placeholder__ table with the synthesized wbg imports what an awful pain. There might be a few items missing, so will test against the docsite shortly * remove failing test * hmmmm things aren't perfect * from what I can tell, relocatable wasm just doesn't work with wasm-bindgen sad wasm-bindgen/wasm-bindgen#1420 * AI IS LITERALLY THE WORST * preserve wasm snippets across compiles * IT HOTPATCHES THE DOCSITE, WE ARE LIVING IN THE FUTURE * remove the macos cfg-out * fix: need to allocate 1 more page * fix url issue * properly span props * properly fill in extra symbols * light cleanups and good docs * delete cruft, better docs * More cleanups and simplifications * clippy, typos * remove harnesses * wasm-bindgen error logging * clean up deps * remove cruft * proper priv/pub * use ifuncs for all env imports * cruft * use par_iter, better output * implement a cache for the base module * delete custom sections * cache the main native module too * add par iter in a few more places * clippy, map ident * better logging and status bars * wip: some small windows support * wip more windowss * fix weird regression * implement windows jump table * small fixes for windows * better windows support * windows support pt2 * rust lld is not msvc * whole archive the rlibs * ignore windows and sys crates * logging * ohhhhhh, pop out dlls * dedupe * thANK GOD FAT LINKING WORKS ON WINDOWS * hoist caching * implement patch based on cache * fix location for pdb * pass data symbols, correct object * add all symbol for windows * add log * treat none rva as undefined * whoops * handle windows calling convention * dont use relocated arm64 stub windows * not all are text? * WINDOWS FUNCTION PATCHING WORKS but issue with statics? * use our own entry * handle windows imp symbols * add log * jump to the real symbol not the layout * whoops * hotpatching windows works completely holy heck yay * drop linker args crate * disable ssg playwright for now * light cleanups * some cleanups / preps: - bump to serverfn 0.8.2 - fix playwright test - fix clippy * use fix from #4042 * bring in other fix for liveview * hoist some configuration * use __aslr_reference instead of aslr_reference * add better errors to patcherror * fix android * panic if patching fails * clean up tomls * wip: fixing wasm compile for server * fullstack wasm again * fix cfg * fixup feature detection * fix issue with features * fix playwright! * add barebones template test harness * fix compatibility between the two hotreload engines * fix preldue of server * fix check for wasm-opt * small fixes

davehorner · 2025-05-08T14:17:17Z

tried the latest main today. The auto-platform detection still returns unknown on many. More concerning now is that calculator and other examples double launch windows.

dx.exe serve --example calculator --features desktop

I have no idea. I can send more log; just wanted to report calculator and dx.exe serve --example custom_menu --features desktop both popp'd double windows. probably others... i'm not sure how to give you a good log; lmk if theres a good way using dx and I will capture.

ealmloff · 2025-05-13T13:46:52Z

tried the latest main today. The auto-platform detection still returns unknown on many. More concerning now is that calculator and other examples double launch windows.
dx.exe serve --example calculator --features desktop

I can't reproduce that issue on this commit with the matching version of the CLI. Try running with the dioxus-cli package from the same commit:

cargo run --package dioxus-cli -- serve --example calculator --features desktop

davehorner · 2025-05-17T10:47:57Z

I went to another machine (windows 11) and it downloaded the dx cli and its popping duplicate windows.
For some reason the carpe diem sample is running when I tell it to run other samples sometimes too.

If you want to see exactly what I'm running try cargo e.
cargo e --run-all 60 -f
https://crates.io/crates/cargo-e

the repo used to run great. the only problem I had was that the examples would not all exit properly. now they do not run or they double windows.

dx --version
dioxus 0.6.3 (was built without git repository)

if you want me to do any checking out or debugging I'm happy to help.

doy. I guess I'm not using the git dx when I'm trying to run git....I get a stack overflow when trying to run the command you specified @ealmloff

git rev-parse --short HEAD
18477a0

C:\w\demos\dioxus>cargo run --package dioxus-cli -- serve --example calculator --features desktop
warning: C:\w\demos\dioxus\Cargo.toml: unused manifest key: dependencies.wasm-splitter.package
warning: C:\w\demos\dioxus\packages\dioxus\Cargo.toml: unused manifest key: dependencies.wasm-splitter.package
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.68s
     Running `target\debug\dx.exe serve --example calculator --features desktop`

thread 'main' has overflowed its stack
error: process didn't exit successfully: `target\debug\dx.exe serve --example calculator --features desktop` (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW)

setting set RUST_BACKTRACE=1 doesn't provide any further information.

cargo run --package dioxus-cli -- --version
dioxus 0.7.0-alpha.0 (18477a0)

I put dx under a debugger.

winnow::token::any::{{closure}} (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\winnow-0.7.10\src\token\mod.rs:61)
union enum2$<core::result::Result<u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > core::ops::function::FnMut::call_mut<enum2$<core::result::Result<u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > (*)(ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> >),tuple$<ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> > > >( * *, struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\ops\function.rs:166)
winnow::combinator::core::peek::{{closure}} (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\winnow-0.7.10\src\combinator\core.rs:119)
toml_edit::parser::value::value::{{closure}} (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\winnow-0.7.10\src\macros\dispatch.rs:84)
<winnow::combinator::impls::WithSpan<F,I,O,E> as winnow::parser::Parser<I,(O,core::ops::range::Range<usize>),E>>::parse_next (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\winnow-0.7.10\src\combinator\impls.rs:489)
<winnow::combinator::impls::Map<F,G,I,O,O2,E> as winnow::parser::Parser<I,O2,E>>::parse_next (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\winnow-0.7.10\src\combinator\impls.rs:58)
union enum2$<core::result::Result<enum2$<toml_edit::value::Value>,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > toml_edit::parser::value::value(struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\toml_edit-0.22.26\src\parser\value.rs:18)
union enum2$<core::result::Result<enum2$<toml_edit::value::Value>,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > core::ops::function::FnMut::call_mut<enum2$<core::result::Result<enum2$<toml_edit::value::Value>,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > (*)(ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> >),tuple$<ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> > > >( * *, struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\ops\function.rs:166)
union enum2$<core::result::Result<enum2$<toml_edit::item::Item>,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > toml_edit::parser::array::array_value(struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\toml_edit-0.22.26\src\parser\array.rs:62)
union enum2$<core::result::Result<enum2$<toml_edit::item::Item>,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > core::ops::function::FnMut::call_mut<enum2$<core::result::Result<enum2$<toml_edit::item::Item>,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > (*)(ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> >),tuple$<ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> > > >( * *, struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\ops\function.rs:166)
union enum2$<core::result::Result<alloc::vec::Vec<enum2$<toml_edit::item::Item>,alloc::alloc::Global>,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > winnow::combinator::multi::separated0_<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,enum2$<toml_edit::item::Item>,alloc::vec::Vec<enum2$<toml_edit::item::Item>,alloc::alloc::Global>,u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,enum2$<core::result::Result<enum2$<toml_edit::item::Item>,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > (*)(ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> >),u8>( * *, unsigned char *, struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\winnow-0.7.10\src\combinator\multi.rs:1120)
union enum2$<core::result::Result<alloc::vec::Vec<enum2$<toml_edit::item::Item>,alloc::alloc::Global>,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > winnow::combinator::multi::separated::closure$0<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,enum2$<toml_edit::item::Item>,alloc::vec::Vec<enum2$<toml_edit::item::Item>,alloc::alloc::Global>,u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,enum2$<core::result::Result<enum2$<toml_edit::item::Item>,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > (*)(ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> >),u8,core::ops::range::RangeFrom<usize> >(struct winnow::combinator::multi::separated::closure_env$0<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,enum2$<toml_edit::item::Item>,alloc::vec::Vec<enum2$<toml_edit::item::Item>,alloc::alloc::Global>,u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,enum2$<core::result::Result<enum2$<toml_edit::item::Item>,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > (*)(ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> >),u8,core::ops::range::RangeFrom<usize> > *, struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\winnow-0.7.10\src\combinator\multi.rs:1089)
union enum2$<core::result::Result<toml_edit::array::Array,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > toml_edit::parser::array::array_values(struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\toml_edit-0.22.26\src\parser\array.rs:48)
union enum2$<core::result::Result<toml_edit::array::Array,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > core::ops::function::FnMut::call_mut<enum2$<core::result::Result<toml_edit::array::Array,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > (*)(ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> >),tuple$<ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> > > >( * *, struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\ops\function.rs:166)
winnow::combinator::core::cut_err::{{closure}} (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\winnow-0.7.10\src\combinator\core.rs:277)
union enum2$<core::result::Result<toml_edit::array::Array,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > winnow::combinator::sequence::delimited::closure$0<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,u8,toml_edit::array::Array,u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,u8,winnow::combinator::core::cut_err::closure_env$0<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,toml_edit::array::Array,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,enum2$<core::result::Result<toml_edit::array::Array,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > (*)(ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> >)>,winnow::combinator::impls::Context<winnow::combinator::impls::Context<winnow::combinator::core::cut_err::closure_env$0<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,u8>,winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,enum2$<winnow::error::StrContext> >,winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,enum2$<winnow::error::StrContext> > >(struct winnow::combinator::sequence::delimited::closure_env$0<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,u8,toml_edit::array::Array,u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,u8,winnow::combinator::core::cut_err::closure_env$0<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,toml_edit::array::Array,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,enum2$<core::result::Result<toml_edit::array::Array,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > (*)(ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> >)>,winnow::combinator::impls::Context<winnow::combinator::impls::Context<winnow::combinator::core::cut_err::closure_env$0<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,u8>,winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,enum2$<winnow::error::StrContext> >,winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck>,u8,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > >,enum2$<winnow::error::StrContext> > > *, struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\winnow-0.7.10\src\combinator\sequence.rs:171)
1428BF036 (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\toml_edit-0.22.26\src\parser\array.rs:19)
union enum2$<core::result::Result<toml_edit::array::Array,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > toml_edit::parser::array::array(struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\toml_edit-0.22.26\src\parser\array.rs:18)
union enum2$<core::result::Result<toml_edit::array::Array,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > core::ops::function::FnMut::call_mut<enum2$<core::result::Result<toml_edit::array::Array,enum2$<winnow::error::ErrMode<winnow::error::ContextError<enum2$<winnow::error::StrContext> > > > > > (*)(ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> >),tuple$<ref_mut$<winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> > > >( * *, struct winnow::stream::stateful::Stateful<winnow::stream::locating::LocatingSlice<ref$<winnow::stream::bstr::BStr> >,toml_edit::parser::prelude::RecursionCheck> *) (c:\Users\dhorner\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\ops\function.rs:166)
toml_edit::parser::prelude::check_recursion::{{closure}} (c:\Users\dhorner\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\toml_edit-0.22.26\src\parser\mod.rs:146)

its toml_edit apparently ::parser::prelude::check_recursion doesn't see this overflow coming.

ps. this comes thru before the overflow.
3.927s TRACE failed to read dioxus/settings.toml config file

davehorner · 2025-05-18T15:50:33Z

just tested on 18477a0 working on win11 and win 10.

…server/client hot-reload (DioxusLabs#3797) Enable runtime rust hot patching. * roll back wry to 0.45 * cleanup rustc * wip * wip: fix client/server * get the subsecond cli thing working again * back to list of builds but with accessors * migrate some methods to workspace, clean up impl a bit * pass mode through build context * use a build context, similar to cargo/rustc * merge BuildUpdate and HandleUpdate into BuilderUpdate * Move more resolution of args into runner * migrate some methods to runner * hoist out fullstack * fix build request resolver * yay request is cleaned up * fixup resolution a bit * spawn off the build! * re-wire android autodetection * re-wire android autodetection * wire back up a few more things * re-wire tooling verification * I think it's mostly in the right condition for regular app * add depinfo parser * yay okay works with regular apps again * full rebuilds are back * rewire file wtcher * wire patch! * yayyyyyy patching works and is really fast * yay android works * clean up stdout piping * yayyy memap on android so we don't need root * create a static wasm jump table * wip: global offset table for wasm * wip... thinking about making the patches relocatable * wip: customized relocation * YESSSSSS RELOCATABLE WASM * clean up impl a bit * lil bit more cleanup * lil bit more * lil bit more cleanup * lil bit more cleanup, support 32 bit platforms * sick, wasm is completely pic * hmmmm not quite working yet * woooo, patches loading from rust+wasm * integrated into the cli 😎 * condense a bit * cleaned up request a bit * bust fingerprints * Make the file diffing logic a bit more sensible * still working through a few issues, server launches but is acting weird * fix merge conflict * more merge issues * remove stuff we don't want anymore * revert name change * wip: server not working anymore :( * split apart "dioxus fullstack" into "dioxus server" and "dioxus web" * fixup a few more compile errors * grrr opening server * simultaneous frontend and backend patching * use rustc wrapper * wip: passing assets to jumptable * migrate project-like examples * patchy patchy server fns! * rollback some random changes * unwind the js files * rollback hash * no need for patch * more cleanups * lil bit more cleanup, remove some old cruft * allow patching when wasm webpage is closed * tiny bit more robust * lil bit of clean up * clean up ws code * bit more clean ups * condense * undo file moves * move back other project * move other project * migrate out harness and janky CLI * fix compile * anonymize some files, heavily document others * lots more documentation, for posterity! * ton more docs * clean up the cli a bit more * more ws cleanup * more cleanup * migrate build id to cli-config * add command file handling * random small cleanups * wip.... * wip.... * fix: use workspace for krate discovery * fix panic logging on serve by placing it *after* the logs * reorder logging to be sensible on success * bring back swc * ws cruft * small patches to relocs in loader * bump krates * hoist main funcs into the ifunc table, fixing wasm * fix tui output for long lines * add more linker logging * wow, incredible, we build fat binaries, holy heckkkkk * fix args for frontend/backend * small cleanups * properly send along build IDs to clients * fix workspace compiles * clean up jump table work a bit * clean up logging a bit * open existing * fixup some commands * open existing browser integration * wire up the new dx serve client/server syntax * fixup `dx run` command * bring back some old functionality * fix serverfn feature sets * remove toast animation and simplify its code a bit * less intrusive toast * dont change build status when patching on web * add proper cache busting to vcomponent * clean up the patch file a bit * more lints/checks cleaned up * go back to TargetArgs but a BuildTargets resolved struct * clean up more nits * use an atomicptr for jumptable * fix interaction with initial web load + suspense * don't run asset system on wasm/bindgen js in dev * reduce blast radius of PR * use profile to determine if we're in release * cleanup prod html template * cleanup profiles * fix feature resolution of fullstack * if fullstack is explicitly false, don't use it * light cleanups * drop carg config2 * pass along linker args properly * make workspace examples compile with dx again * fewer unwraps and better error loggign * bit more error handlign * small cleanup * drive-by cleanups * use queries instead of initialize for aslr stuff * fix hotpatch with higher opt level * fix aslr bug from multiple clients * fix merge conflict * fix typos * clippy * fix miscompile * fix doctest * properly rollback wry to 0.45 * fix markdown path issues, other test issues * fix test in router * fix release mode test * fix some more tests, clean up a few more items * use fnptr instead of typeid * clean up memozation via subsecond in core * use "main" as sentinel * fix imports and re-exports * get off __rust_alloc for aslr offset detection * wip * wip... fixing unoptimized web * hmmmm mmmm * close,ish, still missing the wasmbindgen dynaimc imports * aha! full wasm works now - disable externref when compilng patch modules - manually link wasm instrinsics - displace the __wbindgen_placeholder__ table with the synthesized wbg imports what an awful pain. There might be a few items missing, so will test against the docsite shortly * remove failing test * hmmmm things aren't perfect * from what I can tell, relocatable wasm just doesn't work with wasm-bindgen sad wasm-bindgen/wasm-bindgen#1420 * AI IS LITERALLY THE WORST * preserve wasm snippets across compiles * IT HOTPATCHES THE DOCSITE, WE ARE LIVING IN THE FUTURE * remove the macos cfg-out * fix: need to allocate 1 more page * fix url issue * properly span props * properly fill in extra symbols * light cleanups and good docs * delete cruft, better docs * More cleanups and simplifications * clippy, typos * remove harnesses * wasm-bindgen error logging * clean up deps * remove cruft * proper priv/pub * use ifuncs for all env imports * cruft * use par_iter, better output * implement a cache for the base module * delete custom sections * cache the main native module too * add par iter in a few more places * clippy, map ident * better logging and status bars * wip: some small windows support * wip more windowss * fix weird regression * implement windows jump table * small fixes for windows * better windows support * windows support pt2 * rust lld is not msvc * whole archive the rlibs * ignore windows and sys crates * logging * ohhhhhh, pop out dlls * dedupe * thANK GOD FAT LINKING WORKS ON WINDOWS * hoist caching * implement patch based on cache * fix location for pdb * pass data symbols, correct object * add all symbol for windows * add log * treat none rva as undefined * whoops * handle windows calling convention * dont use relocated arm64 stub windows * not all are text? * WINDOWS FUNCTION PATCHING WORKS but issue with statics? * use our own entry * handle windows imp symbols * add log * jump to the real symbol not the layout * whoops * hotpatching windows works completely holy heck yay * drop linker args crate * disable ssg playwright for now * light cleanups * some cleanups / preps: - bump to serverfn 0.8.2 - fix playwright test - fix clippy * use fix from DioxusLabs#4042 * bring in other fix for liveview * hoist some configuration * use __aslr_reference instead of aslr_reference * add better errors to patcherror * fix android * panic if patching fails * clean up tomls * wip: fixing wasm compile for server * fullstack wasm again * fix cfg * fixup feature detection * fix issue with features * fix playwright! * add barebones template test harness * fix compatibility between the two hotreload engines * fix preldue of server * fix check for wasm-opt * small fixes

Fix liveview routing

1af064a

ealmloff added bug Something isn't working liveview Related to the liveview renderer ci github ci labels Apr 25, 2025

ealmloff requested a review from a team as a code owner April 25, 2025 13:55

Only look for direct dependencies on dioxus features

489e12d

ealmloff changed the title ~~Fix liveview routing~~ Fix playwright tests Apr 28, 2025

nicoburns approved these changes Apr 28, 2025

View reviewed changes

fix wasm split test

f42a72b

ealmloff changed the title ~~Fix playwright tests~~ Fix playwright tests, liveview and feature selection Apr 30, 2025

This was referenced May 1, 2025

Fix dx serve proxying of websocket connections established from the browser #3895

Merged

Move asset hashing into the CLI #3988

Merged

jkelleyrtp added a commit that referenced this pull request May 6, 2025

use fix from #4042

c906f15

fix ssg port

6c92dec

ealmloff closed this May 7, 2025

davehorner mentioned this pull request May 17, 2025

dioxus 18477a0 stack overflow landing in toml_edit::parser::prelude::check_recursion toml-rs/toml#903

Closed

Uh oh!

Fix playwright tests, liveview and feature selection #4042

Fix playwright tests, liveview and feature selection #4042

Uh oh!

Conversation

ealmloff commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ealmloff commented Apr 28, 2025

Uh oh!

davehorner commented Apr 29, 2025

Uh oh!

ealmloff commented Apr 29, 2025

Uh oh!

davehorner commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ealmloff commented Apr 30, 2025

Uh oh!

davehorner commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicoburns commented May 2, 2025

Uh oh!

jkelleyrtp commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davehorner commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ealmloff commented May 13, 2025

Uh oh!

davehorner commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davehorner commented May 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ealmloff commented Apr 25, 2025 •

edited

Loading

davehorner commented Apr 30, 2025 •

edited

Loading

davehorner commented Apr 30, 2025 •

edited

Loading

jkelleyrtp commented May 2, 2025 •

edited

Loading

davehorner commented May 8, 2025 •

edited

Loading

davehorner commented May 17, 2025 •

edited

Loading