Skip to content

1st code review #24

@tshemsedinov

Description

@tshemsedinov
  1. Improve naming, for example checker.isFalse and checker.isTrue is not ok, better check
  2. Refactor duplicate blocks like https://github.com/Dimdim28/-queue-bot/blob/e589b87795a60b4115d6408ef91eb5c4946283fe/onCommand.js#L532-L535
  3. Try to invent DSL, js-subset or data-structure for your domain because this js code in not expressive enough
  4. Do not use unreadable regular expressions for such simple cases
  5. Need linters and tests

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions