Skip to content

Make pythonIoc pip installable #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 23, 2021
Merged

Make pythonIoc pip installable #5

merged 19 commits into from
Jun 23, 2021

Conversation

@thomascobb
Copy link
Contributor

At the moment it is an EPICS module that embeds Python. This PR will make it a Python module that embeds an EPICS IOC.

@thomascobb
Copy link
Contributor Author

@Araneidae this is working apart from a couple of things with devIocStats

  1. We don't use the epics build system to make ioc.db, and dbLoadDatabase doesn't like ioc.template because it contains the msi "substitute" command. I can get round this in Python
  2. Loading devIocStats gives: Error (511,35) PV: TS-DI-TEST-01:SYSRESET Proc subroutine (SNAM). This is a mystery to me as the relevant routine appears when you do strings on the extension that I built. Any ideas?

@thomascobb
Copy link
Contributor Author

I'll add the CI and more tests when these things are working...

@thomascobb
Copy link
Contributor Author

@mdavidsaver notes that 2. is because registerAllRecordDeviceDrivers() isn't handling function(). He'll look at modifying this in EPICS base...

mdavidsaver
mdavidsaver reviewed Feb 25, 2021
View reviewed changes
thomascobb
thomascobb commented Feb 26, 2021
View reviewed changes
thomascobb
thomascobb commented Feb 26, 2021
View reviewed changes
Araneidae
Araneidae reviewed Feb 26, 2021
View reviewed changes
This was referenced Mar 5, 2021
Closed
Closed
@thomascobb thomascobb force-pushed the on-its-head branch 9 times, most recently from 536f51e to ae8178f Compare May 6, 2021 13:08
@thomascobb thomascobb force-pushed the on-its-head branch 2 times, most recently from 36f3258 to 16324f7 Compare May 14, 2021 16:22
@thomascobb
Copy link
Contributor Author

Ok, this should be ready to review again, just docs left to do

@thomascobb thomascobb requested a review from Araneidae May 14, 2021 16:33
thomascobb
thomascobb commented May 17, 2021
View reviewed changes
@thomascobb thomascobb force-pushed the on-its-head branch 5 times, most recently from f794cb6 to 7238690 Compare May 17, 2021 14:40
@thomascobb
Copy link
Contributor Author

Once we have a 1.4.1 release of epicsdbbuilder, then I can regenerate Pipfile.lock with DLS deps, then I think I'm done here

@thomascobb thomascobb mentioned this pull request May 18, 2021
Merged
Araneidae
Araneidae reviewed Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@Araneidae Araneidae left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore!

Araneidae
Araneidae reviewed Jun 16, 2021
View reviewed changes
@thomascobb thomascobb mentioned this pull request Jun 21, 2021
Closed
@thomascobb thomascobb merged commit 418e317 into master Jun 23, 2021
@thomascobb thomascobb deleted the on-its-head branch June 23, 2021 08:55
@Araneidae Araneidae mentioned this pull request Jun 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Araneidae Araneidae Araneidae left review comments

+1 more reviewer

@mdavidsaver mdavidsaver mdavidsaver left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thomascobb @Araneidae @mdavidsaver @coretl