Improve string representation of RecordWrapper #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The returned string is the full DeviceName:RecordName. Previously the string representation would be lost when builder.LoadDatabase() is called, as the __builder instance is removed and so __str__ returns None. The __device is not removed at any point, and so can always be safely used to fetch the full name.
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 87.34% 87.44% +0.10%
==========================================
Files 14 14
Lines 996 996
==========================================
+ Hits 870 871 +1
+ Misses 126 125 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returned string is the full DeviceName:RecordName.
Previously the string representation would be lost when builder.LoadDatabase() is called, as the __builder instance is removed and so str returns None.
The __device is not removed at any point, and so can always be safely used to fetch the full name.
Fixes #129