-
Notifications
You must be signed in to change notification settings - Fork 3
Vefb Changes #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vefb Changes #32
Conversation
|
Added a fix for a bug Phil found, also we should do a release of atip after this merges as there hasn't been one since 2022 |
It probably makes sense to do the copier-template refactor first and make sure everything is still working with the latest python versions etc before doing the (major) release. We could also include the transition to using aioca in this release? Or maybe we do another release with this, im not sure. Then if we want to add more features etc for diamond 2 then we can do a further release. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 6 6
Lines 390 390
=======================================
Hits 366 366
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ready for review whenever you get a chance @MJGaughran |
Mainly changes to get VEFB working against the virtac again after DiamondLightSource/pythonSoftIOC#82 broke it