Skip to content

Conversation

@T-Nicholls
Copy link
Collaborator

Mainly changes to get VEFB working against the virtac again after DiamondLightSource/pythonSoftIOC#82 broke it

@T-Nicholls
Copy link
Collaborator Author

Added a fix for a bug Phil found, also we should do a release of atip after this merges as there hasn't been one since 2022

@ptsOSL
Copy link
Collaborator

ptsOSL commented Mar 25, 2025

Added a fix for a bug Phil found, also we should do a release of atip after this merges as there hasn't been one since 2022

It probably makes sense to do the copier-template refactor first and make sure everything is still working with the latest python versions etc before doing the (major) release. We could also include the transition to using aioca in this release? Or maybe we do another release with this, im not sure.

Then if we want to add more features etc for diamond 2 then we can do a further release.

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (b6946e9) to head (d20b264).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files           6        6           
  Lines         390      390           
=======================================
  Hits          366      366           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@T-Nicholls T-Nicholls requested a review from ptsOSL April 25, 2025 17:21
@T-Nicholls
Copy link
Collaborator Author

Ready for review whenever you get a chance @MJGaughran

@ptsOSL ptsOSL merged commit 8942c3a into main Apr 30, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants