Skip to content

[pull] master from codesandbox:master #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2022
Merged

[pull] master from codesandbox:master #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/app/src/sandbox/compile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,10 @@ async function compile(opts: CompileOptions) {
if (typeof (window as any).__puppeteer__ === 'function') {
setTimeout(() => {
// Give everything some time to evaluate
(window as any).__puppeteer__('done');
(window as any).__puppeteer__({
type: 'done',
compilatonError: hadError,
});
}, 100);
}
}
Expand Down
4 changes: 2 additions & 2 deletions packages/sse-hooks/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import hookConsole from 'sandbox-hooks/console';
import setupHistoryListeners from 'sandbox-hooks/url-listeners';
import setupScreenshotListener from 'sandbox-hooks/screenshot'
import setupScreenshotListener from 'sandbox-hooks/screenshot';
import { listenForPreviewSecret } from 'sandbox-hooks/preview-secret';
import { dispatch, isStandalone } from 'codesandbox-api';

Expand All @@ -14,6 +14,6 @@ if (!isStandalone) {

setTimeout(() => {
if (typeof window.__puppeteer__ === 'function') {
window.__puppeteer__('done');
window.__puppeteer__({ type: 'done' });
}
}, 1000);