-
Notifications
You must be signed in to change notification settings - Fork 3
pull reqeust for new metric support #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull reqeust for new metric support #11
Conversation
…ons bug for acceptance rate (by lines); remove unused variables in SeatsAnalysisViewer
… sources for top 5 accepted prompts
…te labels, improve clarity, and reorder cards for better focus on acceptance rates by count
… enhance error handling and improve code readability
…age paths for key metrics
…/DevOps-zhuang/copilot-metrics-viewer into Feature/AddAcceptanceRatebycount
…the old one is called metrics
…usage route 2) add MetricsToUsageConverter class, to map the new returned metrics schedma to old metrics schema, so the caller don't need to update more. 3) add CopilotUsageChecker to check the data quality of the new fetched schema, and display it in api-response page.
…re, simplify the button layout in the ApiResponse component.
Bumps the npm_and_yarn group with 3 updates in the / directory: [axios](https://github.com/axios/axios), [express](https://github.com/expressjs/express) and [nanoid](https://github.com/ai/nanoid). Bumps the npm_and_yarn group with 5 updates in the /api directory: | Package | From | To | | --- | --- | --- | | [axios](https://github.com/axios/axios) | `1.7.2` | `1.7.4` | | [cookie](https://github.com/jshttp/cookie) | `0.6.0` | `0.7.1` | | [express](https://github.com/expressjs/express) | `4.19.2` | `4.21.2` | | [express-session](https://github.com/expressjs/session) | `1.18.0` | `1.18.1` | | [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) | `3.0.0` | `3.0.3` | Updates `axios` from 1.7.7 to 1.7.9 - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.7.7...v1.7.9) Updates `express` from 4.21.1 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.21.1...4.21.2) Updates `path-to-regexp` from 0.1.10 to 0.1.12 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12) Updates `nanoid` from 3.3.7 to 3.3.8 - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) Updates `axios` from 1.7.2 to 1.7.4 - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.7.7...v1.7.9) Updates `cookie` from 0.6.0 to 0.7.1 - [Release notes](https://github.com/jshttp/cookie/releases) - [Commits](jshttp/cookie@v0.6.0...v0.7.1) Updates `express` from 4.19.2 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.21.1...4.21.2) Updates `express-session` from 1.18.0 to 1.18.1 - [Release notes](https://github.com/expressjs/session/releases) - [Changelog](https://github.com/expressjs/session/blob/master/HISTORY.md) - [Commits](expressjs/session@v1.18.0...v1.18.1) Updates `express` from 4.19.2 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.21.1...4.21.2) Updates `body-parser` from 1.20.2 to 1.20.3 - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@1.20.2...1.20.3) Updates `path-to-regexp` from 0.1.7 to 0.1.12 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12) Updates `send` from 0.18.0 to 0.19.0 - [Release notes](https://github.com/pillarjs/send/releases) - [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md) - [Commits](pillarjs/send@0.18.0...0.19.0) Updates `serve-static` from 1.15.0 to 1.16.2 - [Release notes](https://github.com/expressjs/serve-static/releases) - [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md) - [Commits](expressjs/serve-static@v1.15.0...v1.16.2) Updates `http-proxy-middleware` from 3.0.0 to 3.0.3 - [Release notes](https://github.com/chimurai/http-proxy-middleware/releases) - [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/master/CHANGELOG.md) - [Commits](chimurai/http-proxy-middleware@v3.0.0...v3.0.3) Updates `micromatch` from 4.0.7 to 4.0.8 - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.7...4.0.8) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: express dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: path-to-regexp dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: nanoid dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: axios dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: cookie dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: express dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: express-session dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: express dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: body-parser dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: path-to-regexp dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: send dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: serve-static dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: http-proxy-middleware dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: micromatch dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]>
…der positions and container structure.
…alid metrics output
…and_yarn/npm_and_yarn-d9cb2d3d26 Bump the npm_and_yarn group across 2 directories with 11 updates
feat: upgrade dockerfile and replace deprecated node14
…ainer Devcontainer for local development
Signed-off-by: Piotr Karpala <[email protected]>
Playwright tests + switching to alpine images
Signed-off-by: Piotr Karpala <[email protected]>
…ilot-metrics Feature/new copilot metrics API - replaces #125
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 36 out of 47 changed files in this pull request and generated 4 comments.
Files not reviewed (11)
- .devcontainer/devcontainer.json: Language not supported
- .dockerignore: Language not supported
- .env: Language not supported
- Dockerfile: Language not supported
- api.Dockerfile: Language not supported
- api/docker-entrypoint.api/entrypoint.sh: Language not supported
- api/package.json: Language not supported
- package.json: Language not supported
- src/api/ExtractSeats.ts: Evaluated as low risk
- src/api/GitHubApi.ts: Evaluated as low risk
- api/server.mjs: Evaluated as low risk
Comments suppressed due to low confidence (25)
playwright.docker.config.ts:6
- [nitpick] The timeout is set to 5 seconds, which might be too short for some tests and could cause them to fail prematurely. Consider increasing the timeout value.
timeout: 5 * 1000,
playwright.docker.config.ts:9
- [nitpick] Verify if the path for
outputFolder
in the reporter configuration is correct and accessible.
['html', { open: 'never', outputFolder: '/test-results/html' }],
playwright.docker.config.ts:11
- [nitpick] Verify if the path for
outputFile
in the reporter configuration is correct and accessible.
['junit', { outputFile: '/test-results/junit/results.xml' }],
playwright.docker.config.ts:20
- [nitpick] Ensure the command and paths in the
webServer
configuration are correct and will work as expected in the Docker environment.
command: '/api/docker-entrypoint.api/entrypoint.sh',
README.md:73
- The sentence should start with a capital letter: 'A bar chart that illustrates...'
4. **Total Active Copilot Chat Users:** a bar chart that illustrates the total number of users who have actively interacted with Copilot over the past 28 days.
README.md:80
- The sentence should be: '...within the current organization/enterprise.'
1. **Total Assigned:** This metric represents the total number of Copilot seats assigned within current organization/enterprise.
README.md:84
- The sentence should start with a capital letter: 'Never used seats or seats used...'
3. **No Activity in the Last 7 days:** never used seats or seats used, but with no activity in the past 7 days.
README.md:86
- The sentence should start with a capital letter: 'A table to display...'
4. **No Activity in the last 7 days (including never used seats):** a table to display seats that have had no activity in the past 7 days, ordered by the date of last activity.
README.md:88
- The heading should be: '## Setup Instructions'
## Setup instructions
README.md:105
- The heading should be: '#### VUE_APP_GITHUB_TEAM'
#### VUE_APP_GITHUB_TEAM
README.md:122
- The code block should be closed with '```' instead of '````'
**README.md:133**
* The heading should be: '## Install Dependencies'
Install dependencies
**README.md:138**
* The heading should be: '### Compiles and Runs the Application'
Compiles and runs the application
**README.md:146**
* The heading should be: '### Docker Build'
Docker build
**README.md:152**
* The heading should be: '### Docker Run'
Docker run
**README.md:162**
* The sentence should be: 'The project can run with an API proxy which hides GitHub tokens and is secure enough to be deployed.'
Project can run with an API proxy which hides GitHub tokens and is secure enough to be deployed.
**README.md:163**
* The sentence should be: 'The API Proxy project is in the `\api` directory. The Vue app makes the calls to `/api/github` which are then proxied to `https://api.github.com` with the appropriate bearer token.'
Api Proxy project is in \api
directory. Vue app makes the calls to /api/github
which then are proxied to https://api.github.com
with appropriate bearer token.
**README.md:165**
* The sentence should be: 'The proxy can authenticate the user using a GitHub App. In order to do that, the following environment variables are required:'
Proxy can authenticate user using GitHub App. In order to do that, following environment variables are required:
**README.md:166**
* The sentence should be: '* `GITHUB_CLIENT_ID` - client ID of the GitHub App registered and installed in the enterprise/org with permissions listed above.'
GITHUB_CLIENT_ID
- client Id of the GitHub App registered and installed in the enterprise/org with permissions listed above.
**README.md:171**
* The sentence should be: 'If you want to use a custom path for your `.env` file, you can set the environment variable `DOTENV_CONFIG_PATH`.'
If you want use a custom path for your .env
file you can set the environment variable DOTENV_CONFIG_PATH
.
**README.md:173**
* The sentence should be: 'It's also possible to run with a **PAT Token**, see examples below for required variables.'
It's also possible to run with PAT Token, see examples below for required variables.
**README.md:175**
* The sentence should be: 'For local development, register `http://localhost:3000/callback` as the GitHub App callback URI.'
For local development register http://localhost:3000/callback
as GH App callback Uri.
**README.md:177**
* The sentence should be: 'To build and run the app with the API proxy:'
To build and run the app with API proxy:
**README.md:199**
* The sentence should be: 'The proxy can also run with the token hardcoded on the backend (which hides it from frontend calls), here's a sample:'
Proxy can also run with token hardcoded on the backend (which hides it from frontend calls), here's a sample:
**README.md:233**
* The sentence should be: '...and our wonderful contributors.'
This project is independently developed and maintained, and is not an official GitHub product. It thrives through the dedicated efforts of (@martedesco), (@karpikpl) our wonderful contributors. A heartfelt thanks to all our contributors! ✨
</details>
The main change is about the rule change of the calcuation of Acceptance Rate, drill it to Acceptance Rate (By counts), and by lines.