Added minimap file #272
Open
Added minimap file #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweakimp
reviewed
May 5, 2019
sc2/minimap.py
Outdated
| return map_data | ||
|
|
||
| @property_cache_forever | ||
| def heighmap(self): |
sc2/minimap.py
Outdated
| def add_minerals(self, map_data): | ||
| for mineral in self.game.state.resources: | ||
| mine_pos = mineral.position | ||
| cv2.circle(map_data, (int(mine_pos[0]*self.map_scale), int(mine_pos[1]*self.map_scale)), int(mineral.radius*self.map_scale), (255, 255, 86), -1) |
Contributor
There was a problem hiding this comment.
minerals are 1.5*0.5 rectangles
sc2/minimap.py
Outdated
| return map_data | ||
|
|
||
| def add_minerals(self, map_data): | ||
| for mineral in self.game.state.resources: |
Contributor
There was a problem hiding this comment.
use mineral_field, because resources also contains the geysers
tweakimp
reviewed
May 5, 2019
sc2/minimap.py
Outdated
| cv2.rectangle( | ||
| map_data, | ||
| ( | ||
| int((unit.position[0] - unit.radius / 2) * self.map_scale), |
Contributor
There was a problem hiding this comment.
you dont need to devide the radius by 2
sc2/minimap.py
Outdated
| # for unit in self.game.state.towers: | ||
| # cv2.circle(map_data, (int(unit.position[0]*self.map_scale), int(unit.position[1]*self.map_scale)), int(unit.radius*self.map_scale), (0, 250, 250), -1) | ||
|
|
||
| for unit in self.game.known_enemy_units: |
Contributor
There was a problem hiding this comment.
isnt this a duplicate of add_enemies?
sc2/minimap.py
Outdated
| (color, color, color), | ||
| -1, | ||
| ) | ||
| if self.show_ramps: |
Contributor
There was a problem hiding this comment.
everything in here are just map tiles, no real objects, so they should be squares not circles
sc2/minimap.py
Outdated
| show_allies=True, | ||
| show_enemies=True | ||
| ): | ||
| self.game = game |
Contributor
There was a problem hiding this comment.
add all colors to init to be able to change them easier and add a comment what color it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.