-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Bug Fix: improve Kiuwan SCA parser to support multi component findings #12753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bugfix
Are you sure you want to change the base?
Conversation
TODO: Ideally you extend the test suite in I will soon check how to update & run unit tests, any info/docs on it appreciated :) |
Thanks for looking into this, information on running unit tests: https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/DOCKER.md#run-the-tests-with-docker-compose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valentijnscholten what do you think of this approach?
@mwager how are things going here? |
@Maffooch Sorry, I forgot to update the tests. Done from my side now! |
@Maffooch @valentijnscholten Does it look good to you? :) |
@valentijnscholten should be good to go now? |
We've realized that the PR will result in violations of the (logical) "unique" constraint for the |
@shodanwashere Could you have a look and discuss this with the team? Thx! |
@valentijnscholten true, since two components could have the exact same vuln, the IDs would no longer be unique. does the |
@shodanwashere Using the |
@valentijnscholten does it look good now? |
i'll assume that's what we're intending to do. @valentijnscholten will it work like how @mwager has implemented? |
This PR enhances the Kiuwan SCA Parser by modifying the logic to create one finding per component, instead of taking only the first component from the components array.
The buggy code:
Motivation
In the current implementation, for a given CVE from a Kiuwan SCA scan, only the first component listed is used to create a finding. However, many CVEs in Kiuwan are related to multiple components. This leads to loss of detail and incomplete representation of risks in DefectDojo.
Test results
This checklist is for your information.
bugfix
branch.