Chore: Add Lucy Edit fast #29
Merged
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
AdirAmsalem
reviewed
Nov 20, 2025
AdirAmsalem
approved these changes
Nov 20, 2025
AdirAmsalem
reviewed
Nov 22, 2025
src/shared/model.ts
Outdated
Comment on lines
182
to
185
| num_inference_steps: z | ||
| .number() | ||
| .optional() | ||
| .describe("The number of inference steps"), |
Contributor
There was a problem hiding this comment.
I was just informed that num_inference_steps isn't available in lucy-fast-v2v so let's remove it
AdirAmsalem
reviewed
Nov 22, 2025
src/shared/model.ts
Outdated
| name: "lucy-fast-v2v" as const, | ||
| fps: 25, | ||
| width: 1280, | ||
| height: 704, |
Contributor
There was a problem hiding this comment.
Suggested change
| height: 704, | |
| height: 720, |
AdirAmsalem
reviewed
Nov 22, 2025
tests/unit.test.ts
Outdated
| model: models.video("lucy-fast-v2v"), | ||
| prompt: "Change the car to a motorcycle", | ||
| data: testVideo, | ||
| resolution: "480p", |
Contributor
There was a problem hiding this comment.
We removed 480p from Lucy Pro V2V in an earlier PR (#28) so it's best to pull the latest changes from main and update the PR accordingly
AdirAmsalem
reviewed
Nov 22, 2025
src/shared/model.ts
Outdated
| "The video data to use for generation (File, Blob, ReadableStream, URL, or string URL)", | ||
| ), | ||
| seed: z.number().optional().describe("The seed to use for the generation"), | ||
| resolution: proResolutionSchema(), |
Contributor
There was a problem hiding this comment.
Needs to be proV2vResolutionSchema so it'll be aligned with the v2v models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.