Skip to content

Exclude BoundMethodHandleMetadataSizeTest from running on IBM JDK 8 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Exclude BoundMethodHandleMetadataSizeTest from running on IBM JDK 8 #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19164c2
Exclude BoundMethodHandleMetadataSizeTest from running on IBM JDK 8
jbachorik Jul 22, 2025
3307907
Fix AP commit lock
jbachorik Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ddprof-lib/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def cloneAPTask = tasks.register('cloneAsyncProfiler') {
if (!targetDir.exists()) {
println "Cloning missing async-profiler git subdirectory..."
exec {
commandLine 'git', 'clone', '--branch', branch_lock, '--depth', '1', 'https://github.com/datadog/async-profiler.git', targetDir.absolutePath
commandLine 'git', 'clone', '--branch', branch_lock, 'https://github.com/datadog/async-profiler.git', targetDir.absolutePath
}
exec {
workingDir targetDir.absolutePath
Expand Down
1 change: 1 addition & 0 deletions ...test/src/test/java/com/datadoghq/profiler/metadata/BoundMethodHandleMetadataSizeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ protected String getProfilerCommand() {
@Test
public void test() throws Throwable {
assumeFalse(Platform.isJ9() && isAsan()); // running this test on j9 and asan is weirdly crashy
assumeFalse(Platform.isJ9() && Platform.isJavaVersion(8)); // geting crash-failur in CI reliable; remove once that is fixed
assumeFalse(Platform.isJ9() && Platform.isJavaVersion(17)); // JVMTI::GetClassSignature() is reliably crashing on a valid 'class' instance
assumeFalse(Platform.isAarch64() && Platform.isMusl() && !Platform.isJavaVersionAtLeast(11)); // aarch64 + musl + jdk 8 will crash very often
registerCurrentThreadForWallClockProfiling();
Expand Down
2 changes: 1 addition & 1 deletion gradle/ap-lock.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
branch=dd/master
commit=b034e4c3141d0632fd60bc452d7532d84adad572
commit=87b7b42ec65be0a00a67e3f9451fb8e4d472b188
Loading