Skip to content

Conversation

@r1viollet
Copy link
Collaborator

@r1viollet r1viollet commented Jul 8, 2025

What does this PR do?:

  • Change the way the debug file is published

We discussed that the debug info could be moved into the main JAR.
This will make it easier to push the .debug file into the sonatype (instead of creating a separate JAR).
As we create a separate JAR for dd-trace-java, we don't need to worry about increasing the footprint of the deployed library.

  • Add a linker flag to ensure build ID is added (even on musl)

Motivation:

Ensure we can download debug info from maven.
Simplify how debug info is published.

Additional Notes:

This will require a simple downstream PR (changing the folder we are looking at)

How to test the change?:

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: [JIRA-XXXX]

Unsure? Have a question? Request a review!

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

🔧 Report generated by pr-comment-scanbuild

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

🔧 Report generated by pr-comment-cppcheck

CppCheck Report

Errors (2)

Warnings (4)

Style Violations (301)

@r1viollet r1viollet marked this pull request as ready for review July 8, 2025 09:59
@r1viollet r1viollet marked this pull request as draft July 8, 2025 10:06
@r1viollet r1viollet force-pushed the r1viollet/publish-debug-info branch from 952b058 to 3d577cd Compare July 8, 2025 10:08
- Publish debug info
- Add a linker flag to ensure build ID is added (even on musl)
@r1viollet r1viollet force-pushed the r1viollet/publish-debug-info branch from 3d577cd to 3603c4a Compare July 9, 2025 13:15
@r1viollet r1viollet force-pushed the r1viollet/publish-debug-info branch 3 times, most recently from 0d76a64 to c4de82e Compare July 9, 2025 16:18
@r1viollet r1viollet force-pushed the r1viollet/publish-debug-info branch from c4de82e to b5723a7 Compare July 10, 2025 09:46
@r1viollet r1viollet marked this pull request as ready for review July 10, 2025 10:13
@r1viollet
Copy link
Collaborator Author

jar -tf ./ddprof-1.29.0-r1viollet_publish-debug-info-20250710.101139-6.jar
...
com/datadoghq/profiler/Platform$JvmRuntime.class
com/datadoghq/profiler/Platform.class
META-INF/native-libs/
META-INF/native-libs/linux-arm64/
META-INF/native-libs/linux-arm64/libjavaProfiler.so
META-INF/native-libs/linux-arm64/libjavaProfiler.so.debug
META-INF/native-libs/linux-arm64-musl/
META-INF/native-libs/linux-arm64-musl/libjavaProfiler.so
META-INF/native-libs/linux-arm64-musl/libjavaProfiler.so.debug
META-INF/native-libs/linux-x64/
META-INF/native-libs/linux-x64/libjavaProfiler.so
META-INF/native-libs/linux-x64/libjavaProfiler.so.debug
META-INF/native-libs/linux-x64-musl/
META-INF/native-libs/linux-x64-musl/libjavaProfiler.so
META-INF/native-libs/linux-x64-musl/libjavaProfiler.so.debug

@r1viollet r1viollet merged commit f36444e into main Jul 10, 2025
183 of 184 checks passed
@r1viollet r1viollet deleted the r1viollet/publish-debug-info branch July 10, 2025 12:53
@github-actions github-actions bot added this to the 1.29.0 milestone Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants