-
Notifications
You must be signed in to change notification settings - Fork 10
Split debug - publish debug info #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔧 Report generated by pr-comment-scanbuild |
952b058 to
3d577cd
Compare
- Publish debug info - Add a linker flag to ensure build ID is added (even on musl)
3d577cd to
3603c4a
Compare
…t/publish-debug-info
0d76a64 to
c4de82e
Compare
c4de82e to
b5723a7
Compare
|
jbachorik
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
We discussed that the debug info could be moved into the main JAR.
This will make it easier to push the .debug file into the sonatype (instead of creating a separate JAR).
As we create a separate JAR for dd-trace-java, we don't need to worry about increasing the footprint of the deployed library.
Motivation:
Ensure we can download debug info from maven.
Simplify how debug info is published.
Additional Notes:
This will require a simple downstream PR (changing the folder we are looking at)
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!