Improve robustness of stream socket tests #240
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the test more robust by waiting for the expected error state to be reached. "broken pipe" is the initial error sender gets when trying to write to the disconnected socket, but it can not be reliably observed due to lack of synchronization between the sender thread and the test body.
vickenty
force-pushed
the
vickenty/unixstream-test
branch
from
8b33561 to
6860564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the test more robust by waiting for the expected error state to be reached. "broken pipe" is the initial error sender gets when trying to write to the disconnected socket, but it can not be reliably observed due to lack of synchronization between the sender thread and the test body.