Skip to content

Conversation

@ledoug
Copy link
Contributor

@ledoug ledoug commented Nov 19, 2025

What does this PR do? What is the motivation?

Updates Data Access Control documentation in preparation for GA. These updates:

  • Reflect which telemetry types are part of GA vs still in preview
  • Clarifies updated interaction between Logs RBAC and DAC
  • Adds usage constraint for Monitors not being subject to DAC restrictions
  • Updated RUM constraints -- Session Replay sub-features do not get turned off now unless RUM is in a dataset

Merge instructions

Merge readiness:

  • [ X] Ready for merge

@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@ledoug
Copy link
Contributor Author

ledoug commented Nov 19, 2025

@amyli-dd and @abe-lin-dd to review as well

@ledoug ledoug marked this pull request as ready for review November 19, 2025 17:58
@ledoug ledoug requested a review from a team as a code owner November 19, 2025 17:58

#### Session Replay: Extended Retention
By default, Session Replay data is retained for 30 days. To extend retention to 15 months, you can enable Extended Retention on individual session replays. When you enroll in the Preview for Data Access Control, Datadog disables the option for Extended Retention. Extended Retention does not work with Data Access Control because the data store that holds the extended data does not support access restrictions.
By default, Session Replay data is retained for 30 days. To extend retention to 15 months, you can enable Extended Retention on individual session replays. Extended Retention does not work with Data Access Control because the data store that holds the extended data does not support access restrictions. When you create a restricted dataset for RUM, Datadog disables the option for Extended Retention.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just remove this?

Extended Retention does not work with Data Access Control because the data store that holds the extended data does not support access restrictions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, best not to delve into implementation details imo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Data Access Control is separate from the existing [Logs RBAC permissions][11] feature, also known as log restriction queries. We recommend using a single solution to restrict logs data, but user access be limited by restrictions applied from either system.

### Monitors
Users can create Monitors that query and alert on active telemetry. While the user will only be able to directly query data they’re allowed to access, the Monitor will operate as a System User with full access to data. This will be addressed in a future iteration. We encourage customers who are concerned about this to carefully monitor which Monitors are created by their users and restrict the ability to create these Monitors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like "This gap will be addressed in a future iteration." ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@joepeeples
Copy link
Contributor

joepeeples commented Nov 19, 2025

Opened DOCS-12727 to assign a Docs writer and follow up with editorial review.

@joepeeples joepeeples added the editorial review Waiting on a more in-depth review label Nov 19, 2025
- Logs
- RUM sessions
- LLM Observability
- Software Delivery repository info (CI Visibility pipelines)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Software Delivery repository info (CI Visibility pipelines)
- Software Delivery repository info (in CI Visibility pipelines)


### Logs
Data Access Control is separate from the existing [Logs RBAC permissions][11] feature, also known as log restriction queries. To use Data Access Control with Log Management, first request access to Data Access Control. Next, manually migrate your configuration from Log Management permissions to Data Access Control.
Data Access Control is separate from the existing [Logs RBAC permissions][11] feature, also known as log restriction queries. We recommend using a single solution to restrict logs data, but user access be limited by restrictions applied from either system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Data Access Control is separate from the existing [Logs RBAC permissions][11] feature, also known as log restriction queries. We recommend using a single solution to restrict logs data, but user access be limited by restrictions applied from either system.
Data Access Control is separate from the existing [Logs RBAC permissions][11] feature, also known as log restriction queries. Datadog recommends using a single solution to restrict logs data. If you limit user access using both Data Access Control and log restriction queries, both sets of restrictions apply.

Data Access Control is separate from the existing [Logs RBAC permissions][11] feature, also known as log restriction queries. We recommend using a single solution to restrict logs data, but user access be limited by restrictions applied from either system.

### Monitors
Users can create Monitors that query and alert on active telemetry. While the user will only be able to directly query data they’re allowed to access, the Monitor will operate as a System User with full access to data. This gap will be addressed in a future iteration. We encourage customers who are concerned about this to carefully monitor which Monitors are created by their users and restrict the ability to create these Monitors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Users can create Monitors that query and alert on active telemetry. While the user will only be able to directly query data theyre allowed to access, the Monitor will operate as a System User with full access to data. This gap will be addressed in a future iteration. We encourage customers who are concerned about this to carefully monitor which Monitors are created by their users and restrict the ability to create these Monitors.
Users can create monitors that query and alert on active telemetry. While the user can only directly query data they're allowed to access, the monitor operates as a system user with full access to data.
If you are concerned about unauthorized data access through monitors, Datadog recommends that you track the monitors your users create. Then, restrict access to the creation of monitors that read sensitive data.

I had to remove the line about a future iteration because the public docs are timeless, and only describe the current state. They don't make promises about the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial review Waiting on a more in-depth review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants