(DOCS-12521) Batch 3: Logs #32920
Open
(DOCS-12521) Batch 3: Logs #32920
+136
−1,149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hestonhoffman
added
DOCS-12521
skip-jira-automation
hestonhoffman
added
editorial review
Contributor
Author
|
Editorial here: https://datadoghq.atlassian.net/browse/DOCS-12711 |
estherk15
reviewed
Nov 21, 2025
Contributor
estherk15
left a comment
estherk15
left a comment
There was a problem hiding this comment.
Thank you so much for doing this Heston 🔥
| Datadog.initialize( | ||
| with: Datadog.Configuration( | ||
| clientToken: "<client token>", | ||
| env: "<environment>", |
Contributor
There was a problem hiding this comment.
This doesn't work inside the tabs, it looks like this:
env: "<environment>",<span class="js-region-param region-param" data-region-param="ios_site_swift"></span>
You can break these out into separate sections like you did in content/en/logs/log_collection/android.md
| d=o.createElement(u);d.async=1;d.src=n | ||
| n=o.getElementsByTagName(u)[0];n.parentNode.insertBefore(d,n) | ||
| })(window,document,'script','https://www.datadoghq-browser-agent.com/datadog-logs-v6.js','DD_LOGS') | ||
| })(window,document,'script','https://www.datadoghq-browser-agent.com/{{< region-param key=browser_logs_cdn_path >}}','DD_LOGS') |
Contributor
There was a problem hiding this comment.
Same here, the tabs break the formatting
You could list the parameter at the top of the section and use a placeholder for the code
| } | ||
| ``` | ||
| {{< /site-region >}} | ||
| ```kotlin |
Contributor
There was a problem hiding this comment.
I wasn't sure if it's a big deal, but in the original formatting, everything is aligned. The refactor isn't
.useSite(DatadogSite.EU1)
.trackCrashes(true)
.build()
vs.
.useSite(DatadogSite.EU1)
.trackCrashes(true)
.build()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces repetition + site-region partials in the docs with region-params to make data center updates more efficient and maintenance easier. In some cases, this means removing tabs, as tabs and region-params don't work well together.
Outside of formatting, content shouldn't have changed.
Reviewing
The main aim here is cut down on duplication. I haven't made any content changes, so no grammar/style review is needed. When reviewing:
Merge instructions
Merge readiness: