Skip to content

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Mar 18, 2021

Description

From #2180, the mypy check to span.py found a missing return in the case that a duration was not set yet to a span. Although trivial, it is good practice to have explicit returns. A test case was added to ensure the span.duration property is None by default.

Checklist

  • Added to the correct milestone.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Library documentation is updated.
  • Corp site documentation is updated (link to the PR).

@Yun-Kim Yun-Kim added changelog/no-changelog A changelog entry is not required for this PR. automerge labels Mar 18, 2021
@Yun-Kim Yun-Kim requested a review from a team as a code owner March 18, 2021 15:49
@mergify mergify bot merged commit 41111d9 into DataDog:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants