Skip to content

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Sep 15, 2025

Adds support for APM tracing and LLM Observability for the google-adk library.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Sep 15, 2025

CODEOWNERS have been resolved as:

.riot/requirements/1227878.txt                                          @DataDog/apm-python
.riot/requirements/18d669b.txt                                          @DataDog/apm-python
.riot/requirements/1995aee.txt                                          @DataDog/apm-python
.riot/requirements/19d80a8.txt                                          @DataDog/apm-python
.riot/requirements/1cddcb1.txt                                          @DataDog/apm-python
.riot/requirements/1e5039b.txt                                          @DataDog/apm-python
.riot/requirements/3f0f7d8.txt                                          @DataDog/apm-python
.riot/requirements/c2ff780.txt                                          @DataDog/apm-python
.riot/requirements/dc2fb54.txt                                          @DataDog/apm-python
.riot/requirements/e0744c3.txt                                          @DataDog/apm-python
ddtrace/contrib/internal/google_adk/__init__.py                         @DataDog/ml-observability
ddtrace/contrib/internal/google_adk/patch.py                            @DataDog/ml-observability
ddtrace/llmobs/_integrations/google_adk.py                              @DataDog/ml-observability
releasenotes/notes/add-apm-and-llmobs-support-for-google-adk-8a6bb3842b464da4.yaml  @DataDog/apm-python
tests/contrib/google_adk/__init__.py                                    @DataDog/ml-observability
tests/contrib/google_adk/app.py                                         @DataDog/ml-observability
tests/contrib/google_adk/cassettes/agent_error_handling.yaml            @DataDog/ml-observability
tests/contrib/google_adk/cassettes/agent_math_and_code.yaml             @DataDog/ml-observability
tests/contrib/google_adk/cassettes/agent_run_async.yaml                 @DataDog/ml-observability
tests/contrib/google_adk/cassettes/agent_tool_usage.yaml                @DataDog/ml-observability
tests/contrib/google_adk/conftest.py                                    @DataDog/ml-observability
tests/contrib/google_adk/test_google_adk.py                             @DataDog/ml-observability
tests/contrib/google_adk/test_google_adk_llmobs.py                      @DataDog/ml-observability
tests/contrib/google_adk/test_google_adk_patch.py                       @DataDog/ml-observability
tests/contrib/google_adk/utils.py                                       @DataDog/ml-observability
.github/CODEOWNERS                                                      @DataDog/python-guild @DataDog/apm-core-python
ddtrace/_monkey.py                                                      @DataDog/apm-core-python
ddtrace/contrib/integration_registry/registry.yaml                      @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/trace_utils.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/llmobs/_integrations/__init__.py                                @DataDog/ml-observability
ddtrace/llmobs/_integrations/google_utils.py                            @DataDog/ml-observability
ddtrace/settings/_config.py                                             @DataDog/apm-core-python
docs/index.rst                                                          @DataDog/python-guild
docs/integrations.rst                                                   @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
supported_versions_output.json                                          @DataDog/apm-core-python
supported_versions_table.csv                                            @DataDog/apm-core-python
tests/llmobs/suitespec.yml                                              @DataDog/ml-observability

@wconti27 wconti27 self-assigned this Sep 15, 2025
@wconti27 wconti27 changed the title Conti/google adk integration feat(tracing): add support for google agentic development kit (adk) Sep 15, 2025
Copy link
Contributor

github-actions bot commented Sep 15, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 268 ± 3 ms.

The average import time from base is: 269 ± 3 ms.

The import time difference between this PR and base is: -1.3 ± 0.1 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.110 ms (0.04%)
ddtrace 0.110 ms (0.04%)
ddtrace.trace 0.110 ms (0.04%)
ddtrace._trace.filters 0.110 ms (0.04%)

The following import paths have shrunk:

ddtrace.auto 2.093 ms (0.78%)
ddtrace.bootstrap.sitecustomize 1.304 ms (0.49%)
ddtrace.bootstrap.preload 1.304 ms (0.49%)
ddtrace.internal.remoteconfig.client 0.635 ms (0.24%)
ddtrace 0.789 ms (0.29%)
ddtrace.trace 0.119 ms (0.04%)
ddtrace._trace.filters 0.119 ms (0.04%)
ddtrace._trace.processor 0.119 ms (0.04%)
ddtrace.internal._unpatched 0.029 ms (0.01%)
json 0.029 ms (0.01%)
json.decoder 0.029 ms (0.01%)
re 0.029 ms (0.01%)
enum 0.029 ms (0.01%)
types 0.029 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Sep 15, 2025

Performance SLOs

Comparing candidate conti/google-adk-integration (58e1609) with baseline main (b57f153)

❌ Test Failures (1 suite)
iastpropagation - 7/8

✅ no-propagation

Time: ✅ 48.984µs (SLO: <60.000µs 📉 -18.4%) vs baseline: -0.3%

Memory: ✅ 37.021MB (SLO: <39.000MB -5.1%) vs baseline: +5.1%


✅ propagation_enabled

Time: ✅ 173.702µs (SLO: <190.000µs -8.6%) vs baseline: +4.2%

Memory: ✅ 37.100MB (SLO: <39.000MB -4.9%) vs baseline: +5.5%


❌ propagation_enabled_100

Time: ❌ 1.927ms (SLO: <1.900ms +1.4%) vs baseline: +4.9%

Memory: ✅ 37.061MB (SLO: <39.000MB -5.0%) vs baseline: +5.4%


✅ propagation_enabled_1000

Time: ✅ 32.881ms (SLO: <35.550ms -7.5%) vs baseline: +3.3%

Memory: ✅ 37.041MB (SLO: <39.000MB -5.0%) vs baseline: +5.2%

📈 Performance Regressions (2 suites)
📈 iastaspects - 118/118

✅ add_aspect

Time: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.6%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ add_inplace_aspect

Time: ✅ 0.423µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +4.1%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ add_inplace_noaspect

Time: ✅ 0.315µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -0.1%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ add_noaspect

Time: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.0%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.7%


✅ bytearray_aspect

Time: ✅ 1.310µs (SLO: <10.000µs 📉 -86.9%) vs baseline: -0.4%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ bytearray_extend_aspect

Time: ✅ 1.597µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +8.9%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ bytearray_extend_noaspect

Time: ✅ 0.609µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.2%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ bytearray_noaspect

Time: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: ~same

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.6%


✅ bytes_aspect

Time: ✅ 1.429µs (SLO: <10.000µs 📉 -85.7%) vs baseline: 📈 +11.0%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.6%


✅ bytes_noaspect

Time: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.3%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ bytesio_aspect

Time: ✅ 1.347µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -1.1%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ bytesio_noaspect

Time: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.3%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ capitalize_aspect

Time: ✅ 0.733µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.6%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ capitalize_noaspect

Time: ✅ 0.429µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.8%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ casefold_aspect

Time: ✅ 0.731µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.6%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.4%


✅ casefold_noaspect

Time: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.9%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ decode_aspect

Time: ✅ 0.726µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.3%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.1%


✅ decode_noaspect

Time: ✅ 0.415µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -1.8%

Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +5.5%


✅ encode_aspect

Time: ✅ 0.708µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.7%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.6%


✅ encode_noaspect

Time: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.5%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.4%


✅ format_aspect

Time: ✅ 3.388µs (SLO: <10.000µs 📉 -66.1%) vs baseline: +0.4%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ format_map_aspect

Time: ✅ 3.710µs (SLO: <10.000µs 📉 -62.9%) vs baseline: +5.8%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ format_map_noaspect

Time: ✅ 0.779µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.7%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ format_noaspect

Time: ✅ 0.594µs (SLO: <10.000µs 📉 -94.1%) vs baseline: +0.4%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ index_aspect

Time: ✅ 0.356µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.3%

Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +5.7%


✅ index_noaspect

Time: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.4%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.6%


✅ join_aspect

Time: ✅ 1.372µs (SLO: <10.000µs 📉 -86.3%) vs baseline: +5.0%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ join_noaspect

Time: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.2%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.6%


✅ ljust_aspect

Time: ✅ 2.675µs (SLO: <20.000µs 📉 -86.6%) vs baseline: +4.6%

Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +5.5%


✅ ljust_noaspect

Time: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.3%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ lower_aspect

Time: ✅ 2.336µs (SLO: <10.000µs 📉 -76.6%) vs baseline: +2.2%

Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +5.6%


✅ lower_noaspect

Time: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.6%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ lstrip_aspect

Time: ✅ 2.226µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.3%

Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +5.6%


✅ lstrip_noaspect

Time: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.8%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ modulo_aspect

Time: ✅ 0.997µs (SLO: <10.000µs 📉 -90.0%) vs baseline: -0.6%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 1.608µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +6.3%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ modulo_aspect_for_bytes

Time: ✅ 0.970µs (SLO: <10.000µs 📉 -90.3%) vs baseline: ~same

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 1.217µs (SLO: <10.000µs 📉 -87.8%) vs baseline: +2.4%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ modulo_noaspect

Time: ✅ 0.631µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +1.5%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


✅ replace_aspect

Time: ✅ 4.912µs (SLO: <10.000µs 📉 -50.9%) vs baseline: +0.5%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ replace_noaspect

Time: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.5%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.6%


✅ repr_aspect

Time: ✅ 0.908µs (SLO: <10.000µs 📉 -90.9%) vs baseline: -0.2%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ repr_noaspect

Time: ✅ 0.415µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.8%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ rstrip_aspect

Time: ✅ 1.976µs (SLO: <20.000µs 📉 -90.1%) vs baseline: +2.5%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.3%


✅ rstrip_noaspect

Time: ✅ 0.378µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.3%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ slice_aspect

Time: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.3%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ slice_noaspect

Time: ✅ 0.448µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +1.3%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


✅ stringio_aspect

Time: ✅ 1.640µs (SLO: <10.000µs 📉 -83.6%) vs baseline: +6.6%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.3%


✅ stringio_noaspect

Time: ✅ 0.722µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.8%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ strip_aspect

Time: ✅ 2.258µs (SLO: <20.000µs 📉 -88.7%) vs baseline: ~same

Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +5.6%


✅ strip_noaspect

Time: ✅ 0.387µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +1.3%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ swapcase_aspect

Time: ✅ 2.560µs (SLO: <10.000µs 📉 -74.4%) vs baseline: +2.0%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ swapcase_noaspect

Time: ✅ 0.537µs (SLO: <10.000µs 📉 -94.6%) vs baseline: ~same

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.0%


✅ title_aspect

Time: ✅ 2.347µs (SLO: <10.000µs 📉 -76.5%) vs baseline: -2.7%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ title_noaspect

Time: ✅ 0.501µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -1.0%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ translate_aspect

Time: ✅ 3.253µs (SLO: <10.000µs 📉 -67.5%) vs baseline: -3.1%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.4%


✅ translate_noaspect

Time: ✅ 1.041µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.3%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.7%


✅ upper_aspect

Time: ✅ 2.219µs (SLO: <10.000µs 📉 -77.8%) vs baseline: -2.5%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.6%


✅ upper_noaspect

Time: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.3%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


📈 iastaspectsospath - 24/24

✅ ospathbasename_aspect

Time: ✅ 4.151µs (SLO: <10.000µs 📉 -58.5%) vs baseline: -4.3%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ ospathbasename_noaspect

Time: ✅ 1.075µs (SLO: <10.000µs 📉 -89.3%) vs baseline: -0.4%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


✅ ospathjoin_aspect

Time: ✅ 6.957µs (SLO: <10.000µs 📉 -30.4%) vs baseline: +8.9%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.6%


✅ ospathjoin_noaspect

Time: ✅ 2.281µs (SLO: <10.000µs 📉 -77.2%) vs baseline: -0.3%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.7%


✅ ospathnormcase_aspect

Time: ✅ 4.062µs (SLO: <10.000µs 📉 -59.4%) vs baseline: 📈 +10.3%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ ospathnormcase_noaspect

Time: ✅ 0.566µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.0%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.3%


✅ ospathsplit_aspect

Time: ✅ 5.691µs (SLO: <10.000µs 📉 -43.1%) vs baseline: 📈 +14.6%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


✅ ospathsplit_noaspect

Time: ✅ 1.582µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -1.0%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.6%


✅ ospathsplitdrive_aspect

Time: ✅ 4.241µs (SLO: <10.000µs 📉 -57.6%) vs baseline: +9.8%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ ospathsplitdrive_noaspect

Time: ✅ 0.694µs (SLO: <10.000µs 📉 -93.1%) vs baseline: ~same

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ ospathsplitext_aspect

Time: ✅ 5.073µs (SLO: <10.000µs 📉 -49.3%) vs baseline: +8.8%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.6%


✅ ospathsplitext_noaspect

Time: ✅ 1.378µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.9%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.3%

🟡 Near SLO Breach (5 suites)
🟡 djangosimple - 26/26

✅ appsec

Time: ✅ 20.562ms (SLO: <22.300ms -7.8%) vs baseline: +0.1%

Memory: ✅ 64.448MB (SLO: <66.000MB -2.4%) vs baseline: +4.9%


✅ exception-replay-enabled

Time: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: -0.6%

Memory: ✅ 63.570MB (SLO: <66.000MB -3.7%) vs baseline: +4.9%


✅ iast

Time: ✅ 20.577ms (SLO: <22.250ms -7.5%) vs baseline: +0.4%

Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%) vs baseline: +4.9%


✅ profiler

Time: ✅ 15.260ms (SLO: <16.550ms -7.8%) vs baseline: -0.2%

Memory: ✅ 52.986MB (SLO: <53.500MB 🟡 -1.0%) vs baseline: +4.9%


✅ span-code-origin

Time: ✅ 26.142ms (SLO: <28.200ms -7.3%) vs baseline: ~same

Memory: ✅ 66.662MB (SLO: <68.500MB -2.7%) vs baseline: +4.9%


✅ tracer

Time: ✅ 20.576ms (SLO: <21.750ms -5.4%) vs baseline: ~same

Memory: ✅ 64.507MB (SLO: <66.000MB -2.3%) vs baseline: +4.9%


✅ tracer-and-profiler

Time: ✅ 22.072ms (SLO: <23.500ms -6.1%) vs baseline: -0.4%

Memory: ✅ 65.846MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +5.1%


✅ tracer-dont-create-db-spans

Time: ✅ 19.375ms (SLO: <21.500ms -9.9%) vs baseline: ~same

Memory: ✅ 64.527MB (SLO: <66.000MB -2.2%) vs baseline: +5.0%


✅ tracer-native

Time: ✅ 20.537ms (SLO: <21.750ms -5.6%) vs baseline: +0.3%

Memory: ✅ 65.838MB (SLO: <66.000MB 🟡 -0.2%) vs baseline: +5.2%


✅ tracer-no-caches

Time: ✅ 18.426ms (SLO: <19.650ms -6.2%) vs baseline: -0.3%

Memory: ✅ 64.484MB (SLO: <66.000MB -2.3%) vs baseline: +5.0%


✅ tracer-no-databases

Time: ✅ 18.704ms (SLO: <20.100ms -6.9%) vs baseline: -0.6%

Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%) vs baseline: +5.0%


✅ tracer-no-middleware

Time: ✅ 20.223ms (SLO: <21.500ms -5.9%) vs baseline: +0.2%

Memory: ✅ 64.448MB (SLO: <66.000MB -2.4%) vs baseline: +4.9%


✅ tracer-no-templates

Time: ✅ 20.297ms (SLO: <22.000ms -7.7%) vs baseline: -0.2%

Memory: ✅ 64.527MB (SLO: <66.000MB -2.2%) vs baseline: +5.1%


🟡 errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 18.075ms (SLO: <19.850ms -8.9%) vs baseline: ~same

Memory: ✅ 64.487MB (SLO: <65.500MB 🟡 -1.5%) vs baseline: +4.9%


✅ errortracking-enabled-user

Time: ✅ 18.066ms (SLO: <19.400ms -6.9%) vs baseline: +0.3%

Memory: ✅ 64.507MB (SLO: <65.500MB 🟡 -1.5%) vs baseline: +5.0%


✅ tracer-enabled

Time: ✅ 18.199ms (SLO: <19.450ms -6.4%) vs baseline: +0.7%

Memory: ✅ 64.462MB (SLO: <65.500MB 🟡 -1.6%) vs baseline: +4.9%


🟡 flasksimple - 17/17

✅ appsec-get

Time: ✅ 4.589ms (SLO: <4.750ms -3.4%) vs baseline: -0.2%

Memory: ✅ 62.403MB (SLO: <64.500MB -3.3%) vs baseline: +5.0%


✅ appsec-post

Time: ✅ 6.599ms (SLO: <6.750ms -2.2%) vs baseline: +0.4%

Memory: ✅ 62.403MB (SLO: <64.500MB -3.3%) vs baseline: +5.2%


✅ appsec-telemetry

Time: ✅ 4.582ms (SLO: <4.750ms -3.5%) vs baseline: +0.3%

Memory: ✅ 62.344MB (SLO: <64.500MB -3.3%) vs baseline: +4.8%


✅ debugger

Time: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: +0.2%

Memory: ✅ 44.768MB (SLO: <45.000MB 🟡 -0.5%) vs baseline: +5.2%


✅ iast-get

Time: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: -0.1%

Memory: ✅ 41.760MB (SLO: <49.000MB 📉 -14.8%) vs baseline: +5.2%


✅ profiler

Time: ✅ 1.912ms (SLO: <2.100ms -8.9%) vs baseline: ~same

Memory: ✅ 44.551MB (SLO: <46.500MB -4.2%) vs baseline: +5.2%


✅ tracer

Time: ✅ 3.379ms (SLO: <3.650ms -7.4%) vs baseline: ~same

Memory: ✅ 51.393MB (SLO: <53.500MB -3.9%) vs baseline: +4.7%


✅ tracer-native

Time: ✅ 3.369ms (SLO: <3.650ms -7.7%) vs baseline: -0.4%

Memory: ✅ 52.632MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.9%


🟡 flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 3.942ms (SLO: <4.200ms -6.1%) vs baseline: -0.4%

Memory: ✅ 62.494MB (SLO: <66.000MB -5.3%) vs baseline: +4.5%


✅ iast-enabled

Time: ✅ 2.462ms (SLO: <2.800ms 📉 -12.1%) vs baseline: +0.7%

Memory: ✅ 58.031MB (SLO: <59.000MB 🟡 -1.6%) vs baseline: +4.7%


✅ tracer-enabled

Time: ✅ 2.073ms (SLO: <2.250ms -7.9%) vs baseline: ~same

Memory: ✅ 51.230MB (SLO: <53.500MB -4.2%) vs baseline: +5.0%


🟡 otelspan - 22/22

✅ add-event

Time: ✅ 45.832ms (SLO: <47.150ms -2.8%) vs baseline: +1.5%

Memory: ✅ 44.618MB (SLO: <46.500MB -4.0%) vs baseline: +5.3%


✅ add-metrics

Time: ✅ 321.893ms (SLO: <344.800ms -6.6%) vs baseline: +0.3%

Memory: ✅ 553.771MB (SLO: <562.000MB 🟡 -1.5%) vs baseline: +4.9%


✅ add-tags

Time: ✅ 292.869ms (SLO: <314.000ms -6.7%) vs baseline: +0.5%

Memory: ✅ 555.303MB (SLO: <563.500MB 🟡 -1.5%) vs baseline: +4.8%


✅ get-context

Time: ✅ 82.460ms (SLO: <92.350ms 📉 -10.7%) vs baseline: -0.3%

Memory: ✅ 39.775MB (SLO: <46.500MB 📉 -14.5%) vs baseline: +5.0%


✅ is-recording

Time: ✅ 43.010ms (SLO: <44.500ms -3.3%) vs baseline: +0.4%

Memory: ✅ 44.001MB (SLO: <46.500MB -5.4%) vs baseline: +4.9%


✅ record-exception

Time: ✅ 63.054ms (SLO: <67.650ms -6.8%) vs baseline: +2.2%

Memory: ✅ 40.105MB (SLO: <46.500MB 📉 -13.8%) vs baseline: +5.3%


✅ set-status

Time: ✅ 49.007ms (SLO: <50.400ms -2.8%) vs baseline: +0.8%

Memory: ✅ 44.212MB (SLO: <46.500MB -4.9%) vs baseline: +5.6%


✅ start

Time: ✅ 42.267ms (SLO: <43.450ms -2.7%) vs baseline: +0.2%

Memory: ✅ 44.085MB (SLO: <46.500MB -5.2%) vs baseline: +5.3%


✅ start-finish

Time: ✅ 83.286ms (SLO: <88.000ms -5.4%) vs baseline: +0.3%

Memory: ✅ 33.994MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +5.5%


✅ start-finish-telemetry

Time: ✅ 84.930ms (SLO: <89.000ms -4.6%) vs baseline: +0.4%

Memory: ✅ 33.994MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +5.5%


✅ update-name

Time: ✅ 44.348ms (SLO: <45.150ms 🟡 -1.8%) vs baseline: +0.6%

Memory: ✅ 44.371MB (SLO: <46.500MB -4.6%) vs baseline: +5.3%

⚠️ Unstable Tests (1 suite)
⚠️ coreapiscenario - 12/12 (2 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.413µs (SLO: <20.000µs 📉 -32.9%) vs baseline: +0.2%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +5.2%


✅ context_with_data_no_listeners

Time: ✅ 3.428µs (SLO: <10.000µs 📉 -65.7%) vs baseline: +0.8%

Memory: ✅ 31.418MB (SLO: <33.500MB -6.2%) vs baseline: +5.1%


⚠️ context_with_data_only_all_listeners

Time: ⚠️ 13.345µs (SLO: <20.000µs 📉 -33.3%) vs baseline: -0.6%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +5.6%


✅ get_item_exists

Time: ✅ 0.598µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +2.3%

Memory: ✅ 31.418MB (SLO: <33.500MB -6.2%) vs baseline: +5.2%


✅ get_item_missing

Time: ✅ 0.641µs (SLO: <10.000µs 📉 -93.6%) vs baseline: +0.2%

Memory: ✅ 31.457MB (SLO: <33.500MB -6.1%) vs baseline: +5.3%


✅ set_item

Time: ✅ 24.401µs (SLO: <30.000µs 📉 -18.7%) vs baseline: -0.5%

Memory: ✅ 31.438MB (SLO: <33.500MB -6.2%) vs baseline: +5.5%

✅ All Tests Passing (15 suites)
errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.097ms (SLO: <2.300ms -8.8%) vs baseline: +0.4%

Memory: ✅ 51.306MB (SLO: <53.500MB -4.1%) vs baseline: +5.1%


✅ errortracking-enabled-user

Time: ✅ 2.089ms (SLO: <2.250ms -7.2%) vs baseline: -0.4%

Memory: ✅ 51.243MB (SLO: <53.500MB -4.2%) vs baseline: +5.1%


✅ tracer-enabled

Time: ✅ 2.103ms (SLO: <2.300ms -8.6%) vs baseline: +0.5%

Memory: ✅ 51.213MB (SLO: <53.500MB -4.3%) vs baseline: +5.0%


httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 82.598µs (SLO: <100.000µs 📉 -17.4%) vs baseline: +1.9%

Memory: ✅ 31.595MB (SLO: <33.500MB -5.7%) vs baseline: +5.3%


✅ b3_headers

Time: ✅ 14.278µs (SLO: <20.000µs 📉 -28.6%) vs baseline: ~same

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%


✅ b3_single_headers

Time: ✅ 13.490µs (SLO: <20.000µs 📉 -32.5%) vs baseline: +1.6%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.3%


✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 64.382µs (SLO: <80.000µs 📉 -19.5%) vs baseline: +1.7%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.5%


✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 66.839µs (SLO: <80.000µs 📉 -16.5%) vs baseline: +2.0%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.3%


✅ empty_headers

Time: ✅ 1.595µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.6%

Memory: ✅ 31.654MB (SLO: <33.500MB -5.5%) vs baseline: +5.6%


✅ full_t_id_datadog_headers

Time: ✅ 22.957µs (SLO: <30.000µs 📉 -23.5%) vs baseline: +0.5%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +5.3%


✅ invalid_priority_header

Time: ✅ 6.609µs (SLO: <10.000µs 📉 -33.9%) vs baseline: +1.3%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.1%


✅ invalid_span_id_header

Time: ✅ 6.546µs (SLO: <10.000µs 📉 -34.5%) vs baseline: -0.5%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.2%


✅ invalid_tags_header

Time: ✅ 6.535µs (SLO: <10.000µs 📉 -34.7%) vs baseline: +0.6%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.4%


✅ invalid_trace_id_header

Time: ✅ 6.490µs (SLO: <10.000µs 📉 -35.1%) vs baseline: -1.0%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.2%


✅ large_header_no_matches

Time: ✅ 27.633µs (SLO: <30.000µs -7.9%) vs baseline: -0.4%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.3%


✅ large_valid_headers_all

Time: ✅ 28.687µs (SLO: <40.000µs 📉 -28.3%) vs baseline: +0.1%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +5.2%


✅ medium_header_no_matches

Time: ✅ 9.884µs (SLO: <20.000µs 📉 -50.6%) vs baseline: +0.3%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.4%


✅ medium_valid_headers_all

Time: ✅ 11.364µs (SLO: <20.000µs 📉 -43.2%) vs baseline: +0.3%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +5.2%


✅ none_propagation_style

Time: ✅ 1.704µs (SLO: <10.000µs 📉 -83.0%) vs baseline: -0.8%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.3%


✅ tracecontext_headers

Time: ✅ 35.292µs (SLO: <40.000µs 📉 -11.8%) vs baseline: +2.8%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.4%


✅ valid_headers_all

Time: ✅ 6.550µs (SLO: <10.000µs 📉 -34.5%) vs baseline: ~same

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.1%


✅ valid_headers_basic

Time: ✅ 6.088µs (SLO: <10.000µs 📉 -39.1%) vs baseline: -1.5%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +5.0%


✅ wsgi_empty_headers

Time: ✅ 1.600µs (SLO: <10.000µs 📉 -84.0%) vs baseline: ~same

Memory: ✅ 31.615MB (SLO: <33.500MB -5.6%) vs baseline: +5.4%


✅ wsgi_invalid_priority_header

Time: ✅ 6.573µs (SLO: <10.000µs 📉 -34.3%) vs baseline: +0.2%

Memory: ✅ 31.595MB (SLO: <33.500MB -5.7%) vs baseline: +5.3%


✅ wsgi_invalid_span_id_header

Time: ✅ 1.599µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.6%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.2%


✅ wsgi_invalid_tags_header

Time: ✅ 6.540µs (SLO: <10.000µs 📉 -34.6%) vs baseline: -0.6%

Memory: ✅ 31.595MB (SLO: <33.500MB -5.7%) vs baseline: +5.6%


✅ wsgi_invalid_trace_id_header

Time: ✅ 6.530µs (SLO: <10.000µs 📉 -34.7%) vs baseline: -0.9%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +5.3%


✅ wsgi_large_header_no_matches

Time: ✅ 28.903µs (SLO: <40.000µs 📉 -27.7%) vs baseline: +0.2%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.2%


✅ wsgi_large_valid_headers_all

Time: ✅ 29.944µs (SLO: <40.000µs 📉 -25.1%) vs baseline: +0.6%

Memory: ✅ 31.595MB (SLO: <33.500MB -5.7%) vs baseline: +5.4%


✅ wsgi_medium_header_no_matches

Time: ✅ 10.192µs (SLO: <20.000µs 📉 -49.0%) vs baseline: +1.3%

Memory: ✅ 31.477MB (SLO: <33.500MB -6.0%) vs baseline: +4.9%


✅ wsgi_medium_valid_headers_all

Time: ✅ 11.665µs (SLO: <20.000µs 📉 -41.7%) vs baseline: +1.2%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.4%


✅ wsgi_valid_headers_all

Time: ✅ 6.574µs (SLO: <10.000µs 📉 -34.3%) vs baseline: ~same

Memory: ✅ 31.674MB (SLO: <33.500MB -5.5%) vs baseline: +5.6%


✅ wsgi_valid_headers_basic

Time: ✅ 6.117µs (SLO: <10.000µs 📉 -38.8%) vs baseline: -0.4%

Memory: ✅ 31.615MB (SLO: <33.500MB -5.6%) vs baseline: +5.4%


httppropagationinject - 16/16

✅ ids_only

Time: ✅ 22.030µs (SLO: <30.000µs 📉 -26.6%) vs baseline: +1.1%

Memory: ✅ 31.615MB (SLO: <33.500MB -5.6%) vs baseline: +5.4%


✅ with_all

Time: ✅ 29.415µs (SLO: <40.000µs 📉 -26.5%) vs baseline: +1.0%

Memory: ✅ 31.615MB (SLO: <33.500MB -5.6%) vs baseline: +5.2%


✅ with_dd_origin

Time: ✅ 25.729µs (SLO: <30.000µs 📉 -14.2%) vs baseline: +0.4%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.4%


✅ with_priority_and_origin

Time: ✅ 25.455µs (SLO: <40.000µs 📉 -36.4%) vs baseline: +1.5%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.3%


✅ with_sampling_priority

Time: ✅ 21.962µs (SLO: <30.000µs 📉 -26.8%) vs baseline: +0.5%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.6%


✅ with_tags

Time: ✅ 27.382µs (SLO: <40.000µs 📉 -31.5%) vs baseline: +0.3%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.3%


✅ with_tags_invalid

Time: ✅ 28.968µs (SLO: <40.000µs 📉 -27.6%) vs baseline: +0.5%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.4%


✅ with_tags_max_size

Time: ✅ 27.869µs (SLO: <40.000µs 📉 -30.3%) vs baseline: -0.1%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.3%


iast_aspects - 40/40

✅ re_expand_aspect

Time: ✅ 31.933µs (SLO: <40.000µs 📉 -20.2%) vs baseline: -0.1%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ re_expand_noaspect

Time: ✅ 28.347µs (SLO: <40.000µs 📉 -29.1%) vs baseline: -0.5%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ re_findall_aspect

Time: ✅ 2.918µs (SLO: <10.000µs 📉 -70.8%) vs baseline: +0.7%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ re_findall_noaspect

Time: ✅ 1.419µs (SLO: <10.000µs 📉 -85.8%) vs baseline: ~same

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ re_finditer_aspect

Time: ✅ 4.395µs (SLO: <10.000µs 📉 -56.0%) vs baseline: -2.1%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.6%


✅ re_finditer_noaspect

Time: ✅ 1.416µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +1.2%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ re_fullmatch_aspect

Time: ✅ 2.729µs (SLO: <10.000µs 📉 -72.7%) vs baseline: +1.5%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ re_fullmatch_noaspect

Time: ✅ 1.290µs (SLO: <10.000µs 📉 -87.1%) vs baseline: -0.1%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ re_group_aspect

Time: ✅ 2.911µs (SLO: <10.000µs 📉 -70.9%) vs baseline: -0.9%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.2%


✅ re_group_noaspect

Time: ✅ 1.615µs (SLO: <10.000µs 📉 -83.8%) vs baseline: -0.2%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.7%


✅ re_groups_aspect

Time: ✅ 3.032µs (SLO: <10.000µs 📉 -69.7%) vs baseline: -1.1%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.5%


✅ re_groups_noaspect

Time: ✅ 1.700µs (SLO: <10.000µs 📉 -83.0%) vs baseline: +0.3%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ re_match_aspect

Time: ✅ 2.689µs (SLO: <10.000µs 📉 -73.1%) vs baseline: -0.2%

Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +5.7%


✅ re_match_noaspect

Time: ✅ 1.298µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.4%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.6%


✅ re_search_aspect

Time: ✅ 2.535µs (SLO: <10.000µs 📉 -74.6%) vs baseline: -0.9%

Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +5.6%


✅ re_search_noaspect

Time: ✅ 1.200µs (SLO: <10.000µs 📉 -88.0%) vs baseline: +0.3%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.6%


✅ re_sub_aspect

Time: ✅ 3.379µs (SLO: <10.000µs 📉 -66.2%) vs baseline: -2.1%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ re_sub_noaspect

Time: ✅ 1.537µs (SLO: <10.000µs 📉 -84.6%) vs baseline: ~same

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ re_subn_aspect

Time: ✅ 3.659µs (SLO: <10.000µs 📉 -63.4%) vs baseline: -0.5%

Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +5.7%


✅ re_subn_noaspect

Time: ✅ 1.607µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.9%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


iastaspectssplit - 12/12

✅ rsplit_aspect

Time: ✅ 1.494µs (SLO: <10.000µs 📉 -85.1%) vs baseline: +5.2%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.5%


✅ rsplit_noaspect

Time: ✅ 0.577µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +0.3%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ split_aspect

Time: ✅ 1.448µs (SLO: <10.000µs 📉 -85.5%) vs baseline: +3.6%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.6%


✅ split_noaspect

Time: ✅ 0.568µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.6%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ splitlines_aspect

Time: ✅ 1.398µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +1.3%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ splitlines_noaspect

Time: ✅ 0.584µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +0.7%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.683ms (SLO: <42.000ms -3.1%) vs baseline: ~same

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +5.3%


✅ add-link

Time: ✅ 37.072ms (SLO: <38.550ms -3.8%) vs baseline: +1.6%

Memory: ✅ 34.269MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +5.1%


✅ add-metrics

Time: ✅ 218.951ms (SLO: <232.000ms -5.6%) vs baseline: ~same

Memory: ✅ 34.229MB (SLO: <39.000MB 📉 -12.2%) vs baseline: +4.9%


✅ add-tags

Time: ✅ 213.212ms (SLO: <221.600ms -3.8%) vs baseline: -0.2%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +5.2%


✅ get-context

Time: ✅ 29.682ms (SLO: <31.300ms -5.2%) vs baseline: +0.9%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +5.3%


✅ is-recording

Time: ✅ 29.175ms (SLO: <31.000ms -5.9%) vs baseline: -0.3%

Memory: ✅ 34.229MB (SLO: <39.000MB 📉 -12.2%) vs baseline: +5.0%


✅ record-exception

Time: ✅ 63.185ms (SLO: <65.850ms -4.0%) vs baseline: -0.4%

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +5.2%


✅ set-status

Time: ✅ 32.429ms (SLO: <34.150ms -5.0%) vs baseline: +1.8%

Memory: ✅ 34.249MB (SLO: <39.000MB 📉 -12.2%) vs baseline: +5.0%


✅ start

Time: ✅ 28.682ms (SLO: <30.150ms -4.9%) vs baseline: -0.9%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +5.2%


✅ start-finish

Time: ✅ 33.848ms (SLO: <35.350ms -4.3%) vs baseline: -0.7%

Memory: ✅ 34.249MB (SLO: <39.000MB 📉 -12.2%) vs baseline: +5.1%


✅ start-finish-telemetry

Time: ✅ 34.054ms (SLO: <35.450ms -3.9%) vs baseline: -0.4%

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +5.3%


✅ update-name

Time: ✅ 31.800ms (SLO: <33.400ms -4.8%) vs baseline: +1.6%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +5.2%


packagespackageforrootmodulemapping - 4/4

✅ cache_off

Time: ✅ 341.703ms (SLO: <354.300ms -3.6%) vs baseline: +0.1%

Memory: ✅ 37.263MB (SLO: <40.000MB -6.8%) vs baseline: +5.2%


✅ cache_on

Time: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same

Memory: ✅ 36.457MB (SLO: <39.000MB -6.5%) vs baseline: +6.5%


packagesupdateimporteddependencies - 24/24

✅ import_many

Time: ✅ 156.244µs (SLO: <170.000µs -8.1%) vs baseline: +1.2%

Memory: ✅ 36.165MB (SLO: <38.500MB -6.1%) vs baseline: +4.3%


✅ import_many_cached

Time: ✅ 121.509µs (SLO: <130.000µs -6.5%) vs baseline: +0.6%

Memory: ✅ 36.225MB (SLO: <38.500MB -5.9%) vs baseline: +5.3%


✅ import_many_stdlib

Time: ✅ 1.603ms (SLO: <1.750ms -8.4%) vs baseline: -0.5%

Memory: ✅ 36.567MB (SLO: <38.500MB -5.0%) vs baseline: +6.1%


✅ import_many_stdlib_cached

Time: ✅ 0.965ms (SLO: <1.100ms 📉 -12.2%) vs baseline: ~same

Memory: ✅ 36.597MB (SLO: <38.500MB -4.9%) vs baseline: +6.0%


✅ import_many_unknown

Time: ✅ 843.485µs (SLO: <890.000µs -5.2%) vs baseline: +1.7%

Memory: ✅ 36.621MB (SLO: <38.500MB -4.9%) vs baseline: +6.1%


✅ import_many_unknown_cached

Time: ✅ 790.607µs (SLO: <870.000µs -9.1%) vs baseline: -0.6%

Memory: ✅ 36.607MB (SLO: <38.500MB -4.9%) vs baseline: +6.1%


✅ import_one

Time: ✅ 19.736µs (SLO: <30.000µs 📉 -34.2%) vs baseline: -0.8%

Memory: ✅ 36.408MB (SLO: <39.000MB -6.6%) vs baseline: +5.9%


✅ import_one_cache

Time: ✅ 6.277µs (SLO: <10.000µs 📉 -37.2%) vs baseline: -0.3%

Memory: ✅ 36.397MB (SLO: <38.500MB -5.5%) vs baseline: +6.0%


✅ import_one_stdlib

Time: ✅ 18.845µs (SLO: <20.000µs -5.8%) vs baseline: +1.0%

Memory: ✅ 36.518MB (SLO: <38.500MB -5.1%) vs baseline: +6.4%


✅ import_one_stdlib_cache

Time: ✅ 6.244µs (SLO: <10.000µs 📉 -37.6%) vs baseline: -1.9%

Memory: ✅ 36.447MB (SLO: <38.500MB -5.3%) vs baseline: +5.9%


✅ import_one_unknown

Time: ✅ 45.206µs (SLO: <50.000µs -9.6%) vs baseline: -0.7%

Memory: ✅ 36.422MB (SLO: <38.500MB -5.4%) vs baseline: +6.0%


✅ import_one_unknown_cache

Time: ✅ 6.293µs (SLO: <10.000µs 📉 -37.1%) vs baseline: +0.1%

Memory: ✅ 36.454MB (SLO: <38.500MB -5.3%) vs baseline: +5.8%


ratelimiter - 12/12

✅ defaults

Time: ✅ 2.347µs (SLO: <10.000µs 📉 -76.5%) vs baseline: ~same

Memory: ✅ 31.143MB (SLO: <34.000MB -8.4%) vs baseline: +5.5%


✅ high_rate_limit

Time: ✅ 2.402µs (SLO: <10.000µs 📉 -76.0%) vs baseline: -0.8%

Memory: ✅ 31.103MB (SLO: <34.000MB -8.5%) vs baseline: +5.5%


✅ long_window

Time: ✅ 2.344µs (SLO: <10.000µs 📉 -76.6%) vs baseline: -0.6%

Memory: ✅ 31.084MB (SLO: <34.000MB -8.6%) vs baseline: +5.3%


✅ low_rate_limit

Time: ✅ 2.349µs (SLO: <10.000µs 📉 -76.5%) vs baseline: -1.2%

Memory: ✅ 31.103MB (SLO: <34.000MB -8.5%) vs baseline: +5.3%


✅ no_rate_limit

Time: ✅ 0.834µs (SLO: <10.000µs 📉 -91.7%) vs baseline: -0.4%

Memory: ✅ 31.064MB (SLO: <34.000MB -8.6%) vs baseline: +5.1%


✅ short_window

Time: ✅ 2.478µs (SLO: <10.000µs 📉 -75.2%) vs baseline: +0.5%

Memory: ✅ 31.123MB (SLO: <34.000MB -8.5%) vs baseline: +5.5%


recursivecomputation - 8/8

✅ deep

Time: ✅ 309.298ms (SLO: <320.950ms -3.6%) vs baseline: ~same

Memory: ✅ 32.657MB (SLO: <34.500MB -5.3%) vs baseline: +5.3%


✅ deep-profiled

Time: ✅ 326.992ms (SLO: <359.150ms -9.0%) vs baseline: -0.1%

Memory: ✅ 35.311MB (SLO: <39.000MB -9.5%) vs baseline: +4.9%


✅ medium

Time: ✅ 7.086ms (SLO: <7.400ms -4.2%) vs baseline: +0.4%

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +5.3%


✅ shallow

Time: ✅ 0.958ms (SLO: <1.050ms -8.8%) vs baseline: +0.3%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.5%


samplingrules - 8/8

✅ average_match

Time: ✅ 148.756µs (SLO: <290.000µs 📉 -48.7%) vs baseline: ~same

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +5.2%


✅ high_match

Time: ✅ 193.726µs (SLO: <480.000µs 📉 -59.6%) vs baseline: +0.3%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.1%


✅ low_match

Time: ✅ 99.132µs (SLO: <120.000µs 📉 -17.4%) vs baseline: +0.4%

Memory: ✅ 631.983MB (SLO: <700.000MB -9.7%) vs baseline: +4.9%


✅ very_low_match

Time: ✅ 2.899ms (SLO: <8.500ms 📉 -65.9%) vs baseline: +0.5%

Memory: ✅ 69.746MB (SLO: <75.000MB -7.0%) vs baseline: +5.0%


sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.862µs (SLO: <20.000µs 📉 -45.7%) vs baseline: +2.1%

Memory: ✅ 32.381MB (SLO: <34.000MB -4.8%) vs baseline: +5.5%


✅ all-enabled

Time: ✅ 40.126µs (SLO: <50.000µs 📉 -19.7%) vs baseline: +0.2%

Memory: ✅ 32.362MB (SLO: <34.000MB -4.8%) vs baseline: +5.3%


✅ collectipvariant_exists

Time: ✅ 41.419µs (SLO: <50.000µs 📉 -17.2%) vs baseline: +1.9%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.3%


✅ no-collectipvariant

Time: ✅ 40.477µs (SLO: <50.000µs 📉 -19.0%) vs baseline: +1.5%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.4%


✅ no-useragentvariant

Time: ✅ 38.732µs (SLO: <50.000µs 📉 -22.5%) vs baseline: -0.2%

Memory: ✅ 32.342MB (SLO: <34.000MB -4.9%) vs baseline: +5.3%


✅ obfuscation-no-query

Time: ✅ 40.590µs (SLO: <50.000µs 📉 -18.8%) vs baseline: +0.8%

Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +4.2%


✅ obfuscation-regular-case-explicit-query

Time: ✅ 76.116µs (SLO: <90.000µs 📉 -15.4%) vs baseline: +0.7%

Memory: ✅ 32.303MB (SLO: <34.000MB -5.0%) vs baseline: +5.1%


✅ obfuscation-regular-case-implicit-query

Time: ✅ 77.148µs (SLO: <90.000µs 📉 -14.3%) vs baseline: +1.2%

Memory: ✅ 32.303MB (SLO: <34.000MB -5.0%) vs baseline: +5.2%


✅ obfuscation-send-querystring-disabled

Time: ✅ 153.713µs (SLO: <170.000µs -9.6%) vs baseline: ~same

Memory: ✅ 32.303MB (SLO: <34.500MB -6.4%) vs baseline: +5.2%


✅ obfuscation-worst-case-explicit-query

Time: ✅ 148.046µs (SLO: <160.000µs -7.5%) vs baseline: +0.1%

Memory: ✅ 32.480MB (SLO: <34.500MB -5.9%) vs baseline: +5.7%


✅ obfuscation-worst-case-implicit-query

Time: ✅ 155.106µs (SLO: <170.000µs -8.8%) vs baseline: +0.8%

Memory: ✅ 32.362MB (SLO: <34.500MB -6.2%) vs baseline: +5.3%


✅ useragentvariant_exists_1

Time: ✅ 39.528µs (SLO: <50.000µs 📉 -20.9%) vs baseline: +0.2%

Memory: ✅ 32.283MB (SLO: <34.000MB -5.0%) vs baseline: +5.1%


✅ useragentvariant_exists_2

Time: ✅ 41.217µs (SLO: <50.000µs 📉 -17.6%) vs baseline: +1.4%

Memory: ✅ 32.283MB (SLO: <34.000MB -5.0%) vs baseline: +5.1%


✅ useragentvariant_exists_3

Time: ✅ 40.025µs (SLO: <50.000µs 📉 -20.0%) vs baseline: +0.2%

Memory: ✅ 32.362MB (SLO: <34.000MB -4.8%) vs baseline: +5.7%


✅ useragentvariant_not_exists_1

Time: ✅ 39.555µs (SLO: <50.000µs 📉 -20.9%) vs baseline: +0.3%

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%) vs baseline: +5.2%


✅ useragentvariant_not_exists_2

Time: ✅ 39.762µs (SLO: <50.000µs 📉 -20.5%) vs baseline: +0.9%

Memory: ✅ 32.047MB (SLO: <34.000MB -5.7%) vs baseline: +4.3%


span - 26/26

✅ add-event

Time: ✅ 24.161ms (SLO: <26.200ms -7.8%) vs baseline: -0.1%

Memory: ✅ 51.201MB (SLO: <53.000MB -3.4%) vs baseline: +5.4%


✅ add-metrics

Time: ✅ 91.733ms (SLO: <98.350ms -6.7%) vs baseline: -0.5%

Memory: ✅ 607.035MB (SLO: <961.000MB 📉 -36.8%) vs baseline: +4.9%


✅ add-tags

Time: ✅ 151.955ms (SLO: <168.550ms -9.8%) vs baseline: +1.3%

Memory: ✅ 607.288MB (SLO: <962.500MB 📉 -36.9%) vs baseline: +4.8%


✅ get-context

Time: ✅ 22.518ms (SLO: <23.700ms -5.0%) vs baseline: +0.5%

Memory: ✅ 49.878MB (SLO: <53.000MB -5.9%) vs baseline: +5.0%


✅ is-recording

Time: ✅ 22.630ms (SLO: <23.900ms -5.3%) vs baseline: +0.2%

Memory: ✅ 49.908MB (SLO: <53.000MB -5.8%) vs baseline: +5.2%


✅ record-exception

Time: ✅ 42.627ms (SLO: <44.500ms -4.2%) vs baseline: +0.2%

Memory: ✅ 42.823MB (SLO: <53.000MB 📉 -19.2%) vs baseline: +5.4%


✅ set-status

Time: ✅ 24.647ms (SLO: <26.000ms -5.2%) vs baseline: +1.4%

Memory: ✅ 49.860MB (SLO: <53.000MB -5.9%) vs baseline: +5.1%


✅ start

Time: ✅ 22.086ms (SLO: <23.500ms -6.0%) vs baseline: ~same

Memory: ✅ 49.899MB (SLO: <53.000MB -5.9%) vs baseline: +5.1%


✅ start-finish

Time: ✅ 52.269ms (SLO: <55.500ms -5.8%) vs baseline: +0.5%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.1%


✅ start-finish-telemetry

Time: ✅ 53.606ms (SLO: <58.300ms -8.1%) vs baseline: +0.3%

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +5.4%


✅ start-finish-traceid128

Time: ✅ 55.666ms (SLO: <60.050ms -7.3%) vs baseline: +0.2%

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +5.5%


✅ start-traceid128

Time: ✅ 22.546ms (SLO: <24.600ms -8.4%) vs baseline: -0.5%

Memory: ✅ 49.933MB (SLO: <53.000MB -5.8%) vs baseline: +4.8%


✅ update-name

Time: ✅ 23.013ms (SLO: <24.100ms -4.5%) vs baseline: -0.5%

Memory: ✅ 50.585MB (SLO: <53.000MB -4.6%) vs baseline: +5.1%


telemetryaddmetric - 30/30

✅ 1-count-metric-1-times

Time: ✅ 3.347µs (SLO: <20.000µs 📉 -83.3%) vs baseline: +4.3%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.6%


✅ 1-count-metrics-100-times

Time: ✅ 216.695µs (SLO: <250.000µs 📉 -13.3%) vs baseline: -1.2%

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +5.3%


✅ 1-distribution-metric-1-times

Time: ✅ 3.017µs (SLO: <20.000µs 📉 -84.9%) vs baseline: +0.2%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.5%


✅ 1-distribution-metrics-100-times

Time: ✅ 197.027µs (SLO: <220.000µs 📉 -10.4%) vs baseline: -0.5%

Memory: ✅ 31.398MB (SLO: <34.000MB -7.7%) vs baseline: +5.2%


✅ 1-gauge-metric-1-times

Time: ✅ 2.170µs (SLO: <20.000µs 📉 -89.2%) vs baseline: +1.9%

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +5.4%


✅ 1-gauge-metrics-100-times

Time: ✅ 126.493µs (SLO: <150.000µs 📉 -15.7%) vs baseline: +1.1%

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%) vs baseline: +5.5%


✅ 1-rate-metric-1-times

Time: ✅ 3.185µs (SLO: <20.000µs 📉 -84.1%) vs baseline: -1.1%

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +5.5%


✅ 1-rate-metrics-100-times

Time: ✅ 216.401µs (SLO: <250.000µs 📉 -13.4%) vs baseline: -1.5%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.5%


✅ 100-count-metrics-100-times

Time: ✅ 21.915ms (SLO: <23.500ms -6.7%) vs baseline: -0.9%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.1%


✅ 100-distribution-metrics-100-times

Time: ✅ 2.112ms (SLO: <2.250ms -6.1%) vs baseline: +3.2%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.5%


✅ 100-gauge-metrics-100-times

Time: ✅ 1.303ms (SLO: <1.550ms 📉 -16.0%) vs baseline: ~same

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.5%


✅ 100-rate-metrics-100-times

Time: ✅ 2.221ms (SLO: <2.550ms 📉 -12.9%) vs baseline: -2.0%

Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +5.8%


✅ flush-1-metric

Time: ✅ 4.426µs (SLO: <20.000µs 📉 -77.9%) vs baseline: +4.3%

Memory: ✅ 31.831MB (SLO: <34.000MB -6.4%) vs baseline: +5.4%


✅ flush-100-metrics

Time: ✅ 187.023µs (SLO: <250.000µs 📉 -25.2%) vs baseline: +1.4%

Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +5.4%


✅ flush-1000-metrics

Time: ✅ 2.235ms (SLO: <2.500ms 📉 -10.6%) vs baseline: +0.1%

Memory: ✅ 32.637MB (SLO: <34.500MB -5.4%) vs baseline: +5.2%


tracer - 6/6

✅ large

Time: ✅ 30.650ms (SLO: <32.950ms -7.0%) vs baseline: +0.5%

Memory: ✅ 33.030MB (SLO: <34.500MB -4.3%) vs baseline: +5.2%


✅ medium

Time: ✅ 2.980ms (SLO: <3.200ms -6.9%) vs baseline: ~same

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.0%


✅ small

Time: ✅ 340.646µs (SLO: <370.000µs -7.9%) vs baseline: +0.9%

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +5.3%

ℹ️ Scenarios Missing SLO Configuration (14 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

  • coreapiscenario-context_with_data_listeners_and_all_listeners
  • coreapiscenario-core_dispatch_listeners
  • coreapiscenario-core_dispatch_listeners_and_all_listeners
  • coreapiscenario-core_dispatch_no_listeners
  • coreapiscenario-core_dispatch_only_all_listeners
  • coreapiscenario-core_dispatch_with_results_listeners
  • coreapiscenario-core_dispatch_with_results_listeners_and_all_listeners
  • coreapiscenario-core_dispatch_with_results_no_listeners
  • coreapiscenario-core_dispatch_with_results_only_all_listeners
  • djangosimple-baseline
  • errortrackingdjangosimple-baseline
  • errortrackingflasksqli-baseline
  • flasksimple-baseline
  • flasksqli-baseline

@wconti27 wconti27 marked this pull request as ready for review September 17, 2025 20:04
@wconti27 wconti27 requested review from a team as code owners September 17, 2025 20:04
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursory glance at the integration and gave some high level feedback, this PR mostly needs ml-obs review, but aren't the sole code owner yet.

Comment on lines 17 to 21
Alternatively, use :func:`patch() <ddtrace.patch>` to manually enable the Google ADK integration::
from ddtrace import config, patch
patch(google_adk=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Alternatively, use :func:`patch() <ddtrace.patch>` to manually enable the Google ADK integration::
from ddtrace import config, patch
patch(google_adk=True)

we shouldn't suggest this approach anymore.

honestly, not a big deal, but figure one less thing to remove in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should continue with the doc suggestions of not suggesting Pin.onto() or patch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

Copy link
Contributor

@sabrenner sabrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some initial thoughts on the patching code, will follow up with a closer review of the mlobs integration code after!

def _traced_agent_run_async(adk, pin, wrapped, instance, args, kwargs):
"""Trace the main execution of an agent (async generator)."""
integration = adk._datadog_integration
agen = wrapped(*args, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's start the span here, so we can do some try/except around this operation as well should it fail

something like

span = integration.trace(...)
try:
  agen = wrapped(*args, **kwargs)
except Exception:
  span.set_exc_info(...)
  span.finish()

async def _generator():  # finish the span in the `finally` block here as you already do
  ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. will leave unresolved so you can check that it was done the way you're expecting.

def extract_provider_and_model_name(kwargs: Optional[Dict[str, Any]] = None, agent: Any = None) -> Tuple[str, str]:
if agent is None:
return "google", "google"
return agent.model.__class__.__name__, agent.model.model
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we .lower here? i think we should if looking at class names, otherwise if we're able to grab some kind of str identifier on the agent object i think that could be better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there's only the model class name and the actual model name available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the .lower

kind = kwargs.get("kind", None)
if kind:
self._register_span(span, kind)
span._set_ctx_item(SPAN_KIND, kind)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd say we can leave this for the _set_llmobs_tags method, it takes in an operation kwarg that could be used in place of reading this ctx item back again there.

mainly just a best practice thing as trace here will run regardless of if llmobs is enabled. if it's not enabled, we don't want to bloat any aspect of the span or memory associated with it if possible, and instead set it in _llmobs_set_tags, which is guarded by the parent llmobs_set_tags to not run if llmobs is not enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants