Skip to content

chore(ci_visibility): remove unused function #13960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vitor-de-araujo
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/ext/git.py                                                      @DataDog/ci-app-libraries @DataDog/apm-core-python
tests/tracer/test_ci.py                                                 @DataDog/ci-app-libraries

Copy link
Contributor

github-actions bot commented Jul 11, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 275 ± 2 ms.

The average import time from base is: 277 ± 2 ms.

The import time difference between this PR and base is: -2.1 ± 0.08 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.988 ms (0.72%)
ddtrace.bootstrap.sitecustomize 1.316 ms (0.48%)
ddtrace.bootstrap.preload 1.316 ms (0.48%)
ddtrace.internal.remoteconfig.client 0.655 ms (0.24%)
ddtrace 0.672 ms (0.24%)
ddtrace.internal._unpatched 0.030 ms (0.01%)
json 0.030 ms (0.01%)
json.decoder 0.030 ms (0.01%)
re 0.030 ms (0.01%)
enum 0.030 ms (0.01%)
types 0.030 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jul 11, 2025

Benchmarks

Benchmark execution time: 2025-07-11 16:05:58

Comparing candidate commit efdf0ee in PR branch vitor-de-araujo/cleanup-ci-visibility-test with baseline commit 3a8fd53 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 546 metrics, 2 unstable metrics.

scenario:iastaspectsospath-ospathsplit_aspect

  • 🟥 execution_time [+1.002µs; +1.142µs] or [+20.799%; +23.702%]

scenario:iastaspectsospath-ospathsplitdrive_aspect

  • 🟥 execution_time [+512.489ns; +569.594ns] or [+13.927%; +15.479%]

@vitor-de-araujo
Copy link
Contributor Author

On hold until ddtrace 4.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant