-
Notifications
You must be signed in to change notification settings - Fork 449
fix(llmobs): fix input tokens counting for anthropic #13917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 275 ± 3 ms. The average import time from base is: 280 ± 3 ms. The import time difference between this PR and base is: -4.9 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
emmettbutler
approved these changes
Jul 9, 2025
releasenotes/notes/fix-anthropic-input-tokens-unified-calculation-a1b2c3d4e5f6g7h8.yaml
Outdated
Show resolved
Hide resolved
Yun-Kim
reviewed
Jul 11, 2025
releasenotes/notes/fix-anthropic-input-tokens-unified-calculation-a1b2c3d4e5f6g7h8.yaml
Outdated
Show resolved
Hide resolved
…ion-a1b2c3d4e5f6g7h8.yaml Co-authored-by: Yun Kim <[email protected]>
…py into evan.li/fix-ant-tokens
Yun-Kim
approved these changes
Jul 14, 2025
alyshawang
pushed a commit
that referenced
this pull request
Jul 25, 2025
When prompt caching is used in anthropic, the number of input tokens returned in the usage field is the number of non cached tokens, not the total number of tokens sent to the model (what we expect in datadog) This pr fixes this by setting input tokens to the total number of input tokens (cache read + cache write + input tokens) ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Yun Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When prompt caching is used in anthropic, the number of input tokens returned in the usage field is the number of non cached tokens, not the total number of tokens sent to the model (what we expect in datadog)
This pr fixes this by setting input tokens to the total number of input tokens (cache read + cache write + input tokens)
Checklist
Reviewer Checklist