-
Notifications
You must be signed in to change notification settings - Fork 467
chore(iast): improve detection of ddtrace frames #13344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 5 ms. The average import time from base is: 245 ± 4 ms. The import time difference between this PR and base is: -6.7 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-05-07 16:41:16 Comparing candidate commit 591c2f1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 8 unstable metrics. |
f6546dd to
517ee65
Compare
8b8139e to
591c2f1
Compare
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.21 2.21
# Navigate to the new working tree
cd .worktrees/backport-2.21
# Create a new branch
git switch --create backport-13344-to-2.21
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bf8e827d62c24eee36d8ce6ca78cc4411e759b5b
# Push it to GitHub
git push --set-upstream origin backport-13344-to-2.21
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.21Then, create a pull request where the |
Use more robust method to filter out frames from
ddtracemodule. The previous version would not work in some tests if the relevant frame was in site-packages within a virtual env namedddtrace, which happens in tests for #13256. This would generally not affect customers, but misbehaves in our test suite.Checklist
Reviewer Checklist