- 
                Notifications
    
You must be signed in to change notification settings  - Fork 315
 
          Avoid using commit-headless to push a branch with no commits
          #9837
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c51bfef    to
    99f97e3      
    Compare
  
    | 
           Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to: 
 If you need help, please check our contributing guidelines.  | 
    
| 
           🎯 Code Coverage 🔗 Commit SHA: 99f97e3 | Docs | Was this helpful? Give us feedback!  | 
    
          BenchmarksStartupParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~99f97e30a1, baseline=1.55.0-SNAPSHOT~4c89f79741
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1029515
Total [baseline] (8.656 s) : 0, 8656446
Agent [candidate] (1.018 s) : 0, 1018004
Total [candidate] (8.64 s) : 0, 8639704
section iast
Agent [baseline] (1.156 s) : 0, 1155943
Total [baseline] (9.362 s) : 0, 9361695
Agent [candidate] (1.154 s) : 0, 1153837
Total [candidate] (9.303 s) : 0, 9303499
    
 
 
 
 gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~99f97e30a1, baseline=1.55.0-SNAPSHOT~4c89f79741
    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (701.883 ms) : 0, 701883
BytebuddyAgent [candidate] (692.808 ms) : 0, 692808
GlobalTracer [baseline] (244.708 ms) : 0, 244708
GlobalTracer [candidate] (242.689 ms) : 0, 242689
AppSec [baseline] (32.426 ms) : 0, 32426
AppSec [candidate] (32.238 ms) : 0, 32238
Debugger [baseline] (6.405 ms) : 0, 6405
Debugger [candidate] (6.272 ms) : 0, 6272
Remote Config [baseline] (687.745 µs) : 0, 688
Remote Config [candidate] (670.949 µs) : 0, 671
Telemetry [baseline] (14.406 ms) : 0, 14406
Telemetry [candidate] (9.271 ms) : 0, 9271
Flare Poller [baseline] (6.439 ms) : 0, 6439
Flare Poller [candidate] (11.614 ms) : 0, 11614
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (819.924 ms) : 0, 819924
BytebuddyAgent [candidate] (817.388 ms) : 0, 817388
GlobalTracer [baseline] (232.647 ms) : 0, 232647
GlobalTracer [candidate] (232.066 ms) : 0, 232066
IAST [baseline] (31.643 ms) : 0, 31643
IAST [candidate] (26.779 ms) : 0, 26779
AppSec [baseline] (29.816 ms) : 0, 29816
AppSec [candidate] (35.024 ms) : 0, 35024
Debugger [baseline] (6.061 ms) : 0, 6061
Debugger [candidate] (6.13 ms) : 0, 6130
Remote Config [baseline] (598.576 µs) : 0, 599
Remote Config [candidate] (595.62 µs) : 0, 596
Telemetry [baseline] (8.371 ms) : 0, 8371
Telemetry [candidate] (8.741 ms) : 0, 8741
Flare Poller [baseline] (4.209 ms) : 0, 4209
Flare Poller [candidate] (4.212 ms) : 0, 4212
    Startup time reports for petclinicgantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~99f97e30a1, baseline=1.55.0-SNAPSHOT~4c89f79741
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1036429
Total [baseline] (10.776 s) : 0, 10775637
Agent [candidate] (1.018 s) : 0, 1018437
Total [candidate] (10.81 s) : 0, 10810063
section appsec
Agent [baseline] (1.198 s) : 0, 1198234
Total [baseline] (10.85 s) : 0, 10849846
Agent [candidate] (1.192 s) : 0, 1191540
Total [candidate] (10.794 s) : 0, 10793551
section iast
Agent [baseline] (1.164 s) : 0, 1164179
Total [baseline] (11.11 s) : 0, 11109566
Agent [candidate] (1.152 s) : 0, 1151776
Total [candidate] (11.157 s) : 0, 11156744
section profiling
Agent [baseline] (1.173 s) : 0, 1172967
Total [baseline] (10.889 s) : 0, 10888704
Agent [candidate] (1.162 s) : 0, 1161688
Total [candidate] (10.81 s) : 0, 10810181
    
 
 
 
 gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~99f97e30a1, baseline=1.55.0-SNAPSHOT~4c89f79741
    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (706.19 ms) : 0, 706190
BytebuddyAgent [candidate] (693.63 ms) : 0, 693630
GlobalTracer [baseline] (246.56 ms) : 0, 246560
GlobalTracer [candidate] (243.235 ms) : 0, 243235
AppSec [baseline] (32.706 ms) : 0, 32706
AppSec [candidate] (32.279 ms) : 0, 32279
Debugger [baseline] (6.492 ms) : 0, 6492
Debugger [candidate] (6.315 ms) : 0, 6315
Remote Config [baseline] (688.102 µs) : 0, 688
Remote Config [candidate] (665.054 µs) : 0, 665
Telemetry [baseline] (15.236 ms) : 0, 15236
Telemetry [candidate] (9.297 ms) : 0, 9297
Flare Poller [baseline] (5.824 ms) : 0, 5824
Flare Poller [candidate] (10.398 ms) : 0, 10398
section appsec
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (723.323 ms) : 0, 723323
BytebuddyAgent [candidate] (716.476 ms) : 0, 716476
GlobalTracer [baseline] (235.049 ms) : 0, 235049
GlobalTracer [candidate] (234.416 ms) : 0, 234416
IAST [baseline] (24.855 ms) : 0, 24855
IAST [candidate] (24.91 ms) : 0, 24910
AppSec [baseline] (173.711 ms) : 0, 173711
AppSec [candidate] (174.157 ms) : 0, 174157
Debugger [baseline] (5.926 ms) : 0, 5926
Debugger [candidate] (6.036 ms) : 0, 6036
Remote Config [baseline] (617.588 µs) : 0, 618
Remote Config [candidate] (650.556 µs) : 0, 651
Telemetry [baseline] (8.338 ms) : 0, 8338
Telemetry [candidate] (8.463 ms) : 0, 8463
Flare Poller [baseline] (3.908 ms) : 0, 3908
Flare Poller [candidate] (3.855 ms) : 0, 3855
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (826.012 ms) : 0, 826012
BytebuddyAgent [candidate] (815.304 ms) : 0, 815304
GlobalTracer [baseline] (234.01 ms) : 0, 234010
GlobalTracer [candidate] (231.406 ms) : 0, 231406
IAST [baseline] (30.249 ms) : 0, 30249
IAST [candidate] (27.042 ms) : 0, 27042
AppSec [baseline] (31.554 ms) : 0, 31554
AppSec [candidate] (35.22 ms) : 0, 35220
Debugger [baseline] (6.114 ms) : 0, 6114
Debugger [candidate] (6.195 ms) : 0, 6195
Remote Config [baseline] (598.954 µs) : 0, 599
Remote Config [candidate] (622.916 µs) : 0, 623
Telemetry [baseline] (8.584 ms) : 0, 8584
Telemetry [candidate] (8.804 ms) : 0, 8804
Flare Poller [baseline] (4.219 ms) : 0, 4219
Flare Poller [candidate] (4.306 ms) : 0, 4306
section profiling
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (726.371 ms) : 0, 726371
BytebuddyAgent [candidate] (719.394 ms) : 0, 719394
GlobalTracer [baseline] (220.814 ms) : 0, 220814
GlobalTracer [candidate] (218.381 ms) : 0, 218381
AppSec [baseline] (32.318 ms) : 0, 32318
AppSec [candidate] (32.27 ms) : 0, 32270
Debugger [baseline] (12.138 ms) : 0, 12138
Debugger [candidate] (6.643 ms) : 0, 6643
Remote Config [baseline] (707.901 µs) : 0, 708
Remote Config [candidate] (682.031 µs) : 0, 682
Telemetry [baseline] (10.536 ms) : 0, 10536
Telemetry [candidate] (15.879 ms) : 0, 15879
Flare Poller [baseline] (4.14 ms) : 0, 4140
Flare Poller [candidate] (4.167 ms) : 0, 4167
ProfilingAgent [baseline] (109.253 ms) : 0, 109253
ProfilingAgent [candidate] (109.213 ms) : 0, 109213
Profiling [baseline] (109.865 ms) : 0, 109865
Profiling [candidate] (109.838 ms) : 0, 109838
    LoadParameters
 See matching parameters
 SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics. 
 Request duration reports for petclinicgantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~99f97e30a1, baseline=1.55.0-SNAPSHOT~4c89f79741
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.35 ms) : 37044, 37657
.   : milestone, 37350,
appsec (48.291 ms) : 47859, 48723
.   : milestone, 48291,
code_origins (43.88 ms) : 43498, 44263
.   : milestone, 43880,
iast (43.678 ms) : 43310, 44046
.   : milestone, 43678,
profiling (46.374 ms) : 45935, 46813
.   : milestone, 46374,
tracing (45.802 ms) : 45424, 46181
.   : milestone, 45802,
section candidate
no_agent (36.95 ms) : 36646, 37253
.   : milestone, 36950,
appsec (50.551 ms) : 50091, 51012
.   : milestone, 50551,
code_origins (41.977 ms) : 41618, 42336
.   : milestone, 41977,
iast (43.976 ms) : 43597, 44355
.   : milestone, 43976,
profiling (50.647 ms) : 50206, 51088
.   : milestone, 50647,
tracing (43.492 ms) : 43121, 43862
.   : milestone, 43492,
    
 
 
 
 Request duration reports for insecure-bankgantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~99f97e30a1, baseline=1.55.0-SNAPSHOT~4c89f79741
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.399 ms) : 4348, 4449
.   : milestone, 4399,
iast (9.54 ms) : 9383, 9696
.   : milestone, 9540,
iast_FULL (14.106 ms) : 13825, 14386
.   : milestone, 14106,
iast_GLOBAL (10.193 ms) : 10014, 10372
.   : milestone, 10193,
profiling (9.126 ms) : 8983, 9268
.   : milestone, 9126,
tracing (8.012 ms) : 7897, 8127
.   : milestone, 8012,
section candidate
no_agent (4.391 ms) : 4335, 4447
.   : milestone, 4391,
iast (10.11 ms) : 9939, 10282
.   : milestone, 10110,
iast_FULL (14.344 ms) : 14047, 14641
.   : milestone, 14344,
iast_GLOBAL (10.363 ms) : 10179, 10547
.   : milestone, 10363,
profiling (9.054 ms) : 8902, 9205
.   : milestone, 9054,
tracing (7.53 ms) : 7410, 7650
.   : milestone, 7530,
    
 
 
 
 DacapoParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~99f97e30a1, baseline=1.55.0-SNAPSHOT~4c89f79741
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.984 s) : 14984000, 14984000
.   : milestone, 14984000,
appsec (14.889 s) : 14889000, 14889000
.   : milestone, 14889000,
iast (18.613 s) : 18613000, 18613000
.   : milestone, 18613000,
iast_GLOBAL (17.953 s) : 17953000, 17953000
.   : milestone, 17953000,
profiling (15.38 s) : 15380000, 15380000
.   : milestone, 15380000,
tracing (15.247 s) : 15247000, 15247000
.   : milestone, 15247000,
section candidate
no_agent (15.21 s) : 15210000, 15210000
.   : milestone, 15210000,
appsec (15.051 s) : 15051000, 15051000
.   : milestone, 15051000,
iast (18.476 s) : 18476000, 18476000
.   : milestone, 18476000,
iast_GLOBAL (17.958 s) : 17958000, 17958000
.   : milestone, 17958000,
profiling (15.054 s) : 15054000, 15054000
.   : milestone, 15054000,
tracing (14.964 s) : 14964000, 14964000
.   : milestone, 14964000,
    
 
 
 
 Execution time for tomcatgantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~99f97e30a1, baseline=1.55.0-SNAPSHOT~4c89f79741
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (3.665 ms) : 3451, 3878
.   : milestone, 3665,
iast (2.215 ms) : 2150, 2280
.   : milestone, 2215,
iast_GLOBAL (2.258 ms) : 2194, 2323
.   : milestone, 2258,
profiling (2.073 ms) : 2020, 2126
.   : milestone, 2073,
tracing (2.04 ms) : 1989, 2091
.   : milestone, 2040,
section candidate
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (3.688 ms) : 3471, 3906
.   : milestone, 3688,
iast (2.208 ms) : 2144, 2272
.   : milestone, 2208,
iast_GLOBAL (2.257 ms) : 2192, 2322
.   : milestone, 2257,
profiling (2.071 ms) : 2018, 2124
.   : milestone, 2071,
tracing (2.033 ms) : 1982, 2083
.   : milestone, 2033,
    
 
 
 
  | 
    
What Does This Do
When pushing the
release/v*branch, now we use justgit push -u origin branchNameinstead of thecommit-headlesstool. I also changed the job permissions to allow pushing branches and specify thedd-trace-javacheckout point to the commit SHA that triggered the workflow.Motivation
I mistakenly thought #9836 addressed the issue of an empty commit, but turns out
commit-headlessdoes not allow pushing a branch with no commit specified either (failure). So, we removecommit-headlessentirely and use justgit checkout && git pushinstead.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]