-
Notifications
You must be signed in to change notification settings - Fork 314
Fix synchronize access to DebuggerMetrics #9831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to mention that it was found by Spotbug?
|
🎯 Code Coverage 🔗 Commit SHA: ec29bb9 | Docs | Was this helpful? Give us feedback! |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (337.791 µs) : 280, 395
. : milestone, 338,
basic (294.238 µs) : 287, 302
. : milestone, 294,
loop (8.961 ms) : 8938, 8984
. : milestone, 8961,
section candidate
noprobe (312.38 µs) : 284, 341
. : milestone, 312,
basic (287.435 µs) : 281, 294
. : milestone, 287,
loop (8.955 ms) : 8950, 8959
. : milestone, 8955,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~ec29bb9b4c, baseline=1.55.0-SNAPSHOT~2a41c8bf2a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020795
Total [baseline] (8.728 s) : 0, 8727516
Agent [candidate] (1.018 s) : 0, 1018244
Total [candidate] (8.696 s) : 0, 8695843
section iast
Agent [baseline] (1.154 s) : 0, 1153513
Total [baseline] (9.323 s) : 0, 9322732
Agent [candidate] (1.153 s) : 0, 1152888
Total [candidate] (9.313 s) : 0, 9313485
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~ec29bb9b4c, baseline=1.55.0-SNAPSHOT~2a41c8bf2a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (695.864 ms) : 0, 695864
BytebuddyAgent [candidate] (692.652 ms) : 0, 692652
GlobalTracer [baseline] (243.388 ms) : 0, 243388
GlobalTracer [candidate] (243.035 ms) : 0, 243035
AppSec [baseline] (32.194 ms) : 0, 32194
AppSec [candidate] (32.089 ms) : 0, 32089
Debugger [baseline] (6.254 ms) : 0, 6254
Debugger [candidate] (6.296 ms) : 0, 6296
Remote Config [baseline] (679.397 µs) : 0, 679
Remote Config [candidate] (687.002 µs) : 0, 687
Telemetry [baseline] (9.303 ms) : 0, 9303
Telemetry [candidate] (9.258 ms) : 0, 9258
Flare Poller [baseline] (10.447 ms) : 0, 10447
Flare Poller [candidate] (11.616 ms) : 0, 11616
section iast
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.507 ms) : 0, 1507
BytebuddyAgent [baseline] (817.01 ms) : 0, 817010
BytebuddyAgent [candidate] (816.883 ms) : 0, 816883
GlobalTracer [baseline] (231.854 ms) : 0, 231854
GlobalTracer [candidate] (231.584 ms) : 0, 231584
AppSec [baseline] (35.38 ms) : 0, 35380
AppSec [candidate] (35.038 ms) : 0, 35038
Debugger [baseline] (6.158 ms) : 0, 6158
Debugger [candidate] (6.203 ms) : 0, 6203
Remote Config [baseline] (603.664 µs) : 0, 604
Remote Config [candidate] (606.193 µs) : 0, 606
Telemetry [baseline] (8.69 ms) : 0, 8690
Telemetry [candidate] (8.707 ms) : 0, 8707
Flare Poller [baseline] (4.201 ms) : 0, 4201
Flare Poller [candidate] (4.277 ms) : 0, 4277
IAST [baseline] (26.656 ms) : 0, 26656
IAST [candidate] (26.664 ms) : 0, 26664
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~ec29bb9b4c, baseline=1.55.0-SNAPSHOT~2a41c8bf2a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1025221
Total [baseline] (10.743 s) : 0, 10743100
Agent [candidate] (1.018 s) : 0, 1018354
Total [candidate] (10.68 s) : 0, 10680088
section appsec
Agent [baseline] (1.198 s) : 0, 1198114
Total [baseline] (10.811 s) : 0, 10810702
Agent [candidate] (1.197 s) : 0, 1196787
Total [candidate] (10.974 s) : 0, 10973679
section iast
Agent [baseline] (1.156 s) : 0, 1156218
Total [baseline] (11.068 s) : 0, 11067944
Agent [candidate] (1.169 s) : 0, 1169432
Total [candidate] (11.218 s) : 0, 11217826
section profiling
Agent [baseline] (1.165 s) : 0, 1164861
Total [baseline] (10.924 s) : 0, 10923873
Agent [candidate] (1.174 s) : 0, 1173604
Total [candidate] (10.925 s) : 0, 10925447
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~ec29bb9b4c, baseline=1.55.0-SNAPSHOT~2a41c8bf2a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (698.298 ms) : 0, 698298
BytebuddyAgent [candidate] (693.457 ms) : 0, 693457
GlobalTracer [baseline] (244.935 ms) : 0, 244935
GlobalTracer [candidate] (243.249 ms) : 0, 243249
AppSec [baseline] (32.545 ms) : 0, 32545
AppSec [candidate] (32.089 ms) : 0, 32089
Debugger [baseline] (6.402 ms) : 0, 6402
Debugger [candidate] (6.248 ms) : 0, 6248
Remote Config [baseline] (689.305 µs) : 0, 689
Remote Config [candidate] (670.197 µs) : 0, 670
Telemetry [baseline] (9.474 ms) : 0, 9474
Telemetry [candidate] (9.149 ms) : 0, 9149
Flare Poller [baseline] (10.091 ms) : 0, 10091
Flare Poller [candidate] (10.825 ms) : 0, 10825
section appsec
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (720.305 ms) : 0, 720305
BytebuddyAgent [candidate] (719.986 ms) : 0, 719986
GlobalTracer [baseline] (235.775 ms) : 0, 235775
GlobalTracer [candidate] (234.981 ms) : 0, 234981
AppSec [baseline] (175.343 ms) : 0, 175343
AppSec [candidate] (175.156 ms) : 0, 175156
Debugger [baseline] (6.01 ms) : 0, 6010
Debugger [candidate] (6.035 ms) : 0, 6035
Remote Config [baseline] (630.307 µs) : 0, 630
Remote Config [candidate] (622.36 µs) : 0, 622
Telemetry [baseline] (8.469 ms) : 0, 8469
Telemetry [candidate] (8.465 ms) : 0, 8465
Flare Poller [baseline] (3.862 ms) : 0, 3862
Flare Poller [candidate] (3.872 ms) : 0, 3872
IAST [baseline] (25.042 ms) : 0, 25042
IAST [candidate] (25.039 ms) : 0, 25039
section iast
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (818.836 ms) : 0, 818836
BytebuddyAgent [candidate] (828.936 ms) : 0, 828936
GlobalTracer [baseline] (232.321 ms) : 0, 232321
GlobalTracer [candidate] (234.526 ms) : 0, 234526
AppSec [baseline] (35.344 ms) : 0, 35344
AppSec [candidate] (35.914 ms) : 0, 35914
Debugger [baseline] (6.189 ms) : 0, 6189
Debugger [candidate] (6.176 ms) : 0, 6176
Remote Config [baseline] (615.144 µs) : 0, 615
Remote Config [candidate] (619.769 µs) : 0, 620
Telemetry [baseline] (8.774 ms) : 0, 8774
Telemetry [candidate] (8.736 ms) : 0, 8736
Flare Poller [baseline] (4.266 ms) : 0, 4266
Flare Poller [candidate] (4.321 ms) : 0, 4321
IAST [baseline] (26.797 ms) : 0, 26797
IAST [candidate] (26.993 ms) : 0, 26993
section profiling
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (720.701 ms) : 0, 720701
BytebuddyAgent [candidate] (726.93 ms) : 0, 726930
GlobalTracer [baseline] (218.995 ms) : 0, 218995
GlobalTracer [candidate] (220.22 ms) : 0, 220220
AppSec [baseline] (32.414 ms) : 0, 32414
AppSec [candidate] (32.536 ms) : 0, 32536
Debugger [baseline] (6.648 ms) : 0, 6648
Debugger [candidate] (7.474 ms) : 0, 7474
Remote Config [baseline] (714.726 µs) : 0, 715
Remote Config [candidate] (687.177 µs) : 0, 687
Telemetry [baseline] (15.862 ms) : 0, 15862
Telemetry [candidate] (15.18 ms) : 0, 15180
Flare Poller [baseline] (4.174 ms) : 0, 4174
Flare Poller [candidate] (4.217 ms) : 0, 4217
ProfilingAgent [baseline] (110.025 ms) : 0, 110025
ProfilingAgent [candidate] (110.546 ms) : 0, 110546
Profiling [baseline] (110.639 ms) : 0, 110639
Profiling [candidate] (111.207 ms) : 0, 111207
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~ec29bb9b4c, baseline=1.55.0-SNAPSHOT~2a41c8bf2a
dateFormat X
axisFormat %s
section baseline
no_agent (37.449 ms) : 37143, 37756
. : milestone, 37449,
appsec (47.103 ms) : 46668, 47538
. : milestone, 47103,
code_origins (42.401 ms) : 42039, 42762
. : milestone, 42401,
iast (45.417 ms) : 45018, 45816
. : milestone, 45417,
profiling (47.613 ms) : 47165, 48062
. : milestone, 47613,
tracing (45.747 ms) : 45357, 46138
. : milestone, 45747,
section candidate
no_agent (36.614 ms) : 36329, 36899
. : milestone, 36614,
appsec (46.522 ms) : 46103, 46941
. : milestone, 46522,
code_origins (43.188 ms) : 42810, 43566
. : milestone, 43188,
iast (43.185 ms) : 42823, 43547
. : milestone, 43185,
profiling (49.046 ms) : 48595, 49497
. : milestone, 49046,
tracing (42.928 ms) : 42562, 43293
. : milestone, 42928,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~ec29bb9b4c, baseline=1.55.0-SNAPSHOT~2a41c8bf2a
dateFormat X
axisFormat %s
section baseline
no_agent (4.33 ms) : 4282, 4377
. : milestone, 4330,
iast (9.816 ms) : 9654, 9977
. : milestone, 9816,
iast_FULL (15.18 ms) : 14876, 15484
. : milestone, 15180,
iast_GLOBAL (10.647 ms) : 10460, 10834
. : milestone, 10647,
profiling (9.228 ms) : 9062, 9394
. : milestone, 9228,
tracing (7.405 ms) : 7303, 7507
. : milestone, 7405,
section candidate
no_agent (4.362 ms) : 4312, 4411
. : milestone, 4362,
iast (10.219 ms) : 10045, 10393
. : milestone, 10219,
iast_FULL (14.123 ms) : 13848, 14397
. : milestone, 14123,
iast_GLOBAL (10.373 ms) : 10189, 10558
. : milestone, 10373,
profiling (8.944 ms) : 8797, 9092
. : milestone, 8944,
tracing (7.813 ms) : 7686, 7940
. : milestone, 7813,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~ec29bb9b4c, baseline=1.55.0-SNAPSHOT~2a41c8bf2a
dateFormat X
axisFormat %s
section baseline
no_agent (15.585 s) : 15585000, 15585000
. : milestone, 15585000,
appsec (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
iast (18.696 s) : 18696000, 18696000
. : milestone, 18696000,
iast_GLOBAL (17.884 s) : 17884000, 17884000
. : milestone, 17884000,
profiling (15.345 s) : 15345000, 15345000
. : milestone, 15345000,
tracing (14.971 s) : 14971000, 14971000
. : milestone, 14971000,
section candidate
no_agent (15.537 s) : 15537000, 15537000
. : milestone, 15537000,
appsec (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
iast (18.649 s) : 18649000, 18649000
. : milestone, 18649000,
iast_GLOBAL (17.686 s) : 17686000, 17686000
. : milestone, 17686000,
profiling (15.536 s) : 15536000, 15536000
. : milestone, 15536000,
tracing (15.12 s) : 15120000, 15120000
. : milestone, 15120000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~ec29bb9b4c, baseline=1.55.0-SNAPSHOT~2a41c8bf2a
dateFormat X
axisFormat %s
section baseline
no_agent (1.492 ms) : 1480, 1503
. : milestone, 1492,
appsec (3.729 ms) : 3509, 3949
. : milestone, 3729,
iast (2.233 ms) : 2170, 2297
. : milestone, 2233,
iast_GLOBAL (2.27 ms) : 2206, 2334
. : milestone, 2270,
profiling (2.078 ms) : 2026, 2130
. : milestone, 2078,
tracing (2.038 ms) : 1988, 2088
. : milestone, 2038,
section candidate
no_agent (1.487 ms) : 1476, 1499
. : milestone, 1487,
appsec (2.482 ms) : 2431, 2533
. : milestone, 2482,
iast (2.235 ms) : 2171, 2298
. : milestone, 2235,
iast_GLOBAL (2.268 ms) : 2204, 2332
. : milestone, 2268,
profiling (2.089 ms) : 2036, 2142
. : milestone, 2089,
tracing (2.054 ms) : 2004, 2104
. : milestone, 2054,
|
What Does This Do
add synchronized keyword
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]