-
Notifications
You must be signed in to change notification settings - Fork 314
Remove ref_protected requirement in trust policy #9824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: 7a4077d | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~7a4077d479, baseline=1.55.0-SNAPSHOT~31e1420200
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1025117
Total [baseline] (10.77 s) : 0, 10769857
Agent [candidate] (1.024 s) : 0, 1023995
Total [candidate] (10.745 s) : 0, 10745383
section appsec
Agent [baseline] (1.196 s) : 0, 1196458
Total [baseline] (10.852 s) : 0, 10851752
Agent [candidate] (1.199 s) : 0, 1199374
Total [candidate] (10.916 s) : 0, 10916165
section iast
Agent [baseline] (1.161 s) : 0, 1161134
Total [baseline] (11.154 s) : 0, 11154417
Agent [candidate] (1.156 s) : 0, 1156368
Total [candidate] (11.13 s) : 0, 11129796
section profiling
Agent [baseline] (1.167 s) : 0, 1167484
Total [baseline] (10.969 s) : 0, 10969339
Agent [candidate] (1.165 s) : 0, 1164537
Total [candidate] (10.912 s) : 0, 10911704
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~7a4077d479, baseline=1.55.0-SNAPSHOT~31e1420200
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (699.794 ms) : 0, 699794
BytebuddyAgent [candidate] (699.859 ms) : 0, 699859
GlobalTracer [baseline] (244.815 ms) : 0, 244815
GlobalTracer [candidate] (244.652 ms) : 0, 244652
AppSec [baseline] (32.383 ms) : 0, 32383
AppSec [candidate] (32.402 ms) : 0, 32402
Debugger [baseline] (6.354 ms) : 0, 6354
Debugger [candidate] (6.293 ms) : 0, 6293
Remote Config [baseline] (685.367 µs) : 0, 685
Remote Config [candidate] (681.866 µs) : 0, 682
Telemetry [baseline] (9.337 ms) : 0, 9337
Telemetry [candidate] (9.268 ms) : 0, 9268
Flare Poller [baseline] (8.927 ms) : 0, 8927
Flare Poller [candidate] (8.01 ms) : 0, 8010
section appsec
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (719.523 ms) : 0, 719523
BytebuddyAgent [candidate] (720.997 ms) : 0, 720997
GlobalTracer [baseline] (234.852 ms) : 0, 234852
GlobalTracer [candidate] (235.582 ms) : 0, 235582
IAST [baseline] (24.704 ms) : 0, 24704
IAST [candidate] (24.945 ms) : 0, 24945
AppSec [baseline] (175.393 ms) : 0, 175393
AppSec [candidate] (174.995 ms) : 0, 174995
Debugger [baseline] (6.101 ms) : 0, 6101
Debugger [candidate] (6.135 ms) : 0, 6135
Remote Config [baseline] (635.875 µs) : 0, 636
Remote Config [candidate] (644.913 µs) : 0, 645
Telemetry [baseline] (8.555 ms) : 0, 8555
Telemetry [candidate] (9.41 ms) : 0, 9410
Flare Poller [baseline] (3.941 ms) : 0, 3941
Flare Poller [candidate] (3.949 ms) : 0, 3949
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (822.176 ms) : 0, 822176
BytebuddyAgent [candidate] (819.12 ms) : 0, 819120
GlobalTracer [baseline] (233.554 ms) : 0, 233554
GlobalTracer [candidate] (232.525 ms) : 0, 232525
IAST [baseline] (26.934 ms) : 0, 26934
IAST [candidate] (26.821 ms) : 0, 26821
AppSec [baseline] (35.609 ms) : 0, 35609
AppSec [candidate] (35.328 ms) : 0, 35328
Debugger [baseline] (6.17 ms) : 0, 6170
Debugger [candidate] (6.132 ms) : 0, 6132
Remote Config [baseline] (609.489 µs) : 0, 609
Remote Config [candidate] (604.473 µs) : 0, 604
Telemetry [baseline] (8.684 ms) : 0, 8684
Telemetry [candidate] (8.588 ms) : 0, 8588
Flare Poller [baseline] (4.315 ms) : 0, 4315
Flare Poller [candidate] (4.254 ms) : 0, 4254
section profiling
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (722.372 ms) : 0, 722372
BytebuddyAgent [candidate] (720.679 ms) : 0, 720679
GlobalTracer [baseline] (219.758 ms) : 0, 219758
GlobalTracer [candidate] (219.206 ms) : 0, 219206
AppSec [baseline] (32.308 ms) : 0, 32308
AppSec [candidate] (32.334 ms) : 0, 32334
Debugger [baseline] (6.662 ms) : 0, 6662
Debugger [candidate] (6.659 ms) : 0, 6659
Remote Config [baseline] (713.173 µs) : 0, 713
Remote Config [candidate] (675.879 µs) : 0, 676
Telemetry [baseline] (15.875 ms) : 0, 15875
Telemetry [candidate] (15.939 ms) : 0, 15939
Flare Poller [baseline] (4.123 ms) : 0, 4123
Flare Poller [candidate] (4.159 ms) : 0, 4159
ProfilingAgent [baseline] (110.188 ms) : 0, 110188
ProfilingAgent [candidate] (109.615 ms) : 0, 109615
Profiling [baseline] (110.824 ms) : 0, 110824
Profiling [candidate] (110.271 ms) : 0, 110271
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~7a4077d479, baseline=1.55.0-SNAPSHOT~31e1420200
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1021800
Total [baseline] (8.68 s) : 0, 8680425
Agent [candidate] (1.021 s) : 0, 1021139
Total [candidate] (8.677 s) : 0, 8676963
section iast
Agent [baseline] (1.153 s) : 0, 1152713
Total [baseline] (9.323 s) : 0, 9323071
Agent [candidate] (1.149 s) : 0, 1148963
Total [candidate] (9.331 s) : 0, 9330972
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~7a4077d479, baseline=1.55.0-SNAPSHOT~31e1420200
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (695.917 ms) : 0, 695917
BytebuddyAgent [candidate] (695.339 ms) : 0, 695339
GlobalTracer [baseline] (243.278 ms) : 0, 243278
GlobalTracer [candidate] (244.007 ms) : 0, 244007
AppSec [baseline] (32.337 ms) : 0, 32337
AppSec [candidate] (32.196 ms) : 0, 32196
Debugger [baseline] (6.272 ms) : 0, 6272
Debugger [candidate] (6.307 ms) : 0, 6307
Remote Config [baseline] (680.081 µs) : 0, 680
Remote Config [candidate] (677.291 µs) : 0, 677
Telemetry [baseline] (9.405 ms) : 0, 9405
Telemetry [candidate] (9.295 ms) : 0, 9295
Flare Poller [baseline] (11.222 ms) : 0, 11222
Flare Poller [candidate] (10.683 ms) : 0, 10683
section iast
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (815.892 ms) : 0, 815892
BytebuddyAgent [candidate] (813.291 ms) : 0, 813291
GlobalTracer [baseline] (232.084 ms) : 0, 232084
GlobalTracer [candidate] (231.421 ms) : 0, 231421
IAST [baseline] (26.769 ms) : 0, 26769
IAST [candidate] (26.64 ms) : 0, 26640
AppSec [baseline] (35.424 ms) : 0, 35424
AppSec [candidate] (35.057 ms) : 0, 35057
Debugger [baseline] (6.145 ms) : 0, 6145
Debugger [candidate] (6.179 ms) : 0, 6179
Remote Config [baseline] (608.489 µs) : 0, 608
Remote Config [candidate] (600.581 µs) : 0, 601
Telemetry [baseline] (8.602 ms) : 0, 8602
Telemetry [candidate] (8.75 ms) : 0, 8750
Flare Poller [baseline] (4.273 ms) : 0, 4273
Flare Poller [candidate] (4.202 ms) : 0, 4202
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~7a4077d479, baseline=1.55.0-SNAPSHOT~31e1420200
dateFormat X
axisFormat %s
section baseline
no_agent (4.312 ms) : 4264, 4360
. : milestone, 4312,
iast (9.445 ms) : 9291, 9599
. : milestone, 9445,
iast_FULL (15.652 ms) : 15341, 15963
. : milestone, 15652,
iast_GLOBAL (10.949 ms) : 10745, 11154
. : milestone, 10949,
profiling (8.551 ms) : 8415, 8688
. : milestone, 8551,
tracing (8.322 ms) : 8200, 8444
. : milestone, 8322,
section candidate
no_agent (4.292 ms) : 4238, 4346
. : milestone, 4292,
iast (9.516 ms) : 9351, 9681
. : milestone, 9516,
iast_FULL (14.143 ms) : 13860, 14425
. : milestone, 14143,
iast_GLOBAL (10.843 ms) : 10625, 11061
. : milestone, 10843,
profiling (9.178 ms) : 9031, 9326
. : milestone, 9178,
tracing (7.606 ms) : 7498, 7714
. : milestone, 7606,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~7a4077d479, baseline=1.55.0-SNAPSHOT~31e1420200
dateFormat X
axisFormat %s
section baseline
no_agent (37.592 ms) : 37290, 37894
. : milestone, 37592,
appsec (47.692 ms) : 47259, 48124
. : milestone, 47692,
code_origins (43.688 ms) : 43325, 44052
. : milestone, 43688,
iast (45.412 ms) : 45016, 45807
. : milestone, 45412,
profiling (47.505 ms) : 47078, 47932
. : milestone, 47505,
tracing (43.939 ms) : 43559, 44319
. : milestone, 43939,
section candidate
no_agent (37.111 ms) : 36814, 37407
. : milestone, 37111,
appsec (49.095 ms) : 48655, 49536
. : milestone, 49095,
code_origins (42.725 ms) : 42362, 43088
. : milestone, 42725,
iast (45.232 ms) : 44839, 45626
. : milestone, 45232,
profiling (49.416 ms) : 48949, 49882
. : milestone, 49416,
tracing (43.257 ms) : 42884, 43629
. : milestone, 43257,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~7a4077d479, baseline=1.55.0-SNAPSHOT~31e1420200
dateFormat X
axisFormat %s
section baseline
no_agent (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
appsec (15.062 s) : 15062000, 15062000
. : milestone, 15062000,
iast (18.411 s) : 18411000, 18411000
. : milestone, 18411000,
iast_GLOBAL (17.955 s) : 17955000, 17955000
. : milestone, 17955000,
profiling (15.858 s) : 15858000, 15858000
. : milestone, 15858000,
tracing (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
section candidate
no_agent (15.25 s) : 15250000, 15250000
. : milestone, 15250000,
appsec (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
iast (18.325 s) : 18325000, 18325000
. : milestone, 18325000,
iast_GLOBAL (18.231 s) : 18231000, 18231000
. : milestone, 18231000,
profiling (15.431 s) : 15431000, 15431000
. : milestone, 15431000,
tracing (15.138 s) : 15138000, 15138000
. : milestone, 15138000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~7a4077d479, baseline=1.55.0-SNAPSHOT~31e1420200
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.619 ms) : 3406, 3831
. : milestone, 3619,
iast (2.206 ms) : 2143, 2270
. : milestone, 2206,
iast_GLOBAL (2.258 ms) : 2193, 2323
. : milestone, 2258,
profiling (2.475 ms) : 2255, 2695
. : milestone, 2475,
tracing (2.029 ms) : 1979, 2080
. : milestone, 2029,
section candidate
no_agent (1.473 ms) : 1461, 1485
. : milestone, 1473,
appsec (3.686 ms) : 3469, 3902
. : milestone, 3686,
iast (2.2 ms) : 2136, 2263
. : milestone, 2200,
iast_GLOBAL (2.251 ms) : 2187, 2315
. : milestone, 2251,
profiling (2.077 ms) : 2023, 2130
. : milestone, 2077,
tracing (2.022 ms) : 1972, 2072
. : milestone, 2022,
|
What Does This Do
Remove the
ref_protected:requirement from the trust policyMotivation
The workflow that corresponds to this trust policy is triggered off of tags. I believe these tags are not considered "protected" which is causing the error
Resource not accessible by integration: https://github.com/DataDog/dd-trace-java/actions/runs/18696181534/job/53314152512Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]