-
Notifications
You must be signed in to change notification settings - Fork 314
Disambiguate normalizeTag from normalizeTagValue #9816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 15c4ed7 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~15c4ed70c9, baseline=1.55.0-SNAPSHOT~ad9b373db0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019355
Total [baseline] (8.684 s) : 0, 8684161
Agent [candidate] (1.016 s) : 0, 1016434
Total [candidate] (8.656 s) : 0, 8655693
section iast
Agent [baseline] (1.161 s) : 0, 1161222
Total [baseline] (9.322 s) : 0, 9321504
Agent [candidate] (1.155 s) : 0, 1155037
Total [candidate] (9.344 s) : 0, 9343919
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~15c4ed70c9, baseline=1.55.0-SNAPSHOT~ad9b373db0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (694.892 ms) : 0, 694892
BytebuddyAgent [candidate] (693.675 ms) : 0, 693675
GlobalTracer [baseline] (243.054 ms) : 0, 243054
GlobalTracer [candidate] (242.552 ms) : 0, 242552
AppSec [baseline] (32.428 ms) : 0, 32428
AppSec [candidate] (32.058 ms) : 0, 32058
Debugger [baseline] (6.315 ms) : 0, 6315
Debugger [candidate] (6.243 ms) : 0, 6243
Remote Config [baseline] (689.013 µs) : 0, 689
Remote Config [candidate] (671.824 µs) : 0, 672
Telemetry [baseline] (9.256 ms) : 0, 9256
Telemetry [candidate] (9.261 ms) : 0, 9261
Flare Poller [baseline] (10.136 ms) : 0, 10136
Flare Poller [candidate] (9.474 ms) : 0, 9474
section iast
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (822.765 ms) : 0, 822765
BytebuddyAgent [candidate] (817.925 ms) : 0, 817925
GlobalTracer [baseline] (233.206 ms) : 0, 233206
GlobalTracer [candidate] (232.081 ms) : 0, 232081
AppSec [baseline] (35.28 ms) : 0, 35280
AppSec [candidate] (35.449 ms) : 0, 35449
Debugger [baseline] (6.222 ms) : 0, 6222
Debugger [candidate] (6.246 ms) : 0, 6246
Remote Config [baseline] (616.904 µs) : 0, 617
Remote Config [candidate] (610.547 µs) : 0, 611
Telemetry [baseline] (8.834 ms) : 0, 8834
Telemetry [candidate] (8.852 ms) : 0, 8852
Flare Poller [baseline] (4.293 ms) : 0, 4293
Flare Poller [candidate] (4.257 ms) : 0, 4257
IAST [baseline] (26.998 ms) : 0, 26998
IAST [candidate] (26.777 ms) : 0, 26777
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~15c4ed70c9, baseline=1.55.0-SNAPSHOT~ad9b373db0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019017
Total [baseline] (10.681 s) : 0, 10680834
Agent [candidate] (1.019 s) : 0, 1018913
Total [candidate] (10.704 s) : 0, 10703941
section appsec
Agent [baseline] (1.197 s) : 0, 1197043
Total [baseline] (10.807 s) : 0, 10807140
Agent [candidate] (1.203 s) : 0, 1202565
Total [candidate] (10.869 s) : 0, 10869002
section iast
Agent [baseline] (1.152 s) : 0, 1152090
Total [baseline] (11.077 s) : 0, 11077140
Agent [candidate] (1.156 s) : 0, 1155556
Total [candidate] (11.103 s) : 0, 11103146
section profiling
Agent [baseline] (1.163 s) : 0, 1162975
Total [baseline] (10.806 s) : 0, 10805503
Agent [candidate] (1.165 s) : 0, 1164528
Total [candidate] (10.93 s) : 0, 10929903
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~15c4ed70c9, baseline=1.55.0-SNAPSHOT~ad9b373db0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (694.66 ms) : 0, 694660
BytebuddyAgent [candidate] (694.066 ms) : 0, 694066
GlobalTracer [baseline] (243.456 ms) : 0, 243456
GlobalTracer [candidate] (242.941 ms) : 0, 242941
AppSec [baseline] (32.26 ms) : 0, 32260
AppSec [candidate] (32.269 ms) : 0, 32269
Debugger [baseline] (6.274 ms) : 0, 6274
Debugger [candidate] (6.318 ms) : 0, 6318
Remote Config [baseline] (677.294 µs) : 0, 677
Remote Config [candidate] (677.597 µs) : 0, 678
Telemetry [baseline] (9.347 ms) : 0, 9347
Telemetry [candidate] (9.219 ms) : 0, 9219
Flare Poller [baseline] (9.713 ms) : 0, 9713
Flare Poller [candidate] (10.869 ms) : 0, 10869
section appsec
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (719.939 ms) : 0, 719939
BytebuddyAgent [candidate] (723.379 ms) : 0, 723379
GlobalTracer [baseline] (235.076 ms) : 0, 235076
GlobalTracer [candidate] (236.539 ms) : 0, 236539
AppSec [baseline] (175.104 ms) : 0, 175104
AppSec [candidate] (175.602 ms) : 0, 175602
Debugger [baseline] (6.061 ms) : 0, 6061
Debugger [candidate] (6.046 ms) : 0, 6046
Remote Config [baseline] (611.446 µs) : 0, 611
Remote Config [candidate] (642.643 µs) : 0, 643
Telemetry [baseline] (8.679 ms) : 0, 8679
Telemetry [candidate] (8.607 ms) : 0, 8607
Flare Poller [baseline] (3.967 ms) : 0, 3967
Flare Poller [candidate] (3.964 ms) : 0, 3964
IAST [baseline] (25.002 ms) : 0, 25002
IAST [candidate] (25.021 ms) : 0, 25021
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (815.191 ms) : 0, 815191
BytebuddyAgent [candidate] (819.517 ms) : 0, 819517
GlobalTracer [baseline] (232.228 ms) : 0, 232228
GlobalTracer [candidate] (231.497 ms) : 0, 231497
AppSec [baseline] (35.338 ms) : 0, 35338
AppSec [candidate] (35.194 ms) : 0, 35194
Debugger [baseline] (6.173 ms) : 0, 6173
Debugger [candidate] (6.133 ms) : 0, 6133
Remote Config [baseline] (611.041 µs) : 0, 611
Remote Config [candidate] (662.342 µs) : 0, 662
Telemetry [baseline] (8.713 ms) : 0, 8713
Telemetry [candidate] (8.728 ms) : 0, 8728
Flare Poller [baseline] (4.23 ms) : 0, 4230
Flare Poller [candidate] (4.254 ms) : 0, 4254
IAST [baseline] (26.685 ms) : 0, 26685
IAST [candidate] (26.61 ms) : 0, 26610
section profiling
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (719.165 ms) : 0, 719165
BytebuddyAgent [candidate] (720.793 ms) : 0, 720793
GlobalTracer [baseline] (218.71 ms) : 0, 218710
GlobalTracer [candidate] (218.686 ms) : 0, 218686
AppSec [baseline] (32.274 ms) : 0, 32274
AppSec [candidate] (32.193 ms) : 0, 32193
Debugger [baseline] (6.672 ms) : 0, 6672
Debugger [candidate] (8.206 ms) : 0, 8206
Remote Config [baseline] (708.249 µs) : 0, 708
Remote Config [candidate] (677.201 µs) : 0, 677
Telemetry [baseline] (16.004 ms) : 0, 16004
Telemetry [candidate] (13.552 ms) : 0, 13552
Flare Poller [baseline] (4.171 ms) : 0, 4171
Flare Poller [candidate] (4.844 ms) : 0, 4844
ProfilingAgent [baseline] (110.09 ms) : 0, 110090
ProfilingAgent [candidate] (110.296 ms) : 0, 110296
Profiling [baseline] (110.727 ms) : 0, 110727
Profiling [candidate] (110.944 ms) : 0, 110944
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~15c4ed70c9, baseline=1.55.0-SNAPSHOT~ad9b373db0
dateFormat X
axisFormat %s
section baseline
no_agent (4.264 ms) : 4214, 4313
. : milestone, 4264,
iast (9.432 ms) : 9276, 9589
. : milestone, 9432,
iast_FULL (13.411 ms) : 13142, 13680
. : milestone, 13411,
iast_GLOBAL (10.774 ms) : 10564, 10985
. : milestone, 10774,
profiling (8.468 ms) : 8335, 8601
. : milestone, 8468,
tracing (7.842 ms) : 7720, 7963
. : milestone, 7842,
section candidate
no_agent (4.34 ms) : 4291, 4389
. : milestone, 4340,
iast (10.165 ms) : 9993, 10337
. : milestone, 10165,
iast_FULL (13.707 ms) : 13435, 13978
. : milestone, 13707,
iast_GLOBAL (11.023 ms) : 10825, 11221
. : milestone, 11023,
profiling (8.955 ms) : 8805, 9104
. : milestone, 8955,
tracing (7.743 ms) : 7624, 7862
. : milestone, 7743,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~15c4ed70c9, baseline=1.55.0-SNAPSHOT~ad9b373db0
dateFormat X
axisFormat %s
section baseline
no_agent (36.212 ms) : 35916, 36507
. : milestone, 36212,
appsec (49.136 ms) : 48690, 49583
. : milestone, 49136,
code_origins (42.747 ms) : 42370, 43123
. : milestone, 42747,
iast (43.443 ms) : 43063, 43823
. : milestone, 43443,
profiling (48.267 ms) : 47837, 48698
. : milestone, 48267,
tracing (44.095 ms) : 43719, 44470
. : milestone, 44095,
section candidate
no_agent (36.72 ms) : 36434, 37007
. : milestone, 36720,
appsec (46.483 ms) : 46069, 46897
. : milestone, 46483,
code_origins (43.144 ms) : 42779, 43509
. : milestone, 43144,
iast (45.153 ms) : 44765, 45541
. : milestone, 45153,
profiling (47.328 ms) : 46885, 47772
. : milestone, 47328,
tracing (44.027 ms) : 43646, 44409
. : milestone, 44027,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~15c4ed70c9, baseline=1.55.0-SNAPSHOT~ad9b373db0
dateFormat X
axisFormat %s
section baseline
no_agent (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
appsec (15.153 s) : 15153000, 15153000
. : milestone, 15153000,
iast (18.65 s) : 18650000, 18650000
. : milestone, 18650000,
iast_GLOBAL (17.707 s) : 17707000, 17707000
. : milestone, 17707000,
profiling (15.062 s) : 15062000, 15062000
. : milestone, 15062000,
tracing (15.212 s) : 15212000, 15212000
. : milestone, 15212000,
section candidate
no_agent (15.657 s) : 15657000, 15657000
. : milestone, 15657000,
appsec (14.971 s) : 14971000, 14971000
. : milestone, 14971000,
iast (18.393 s) : 18393000, 18393000
. : milestone, 18393000,
iast_GLOBAL (18.1 s) : 18100000, 18100000
. : milestone, 18100000,
profiling (15.607 s) : 15607000, 15607000
. : milestone, 15607000,
tracing (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~15c4ed70c9, baseline=1.55.0-SNAPSHOT~ad9b373db0
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.648 ms) : 3434, 3861
. : milestone, 3648,
iast (2.229 ms) : 2164, 2293
. : milestone, 2229,
iast_GLOBAL (2.273 ms) : 2208, 2338
. : milestone, 2273,
profiling (2.083 ms) : 2030, 2135
. : milestone, 2083,
tracing (2.044 ms) : 1993, 2094
. : milestone, 2044,
section candidate
no_agent (1.487 ms) : 1475, 1498
. : milestone, 1487,
appsec (3.765 ms) : 3548, 3983
. : milestone, 3765,
iast (2.243 ms) : 2179, 2307
. : milestone, 2243,
iast_GLOBAL (2.271 ms) : 2207, 2336
. : milestone, 2271,
profiling (2.087 ms) : 2033, 2141
. : milestone, 2087,
tracing (2.04 ms) : 1990, 2090
. : milestone, 2040,
|
What Does This Do
This PR introduce
TraceUtils.normalizeTagValueto disambiguate fromTraceUtils.normalizeTag.The latter, in fact, applies rules that applies to the full tag (or the service name). In particular the tag cannot start with a digit.
However, when just normalising values, we'd like to allow things starting with a digit.
In particular, this fixes potential value truncated for process tags, if they are starting with a digit.
Note: it does not change anything about normalizing service name or other stuff. It only affect process tags that's ok right now.
Full tag format: https://docs.datadoghq.com/getting_started/tagging/
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]