-
Notifications
You must be signed in to change notification settings - Fork 315
Make akka-http-10.6 module optional to simplify local build.
#9767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: ae1bb6b | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~ae1bb6bb43, baseline=1.55.0-SNAPSHOT~ac157813c1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1016582
Total [baseline] (8.668 s) : 0, 8668336
Agent [candidate] (1.018 s) : 0, 1018052
Total [candidate] (8.633 s) : 0, 8633048
section iast
Agent [baseline] (1.151 s) : 0, 1151155
Total [baseline] (9.322 s) : 0, 9321542
Agent [candidate] (1.153 s) : 0, 1153286
Total [candidate] (9.297 s) : 0, 9296921
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~ae1bb6bb43, baseline=1.55.0-SNAPSHOT~ac157813c1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (692.241 ms) : 0, 692241
BytebuddyAgent [candidate] (692.537 ms) : 0, 692537
GlobalTracer [baseline] (242.785 ms) : 0, 242785
GlobalTracer [candidate] (242.699 ms) : 0, 242699
AppSec [baseline] (32.386 ms) : 0, 32386
AppSec [candidate] (32.587 ms) : 0, 32587
Debugger [baseline] (6.295 ms) : 0, 6295
Debugger [candidate] (6.406 ms) : 0, 6406
Remote Config [baseline] (682.793 µs) : 0, 683
Remote Config [candidate] (678.381 µs) : 0, 678
Telemetry [baseline] (9.328 ms) : 0, 9328
Telemetry [candidate] (9.42 ms) : 0, 9420
Flare Poller [baseline] (10.289 ms) : 0, 10289
Flare Poller [candidate] (11.148 ms) : 0, 11148
section iast
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (814.456 ms) : 0, 814456
BytebuddyAgent [candidate] (815.88 ms) : 0, 815880
GlobalTracer [baseline] (231.745 ms) : 0, 231745
GlobalTracer [candidate] (232.778 ms) : 0, 232778
IAST [baseline] (26.724 ms) : 0, 26724
IAST [candidate] (26.563 ms) : 0, 26563
AppSec [baseline] (35.522 ms) : 0, 35522
AppSec [candidate] (35.367 ms) : 0, 35367
Debugger [baseline] (6.211 ms) : 0, 6211
Debugger [candidate] (6.217 ms) : 0, 6217
Remote Config [baseline] (612.23 µs) : 0, 612
Remote Config [candidate] (602.834 µs) : 0, 603
Telemetry [baseline] (8.716 ms) : 0, 8716
Telemetry [candidate] (8.756 ms) : 0, 8756
Flare Poller [baseline] (4.248 ms) : 0, 4248
Flare Poller [candidate] (4.177 ms) : 0, 4177
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~ae1bb6bb43, baseline=1.55.0-SNAPSHOT~ac157813c1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1023659
Total [baseline] (10.616 s) : 0, 10616439
Agent [candidate] (1.019 s) : 0, 1018678
Total [candidate] (10.667 s) : 0, 10667031
section appsec
Agent [baseline] (1.202 s) : 0, 1202472
Total [baseline] (10.807 s) : 0, 10806889
Agent [candidate] (1.196 s) : 0, 1196337
Total [candidate] (10.794 s) : 0, 10794218
section iast
Agent [baseline] (1.152 s) : 0, 1151943
Total [baseline] (10.999 s) : 0, 10999347
Agent [candidate] (1.162 s) : 0, 1161856
Total [candidate] (11.191 s) : 0, 11191200
section profiling
Agent [baseline] (1.169 s) : 0, 1169238
Total [baseline] (10.823 s) : 0, 10823191
Agent [candidate] (1.164 s) : 0, 1163514
Total [candidate] (10.854 s) : 0, 10854184
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~ae1bb6bb43, baseline=1.55.0-SNAPSHOT~ac157813c1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (696.632 ms) : 0, 696632
BytebuddyAgent [candidate] (693.357 ms) : 0, 693357
GlobalTracer [baseline] (243.863 ms) : 0, 243863
GlobalTracer [candidate] (243.414 ms) : 0, 243414
AppSec [baseline] (32.376 ms) : 0, 32376
AppSec [candidate] (32.534 ms) : 0, 32534
Debugger [baseline] (6.349 ms) : 0, 6349
Debugger [candidate] (6.39 ms) : 0, 6390
Remote Config [baseline] (676.302 µs) : 0, 676
Remote Config [candidate] (681.129 µs) : 0, 681
Telemetry [baseline] (9.334 ms) : 0, 9334
Telemetry [candidate] (9.427 ms) : 0, 9427
Flare Poller [baseline] (11.741 ms) : 0, 11741
Flare Poller [candidate] (10.247 ms) : 0, 10247
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (723.166 ms) : 0, 723166
BytebuddyAgent [candidate] (718.887 ms) : 0, 718887
GlobalTracer [baseline] (236.77 ms) : 0, 236770
GlobalTracer [candidate] (235.922 ms) : 0, 235922
IAST [baseline] (25.248 ms) : 0, 25248
IAST [candidate] (24.891 ms) : 0, 24891
AppSec [baseline] (175.164 ms) : 0, 175164
AppSec [candidate] (174.84 ms) : 0, 174840
Debugger [baseline] (6.111 ms) : 0, 6111
Debugger [candidate] (6.135 ms) : 0, 6135
Remote Config [baseline] (625.25 µs) : 0, 625
Remote Config [candidate] (628.53 µs) : 0, 629
Telemetry [baseline] (8.695 ms) : 0, 8695
Telemetry [candidate] (8.541 ms) : 0, 8541
Flare Poller [baseline] (3.956 ms) : 0, 3956
Flare Poller [candidate] (3.941 ms) : 0, 3941
section iast
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (815.329 ms) : 0, 815329
BytebuddyAgent [candidate] (822.175 ms) : 0, 822175
GlobalTracer [baseline] (231.739 ms) : 0, 231739
GlobalTracer [candidate] (234.174 ms) : 0, 234174
IAST [baseline] (26.78 ms) : 0, 26780
IAST [candidate] (26.923 ms) : 0, 26923
AppSec [baseline] (35.32 ms) : 0, 35320
AppSec [candidate] (35.527 ms) : 0, 35527
Debugger [baseline] (6.188 ms) : 0, 6188
Debugger [candidate] (6.241 ms) : 0, 6241
Remote Config [baseline] (603.149 µs) : 0, 603
Remote Config [candidate] (607.085 µs) : 0, 607
Telemetry [baseline] (8.687 ms) : 0, 8687
Telemetry [candidate] (8.757 ms) : 0, 8757
Flare Poller [baseline] (4.309 ms) : 0, 4309
Flare Poller [candidate] (4.373 ms) : 0, 4373
section profiling
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (722.84 ms) : 0, 722840
BytebuddyAgent [candidate] (721.955 ms) : 0, 721955
GlobalTracer [baseline] (219.834 ms) : 0, 219834
GlobalTracer [candidate] (218.736 ms) : 0, 218736
AppSec [baseline] (32.518 ms) : 0, 32518
AppSec [candidate] (32.285 ms) : 0, 32285
Debugger [baseline] (6.757 ms) : 0, 6757
Debugger [candidate] (7.448 ms) : 0, 7448
Remote Config [baseline] (713.143 µs) : 0, 713
Remote Config [candidate] (712.413 µs) : 0, 712
Telemetry [baseline] (15.354 ms) : 0, 15354
Telemetry [candidate] (15.179 ms) : 0, 15179
Flare Poller [baseline] (5.005 ms) : 0, 5005
Flare Poller [candidate] (4.103 ms) : 0, 4103
ProfilingAgent [baseline] (110.494 ms) : 0, 110494
ProfilingAgent [candidate] (107.639 ms) : 0, 107639
Profiling [baseline] (111.144 ms) : 0, 111144
Profiling [candidate] (109.555 ms) : 0, 109555
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~ae1bb6bb43, baseline=1.55.0-SNAPSHOT~ac157813c1
dateFormat X
axisFormat %s
section baseline
no_agent (4.241 ms) : 4187, 4294
. : milestone, 4241,
iast (9.676 ms) : 9514, 9839
. : milestone, 9676,
iast_FULL (14.2 ms) : 13920, 14480
. : milestone, 14200,
iast_GLOBAL (11.064 ms) : 10866, 11262
. : milestone, 11064,
profiling (9.277 ms) : 9133, 9421
. : milestone, 9277,
tracing (8.18 ms) : 8060, 8299
. : milestone, 8180,
section candidate
no_agent (4.327 ms) : 4274, 4379
. : milestone, 4327,
iast (9.785 ms) : 9624, 9947
. : milestone, 9785,
iast_FULL (14.383 ms) : 14101, 14666
. : milestone, 14383,
iast_GLOBAL (10.48 ms) : 10286, 10674
. : milestone, 10480,
profiling (8.695 ms) : 8557, 8832
. : milestone, 8695,
tracing (8.17 ms) : 8052, 8288
. : milestone, 8170,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~ae1bb6bb43, baseline=1.55.0-SNAPSHOT~ac157813c1
dateFormat X
axisFormat %s
section baseline
no_agent (36.566 ms) : 36275, 36857
. : milestone, 36566,
appsec (47.872 ms) : 47455, 48288
. : milestone, 47872,
code_origins (42.63 ms) : 42260, 43000
. : milestone, 42630,
iast (45.55 ms) : 45161, 45939
. : milestone, 45550,
profiling (50.959 ms) : 50491, 51427
. : milestone, 50959,
tracing (44.019 ms) : 43642, 44396
. : milestone, 44019,
section candidate
no_agent (37.882 ms) : 37578, 38185
. : milestone, 37882,
appsec (47.113 ms) : 46681, 47544
. : milestone, 47113,
code_origins (42.932 ms) : 42564, 43300
. : milestone, 42932,
iast (45.519 ms) : 45114, 45925
. : milestone, 45519,
profiling (49.53 ms) : 49073, 49986
. : milestone, 49530,
tracing (43.555 ms) : 43197, 43913
. : milestone, 43555,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~ae1bb6bb43, baseline=1.55.0-SNAPSHOT~ac157813c1
dateFormat X
axisFormat %s
section baseline
no_agent (15.563 s) : 15563000, 15563000
. : milestone, 15563000,
appsec (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
iast (18.379 s) : 18379000, 18379000
. : milestone, 18379000,
iast_GLOBAL (18.137 s) : 18137000, 18137000
. : milestone, 18137000,
profiling (15.049 s) : 15049000, 15049000
. : milestone, 15049000,
tracing (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
section candidate
no_agent (15.289 s) : 15289000, 15289000
. : milestone, 15289000,
appsec (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
iast (18.453 s) : 18453000, 18453000
. : milestone, 18453000,
iast_GLOBAL (18.055 s) : 18055000, 18055000
. : milestone, 18055000,
profiling (15.331 s) : 15331000, 15331000
. : milestone, 15331000,
tracing (15.183 s) : 15183000, 15183000
. : milestone, 15183000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~ae1bb6bb43, baseline=1.55.0-SNAPSHOT~ac157813c1
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.688 ms) : 3473, 3904
. : milestone, 3688,
iast (2.21 ms) : 2147, 2274
. : milestone, 2210,
iast_GLOBAL (2.265 ms) : 2200, 2330
. : milestone, 2265,
profiling (2.048 ms) : 1996, 2099
. : milestone, 2048,
tracing (2.025 ms) : 1975, 2075
. : milestone, 2025,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.719 ms) : 3501, 3937
. : milestone, 3719,
iast (2.206 ms) : 2142, 2270
. : milestone, 2206,
iast_GLOBAL (2.24 ms) : 2176, 2304
. : milestone, 2240,
profiling (2.067 ms) : 2015, 2120
. : milestone, 2067,
tracing (2.02 ms) : 1971, 2070
. : milestone, 2020,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 praise: Thanks for improving OOTB experience 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks for this ! Just requiring a small change to access the property.
What Does This Do
Make
akka-http-10.6module optional to simplify local build.Motivation
Improved developer experience during local build.
Making Akka token optional will simplify setup for local build.
Those who need this module can do one more extra step.
Additional Notes
For background on why Akka now requires authentication, see this article.