Skip to content

🍒 9334 - Properly handle trace agent IPv6 URL in profiling #9339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

🍒 9334 - Properly handle trace agent IPv6 URL in profiling #9339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal-api/src/main/java/datadog/trace/api/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4746,7 +4746,7 @@ public String getFinalProfilingUrl() {
return "https://intake.profile." + site + "/api/v2/profile";
} else {
// when profilingUrl and agentless are not set we send to the dd trace agent running locally
return "http://" + agentHost + ":" + agentPort + "/profiling/v1/input";
return getAgentUrl() + "/profiling/v1/input";
}
}

Expand Down
13 changes: 13 additions & 0 deletions internal-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1652,6 +1652,19 @@ class ConfigTest extends DDSpecification {
config.getFinalProfilingUrl() == "https://some.new.url/goes/here"
}

def "ipv6 profiling url"() {
setup:
def configuredUrl = "http://[2600:1f14:1cfc:5f07::38d4]:8126"
def props = new Properties()
props.setProperty(TRACE_AGENT_URL, configuredUrl)

when:
Config config = Config.get(props)

then:
config.getFinalProfilingUrl() == configuredUrl + "/profiling/v1/input"
}

def "fallback to DD_TAGS"() {
setup:
environmentVariables.set(DD_TAGS_ENV, "a:1,b:2,c:3")
Expand Down