- 
                Notifications
    
You must be signed in to change notification settings  - Fork 315
 
          Allow testJvm property to receive paths
          #9332
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
testJvm property to have pathstestJvm property to receive paths
      | 
           Code coverage: total 57.25%, base diff 0.01%, patch 100.00% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: 468245a | Docs | Was this helpful? Give us feedback!  | 
    
          BenchmarksStartupParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~468245a3af, baseline=1.53.0-SNAPSHOT~ea85e017e4
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056748
Total [baseline] (8.6 s) : 0, 8599777
Agent [candidate] (1.051 s) : 0, 1051412
Total [candidate] (8.628 s) : 0, 8628409
section iast
Agent [baseline] (1.179 s) : 0, 1179322
Total [baseline] (9.303 s) : 0, 9303090
Agent [candidate] (1.178 s) : 0, 1178155
Total [candidate] (9.277 s) : 0, 9276702
    
 
 
 
 gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~468245a3af, baseline=1.53.0-SNAPSHOT~ea85e017e4
    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (737.359 ms) : 0, 737359
BytebuddyAgent [candidate] (735.555 ms) : 0, 735555
GlobalTracer [baseline] (244.77 ms) : 0, 244770
GlobalTracer [candidate] (242.954 ms) : 0, 242954
AppSec [baseline] (30.617 ms) : 0, 30617
AppSec [candidate] (30.224 ms) : 0, 30224
Debugger [baseline] (6.134 ms) : 0, 6134
Debugger [candidate] (6.027 ms) : 0, 6027
Remote Config [baseline] (662.836 µs) : 0, 663
Remote Config [candidate] (657.737 µs) : 0, 658
Telemetry [baseline] (14.559 ms) : 0, 14559
Telemetry [candidate] (13.505 ms) : 0, 13505
section iast
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (850.95 ms) : 0, 850950
BytebuddyAgent [candidate] (850.736 ms) : 0, 850736
GlobalTracer [baseline] (233.391 ms) : 0, 233391
GlobalTracer [candidate] (233.216 ms) : 0, 233216
IAST [baseline] (26.812 ms) : 0, 26812
IAST [candidate] (29.172 ms) : 0, 29172
AppSec [baseline] (26.849 ms) : 0, 26849
AppSec [candidate] (27.912 ms) : 0, 27912
Debugger [baseline] (9.977 ms) : 0, 9977
Debugger [candidate] (5.727 ms) : 0, 5727
Remote Config [baseline] (576.932 µs) : 0, 577
Remote Config [candidate] (578.889 µs) : 0, 579
Telemetry [baseline] (8.243 ms) : 0, 8243
Telemetry [candidate] (8.43 ms) : 0, 8430
    Startup time reports for petclinicgantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~468245a3af, baseline=1.53.0-SNAPSHOT~ea85e017e4
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044567
Total [baseline] (10.739 s) : 0, 10739492
Agent [candidate] (1.053 s) : 0, 1053067
Total [candidate] (10.749 s) : 0, 10749416
section appsec
Agent [baseline] (1.22 s) : 0, 1219885
Total [baseline] (10.734 s) : 0, 10733541
Agent [candidate] (1.221 s) : 0, 1220982
Total [candidate] (10.785 s) : 0, 10784893
section iast
Agent [baseline] (1.173 s) : 0, 1172758
Total [baseline] (10.947 s) : 0, 10946669
Agent [candidate] (1.189 s) : 0, 1188819
Total [candidate] (10.996 s) : 0, 10995596
section profiling
Agent [baseline] (1.192 s) : 0, 1192170
Total [baseline] (10.835 s) : 0, 10834599
Agent [candidate] (1.192 s) : 0, 1192045
Total [candidate] (10.822 s) : 0, 10821506
    
 
 
 
 gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~468245a3af, baseline=1.53.0-SNAPSHOT~ea85e017e4
    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (730.36 ms) : 0, 730360
BytebuddyAgent [candidate] (737.069 ms) : 0, 737069
GlobalTracer [baseline] (242.208 ms) : 0, 242208
GlobalTracer [candidate] (243.579 ms) : 0, 243579
AppSec [baseline] (29.926 ms) : 0, 29926
AppSec [candidate] (30.33 ms) : 0, 30330
Debugger [baseline] (6.011 ms) : 0, 6011
Debugger [candidate] (6.059 ms) : 0, 6059
Remote Config [baseline] (649.614 µs) : 0, 650
Remote Config [candidate] (641.544 µs) : 0, 642
Telemetry [baseline] (12.895 ms) : 0, 12895
Telemetry [candidate] (12.738 ms) : 0, 12738
section appsec
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (752.642 ms) : 0, 752642
BytebuddyAgent [candidate] (753.616 ms) : 0, 753616
GlobalTracer [baseline] (235.055 ms) : 0, 235055
GlobalTracer [candidate] (235.282 ms) : 0, 235282
AppSec [baseline] (169.822 ms) : 0, 169822
AppSec [candidate] (168.322 ms) : 0, 168322
Debugger [baseline] (6.497 ms) : 0, 6497
Debugger [candidate] (7.923 ms) : 0, 7923
Remote Config [baseline] (633.238 µs) : 0, 633
Remote Config [candidate] (615.84 µs) : 0, 616
Telemetry [baseline] (9.15 ms) : 0, 9150
Telemetry [candidate] (9.099 ms) : 0, 9099
IAST [baseline] (23.647 ms) : 0, 23647
IAST [candidate] (23.582 ms) : 0, 23582
section iast
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (846.617 ms) : 0, 846617
BytebuddyAgent [candidate] (858.32 ms) : 0, 858320
GlobalTracer [baseline] (233.585 ms) : 0, 233585
GlobalTracer [candidate] (234.469 ms) : 0, 234469
AppSec [baseline] (27.342 ms) : 0, 27342
AppSec [candidate] (25.694 ms) : 0, 25694
Debugger [baseline] (6.529 ms) : 0, 6529
Debugger [candidate] (7.439 ms) : 0, 7439
Remote Config [baseline] (575.368 µs) : 0, 575
Remote Config [candidate] (612.739 µs) : 0, 613
Telemetry [baseline] (8.244 ms) : 0, 8244
Telemetry [candidate] (9.298 ms) : 0, 9298
IAST [baseline] (27.365 ms) : 0, 27365
IAST [candidate] (30.342 ms) : 0, 30342
section profiling
ProfilingAgent [baseline] (108.003 ms) : 0, 108003
ProfilingAgent [candidate] (107.61 ms) : 0, 107610
crashtracking [baseline] (1.396 ms) : 0, 1396
crashtracking [candidate] (1.399 ms) : 0, 1399
BytebuddyAgent [baseline] (759.881 ms) : 0, 759881
BytebuddyAgent [candidate] (759.449 ms) : 0, 759449
GlobalTracer [baseline] (221.606 ms) : 0, 221606
GlobalTracer [candidate] (221.494 ms) : 0, 221494
AppSec [baseline] (29.791 ms) : 0, 29791
AppSec [candidate] (29.792 ms) : 0, 29792
Debugger [baseline] (6.203 ms) : 0, 6203
Debugger [candidate] (6.255 ms) : 0, 6255
Remote Config [baseline] (682.094 µs) : 0, 682
Remote Config [candidate] (680.807 µs) : 0, 681
Telemetry [baseline] (15.157 ms) : 0, 15157
Telemetry [candidate] (15.866 ms) : 0, 15866
Profiling [baseline] (108.622 ms) : 0, 108622
Profiling [candidate] (108.254 ms) : 0, 108254
    LoadParameters
 See matching parameters
 SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics. 
 Request duration reports for insecure-bankgantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~468245a3af, baseline=1.53.0-SNAPSHOT~ea85e017e4
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.324 ms) : 4276, 4373
.   : milestone, 4324,
iast (9.401 ms) : 9244, 9557
.   : milestone, 9401,
iast_FULL (13.853 ms) : 13580, 14125
.   : milestone, 13853,
iast_GLOBAL (9.985 ms) : 9809, 10161
.   : milestone, 9985,
profiling (8.498 ms) : 8362, 8634
.   : milestone, 8498,
tracing (7.619 ms) : 7506, 7731
.   : milestone, 7619,
section candidate
no_agent (4.34 ms) : 4289, 4391
.   : milestone, 4340,
iast (9.224 ms) : 9072, 9375
.   : milestone, 9224,
iast_FULL (13.592 ms) : 13319, 13866
.   : milestone, 13592,
iast_GLOBAL (10.384 ms) : 10202, 10566
.   : milestone, 10384,
profiling (8.566 ms) : 8427, 8705
.   : milestone, 8566,
tracing (7.275 ms) : 7167, 7384
.   : milestone, 7275,
    
 
 
 
 Request duration reports for petclinicgantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~468245a3af, baseline=1.53.0-SNAPSHOT~ea85e017e4
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.679 ms) : 37361, 37998
.   : milestone, 37679,
appsec (46.401 ms) : 45981, 46821
.   : milestone, 46401,
code_origins (44.874 ms) : 44481, 45267
.   : milestone, 44874,
iast (45.445 ms) : 45046, 45844
.   : milestone, 45445,
profiling (48.292 ms) : 47849, 48736
.   : milestone, 48292,
tracing (43.53 ms) : 43157, 43904
.   : milestone, 43530,
section candidate
no_agent (36.13 ms) : 35841, 36418
.   : milestone, 36130,
appsec (46.777 ms) : 46353, 47202
.   : milestone, 46777,
code_origins (44.732 ms) : 44344, 45120
.   : milestone, 44732,
iast (44.852 ms) : 44465, 45239
.   : milestone, 44852,
profiling (46.915 ms) : 46470, 47361
.   : milestone, 46915,
tracing (43.326 ms) : 42961, 43690
.   : milestone, 43326,
    
 
 
 
 DacapoParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~468245a3af, baseline=1.53.0-SNAPSHOT~ea85e017e4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (3.664 ms) : 3447, 3881
.   : milestone, 3664,
iast (2.203 ms) : 2141, 2266
.   : milestone, 2203,
iast_GLOBAL (2.237 ms) : 2173, 2300
.   : milestone, 2237,
profiling (2.054 ms) : 2003, 2106
.   : milestone, 2054,
tracing (2.004 ms) : 1956, 2053
.   : milestone, 2004,
section candidate
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (3.644 ms) : 3426, 3863
.   : milestone, 3644,
iast (2.201 ms) : 2139, 2264
.   : milestone, 2201,
iast_GLOBAL (2.245 ms) : 2182, 2308
.   : milestone, 2245,
profiling (2.059 ms) : 2008, 2111
.   : milestone, 2059,
tracing (2.021 ms) : 1972, 2070
.   : milestone, 2021,
    
 
 
 
 Execution time for biojavagantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~468245a3af, baseline=1.53.0-SNAPSHOT~ea85e017e4
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.006 s) : 15006000, 15006000
.   : milestone, 15006000,
appsec (14.738 s) : 14738000, 14738000
.   : milestone, 14738000,
iast (18.334 s) : 18334000, 18334000
.   : milestone, 18334000,
iast_GLOBAL (17.957 s) : 17957000, 17957000
.   : milestone, 17957000,
profiling (15.418 s) : 15418000, 15418000
.   : milestone, 15418000,
tracing (14.805 s) : 14805000, 14805000
.   : milestone, 14805000,
section candidate
no_agent (15.487 s) : 15487000, 15487000
.   : milestone, 15487000,
appsec (14.917 s) : 14917000, 14917000
.   : milestone, 14917000,
iast (18.333 s) : 18333000, 18333000
.   : milestone, 18333000,
iast_GLOBAL (18.021 s) : 18021000, 18021000
.   : milestone, 18021000,
profiling (15.72 s) : 15720000, 15720000
.   : milestone, 15720000,
tracing (15.147 s) : 15147000, 15147000
.   : milestone, 15147000,
    
 
 
 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ question: Dump question but should not we try to stick to the Gradle discovery and provisioning capabilities rather than adding another custom mechanism?
| 
           @PerfectSlayer In this case not really because the goal is to use a very specific JVM install. Ultimately, I agree that the whole feature should be refactored to rely on Gradle discovery mechanism, but that's a different beast.  | 
    
What Does This Do
Allow
testJvmproperty to have paths.Motivation
Locally this allows to easily use a different JVM from the IDE, without having to set-up an environment variable before. In practice this allows to use either
-PtestJvm=JAVAMY_JVM_HOMEor-PtestJvm=/path/to-/my-jvmAdditional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]