-
Notifications
You must be signed in to change notification settings - Fork 315
Update GHA workflows to avoid creating PRs if no changes to commit #9317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code coverage: total 57.22%, patch 100.00% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: fa2342b | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~fa2342b6a1, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042277
Total [baseline] (10.721 s) : 0, 10720898
Agent [candidate] (1.061 s) : 0, 1060884
Total [candidate] (10.792 s) : 0, 10791566
section appsec
Agent [baseline] (1.218 s) : 0, 1218133
Total [baseline] (10.789 s) : 0, 10789434
Agent [candidate] (1.222 s) : 0, 1222166
Total [candidate] (10.84 s) : 0, 10839913
section iast
Agent [baseline] (1.173 s) : 0, 1172841
Total [baseline] (10.925 s) : 0, 10924915
Agent [candidate] (1.183 s) : 0, 1182790
Total [candidate] (10.914 s) : 0, 10914245
section profiling
Agent [baseline] (1.208 s) : 0, 1208311
Total [baseline] (10.981 s) : 0, 10981391
Agent [candidate] (1.196 s) : 0, 1195861
Total [candidate] (10.875 s) : 0, 10874663
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~fa2342b6a1, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.415 ms) : 0, 1415
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (730.659 ms) : 0, 730659
BytebuddyAgent [candidate] (744.161 ms) : 0, 744161
GlobalTracer [baseline] (241.485 ms) : 0, 241485
GlobalTracer [candidate] (245.758 ms) : 0, 245758
AppSec [baseline] (29.934 ms) : 0, 29934
AppSec [candidate] (30.829 ms) : 0, 30829
Debugger [baseline] (5.988 ms) : 0, 5988
Debugger [candidate] (6.114 ms) : 0, 6114
Remote Config [baseline] (642.411 µs) : 0, 642
Remote Config [candidate] (662.716 µs) : 0, 663
Telemetry [baseline] (10.516 ms) : 0, 10516
Telemetry [candidate] (10.718 ms) : 0, 10718
section appsec
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (751.951 ms) : 0, 751951
BytebuddyAgent [candidate] (755.291 ms) : 0, 755291
GlobalTracer [baseline] (234.646 ms) : 0, 234646
GlobalTracer [candidate] (235.244 ms) : 0, 235244
IAST [baseline] (23.687 ms) : 0, 23687
IAST [candidate] (23.622 ms) : 0, 23622
AppSec [baseline] (166.546 ms) : 0, 166546
AppSec [candidate] (167.334 ms) : 0, 167334
Debugger [baseline] (10.051 ms) : 0, 10051
Debugger [candidate] (7.778 ms) : 0, 7778
Remote Config [baseline] (604.321 µs) : 0, 604
Remote Config [candidate] (614.225 µs) : 0, 614
Telemetry [baseline] (8.243 ms) : 0, 8243
Telemetry [candidate] (9.793 ms) : 0, 9793
section iast
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (846.79 ms) : 0, 846790
BytebuddyAgent [candidate] (854.996 ms) : 0, 854996
GlobalTracer [baseline] (231.16 ms) : 0, 231160
GlobalTracer [candidate] (232.776 ms) : 0, 232776
IAST [baseline] (27.383 ms) : 0, 27383
IAST [candidate] (31.694 ms) : 0, 31694
AppSec [baseline] (28.779 ms) : 0, 28779
AppSec [candidate] (26.228 ms) : 0, 26228
Debugger [baseline] (7.536 ms) : 0, 7536
Debugger [candidate] (5.873 ms) : 0, 5873
Remote Config [baseline] (592.919 µs) : 0, 593
Remote Config [candidate] (621.876 µs) : 0, 622
Telemetry [baseline] (8.236 ms) : 0, 8236
Telemetry [candidate] (8.157 ms) : 0, 8157
section profiling
crashtracking [baseline] (1.419 ms) : 0, 1419
crashtracking [candidate] (1.395 ms) : 0, 1395
BytebuddyAgent [baseline] (770.917 ms) : 0, 770917
BytebuddyAgent [candidate] (761.89 ms) : 0, 761890
GlobalTracer [baseline] (223.574 ms) : 0, 223574
GlobalTracer [candidate] (222.508 ms) : 0, 222508
AppSec [baseline] (30.433 ms) : 0, 30433
AppSec [candidate] (29.994 ms) : 0, 29994
Debugger [baseline] (6.329 ms) : 0, 6329
Debugger [candidate] (6.316 ms) : 0, 6316
Remote Config [baseline] (680.102 µs) : 0, 680
Remote Config [candidate] (672.272 µs) : 0, 672
Telemetry [baseline] (15.82 ms) : 0, 15820
Telemetry [candidate] (15.903 ms) : 0, 15903
ProfilingAgent [baseline] (109.244 ms) : 0, 109244
ProfilingAgent [candidate] (107.806 ms) : 0, 107806
Profiling [baseline] (109.907 ms) : 0, 109907
Profiling [candidate] (108.483 ms) : 0, 108483
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~fa2342b6a1, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040518
Total [baseline] (8.597 s) : 0, 8596566
Agent [candidate] (1.047 s) : 0, 1046687
Total [candidate] (8.605 s) : 0, 8605241
section iast
Agent [baseline] (1.172 s) : 0, 1172399
Total [baseline] (9.29 s) : 0, 9290131
Agent [candidate] (1.175 s) : 0, 1175366
Total [candidate] (9.281 s) : 0, 9280787
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~fa2342b6a1, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.423 ms) : 0, 1423
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (730.128 ms) : 0, 730128
BytebuddyAgent [candidate] (731.821 ms) : 0, 731821
GlobalTracer [baseline] (241.56 ms) : 0, 241560
GlobalTracer [candidate] (241.837 ms) : 0, 241837
AppSec [baseline] (29.988 ms) : 0, 29988
AppSec [candidate] (29.845 ms) : 0, 29845
Debugger [baseline] (6.032 ms) : 0, 6032
Debugger [candidate] (6.015 ms) : 0, 6015
Remote Config [baseline] (641.95 µs) : 0, 642
Remote Config [candidate] (660.43 µs) : 0, 660
Telemetry [baseline] (9.828 ms) : 0, 9828
Telemetry [candidate] (14.168 ms) : 0, 14168
section iast
crashtracking [baseline] (1.422 ms) : 0, 1422
crashtracking [candidate] (1.422 ms) : 0, 1422
BytebuddyAgent [baseline] (847.132 ms) : 0, 847132
BytebuddyAgent [candidate] (848.896 ms) : 0, 848896
GlobalTracer [baseline] (231.231 ms) : 0, 231231
GlobalTracer [candidate] (232.045 ms) : 0, 232045
IAST [baseline] (30.315 ms) : 0, 30315
IAST [candidate] (32.34 ms) : 0, 32340
AppSec [baseline] (26.173 ms) : 0, 26173
AppSec [candidate] (25.122 ms) : 0, 25122
Debugger [baseline] (6.665 ms) : 0, 6665
Debugger [candidate] (5.847 ms) : 0, 5847
Remote Config [baseline] (577.822 µs) : 0, 578
Remote Config [candidate] (602.616 µs) : 0, 603
Telemetry [baseline] (8.012 ms) : 0, 8012
Telemetry [candidate] (8.08 ms) : 0, 8080
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~fa2342b6a1, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section baseline
no_agent (36.493 ms) : 36209, 36778
. : milestone, 36493,
appsec (46.618 ms) : 46194, 47043
. : milestone, 46618,
code_origins (45.043 ms) : 44645, 45441
. : milestone, 45043,
iast (44.711 ms) : 44310, 45113
. : milestone, 44711,
profiling (47.89 ms) : 47446, 48334
. : milestone, 47890,
tracing (43.914 ms) : 43556, 44273
. : milestone, 43914,
section candidate
no_agent (37.101 ms) : 36810, 37393
. : milestone, 37101,
appsec (46.917 ms) : 46489, 47345
. : milestone, 46917,
code_origins (44.615 ms) : 44223, 45006
. : milestone, 44615,
iast (45.176 ms) : 44785, 45566
. : milestone, 45176,
profiling (49.239 ms) : 48778, 49700
. : milestone, 49239,
tracing (42.868 ms) : 42501, 43234
. : milestone, 42868,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~fa2342b6a1, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section baseline
no_agent (4.316 ms) : 4268, 4365
. : milestone, 4316,
iast (9.744 ms) : 9584, 9904
. : milestone, 9744,
iast_FULL (14.099 ms) : 13821, 14376
. : milestone, 14099,
iast_GLOBAL (9.974 ms) : 9798, 10150
. : milestone, 9974,
profiling (9.145 ms) : 8998, 9292
. : milestone, 9145,
tracing (7.638 ms) : 7530, 7746
. : milestone, 7638,
section candidate
no_agent (4.334 ms) : 4286, 4382
. : milestone, 4334,
iast (9.637 ms) : 9477, 9798
. : milestone, 9637,
iast_FULL (13.958 ms) : 13680, 14237
. : milestone, 13958,
iast_GLOBAL (10.56 ms) : 10360, 10760
. : milestone, 10560,
profiling (8.68 ms) : 8546, 8815
. : milestone, 8680,
tracing (7.57 ms) : 7465, 7674
. : milestone, 7570,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~fa2342b6a1, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.62 ms) : 3409, 3831
. : milestone, 3620,
iast (2.2 ms) : 2137, 2262
. : milestone, 2200,
iast_GLOBAL (2.241 ms) : 2178, 2304
. : milestone, 2241,
profiling (2.505 ms) : 2335, 2676
. : milestone, 2505,
tracing (2.02 ms) : 1971, 2069
. : milestone, 2020,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.652 ms) : 3434, 3870
. : milestone, 3652,
iast (2.211 ms) : 2148, 2274
. : milestone, 2211,
iast_GLOBAL (2.251 ms) : 2188, 2314
. : milestone, 2251,
profiling (2.046 ms) : 1996, 2097
. : milestone, 2046,
tracing (2.028 ms) : 1979, 2077
. : milestone, 2028,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~fa2342b6a1, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section baseline
no_agent (14.803 s) : 14803000, 14803000
. : milestone, 14803000,
appsec (14.731 s) : 14731000, 14731000
. : milestone, 14731000,
iast (18.91 s) : 18910000, 18910000
. : milestone, 18910000,
iast_GLOBAL (17.936 s) : 17936000, 17936000
. : milestone, 17936000,
profiling (15.833 s) : 15833000, 15833000
. : milestone, 15833000,
tracing (15.166 s) : 15166000, 15166000
. : milestone, 15166000,
section candidate
no_agent (15.55 s) : 15550000, 15550000
. : milestone, 15550000,
appsec (14.821 s) : 14821000, 14821000
. : milestone, 14821000,
iast (18.461 s) : 18461000, 18461000
. : milestone, 18461000,
iast_GLOBAL (18.025 s) : 18025000, 18025000
. : milestone, 18025000,
profiling (15.221 s) : 15221000, 15221000
. : milestone, 15221000,
tracing (14.885 s) : 14885000, 14885000
. : milestone, 14885000,
|
What Does This Do
Following @AlexeyKuznetsov-DD 's recommendation in #9305, this PR updates the
update-docker-build-imageandupdate-jmxfetch-submoduleworkflows such that they only create PRs if there are changes to commit.Motivation
The
update-docker-build-imagecreated a PR with no changes: #9305The
update-jmxfetch-submodulefailed to create a PR because there were no commits made: https://github.com/DataDog/dd-trace-java/actions/runs/16737254881/job/47378527957Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]