Skip to content

Switch profile compression to zstd default #9293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

Switch profile compression to zstd default #9293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions dd-trace-api/src/main/java/datadog/trace/api/config/ProfilingConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,6 @@ public final class ProfilingConfig {
*/
@Deprecated
public static final String PROFILING_UPLOAD_COMPRESSION = "profiling.upload.compression";
/**
* Default compression value. Supported values are: - "on": equivalent to "lz4", will later be
* "zstd" - "off": disables compression - "lz4": uses LZ4 compression (fast with moderate
* compression ratio) - "gzip": uses GZIP compression (higher compression ratio but slower) -
* "zstd": uses ZSTD compression (high compression ratio with reasonable performance)
*/
public static final String PROFILING_DEBUG_UPLOAD_COMPRESSION_DEFAULT = "lz4";

public static final String PROFILING_PROXY_HOST = "profiling.proxy.host";
public static final String PROFILING_PROXY_PORT = "profiling.proxy.port";
Expand Down Expand Up @@ -204,15 +197,23 @@ public final class ProfilingConfig {

public static final String PROFILING_DEBUG_DUMP_PATH = "profiling.debug.dump_path";
public static final String PROFILING_DEBUG_JFR_DISABLED = "profiling.debug.jfr.disabled";
// spotless:off
/**
* Configuration for profile upload compression. Supported values are: - "on": equivalent to "lz4"
* - "off": disables compression - "lz4": uses LZ4 compression (fast with moderate compression
* ratio) - "gzip": uses GZIP compression (higher compression ratio but slower) - "zstd": uses
* ZSTD compression (high compression ratio with reasonable performance)
* Configuration for profile upload compression.<br><br> Supported values are:
* <ul>
* <li><b>on</b>: equivalent to <b>zstd</b></li>
* <li><b>off</b>: disables compression</li>
* <li><b>lz4</b>: uses LZ4 compression (fast with moderate compression ratio)</li>
* <li><b>gzip</b>: uses GZIP compression (higher compression ratio but slower)</li>
* <li><b>zstd</b>: uses ZSTD compression (high compression ratio with reasonable performance)</li>
* </ul>
*/
// spotless:on
public static final String PROFILING_DEBUG_UPLOAD_COMPRESSION =
"profiling.debug.upload.compression";

public static final String PROFILING_DEBUG_UPLOAD_COMPRESSION_DEFAULT = "zstd";

public static final String PROFILING_CONTEXT_ATTRIBUTES = "profiling.context.attributes";

public static final String PROFILING_CONTEXT_ATTRIBUTES_SPAN_NAME_ENABLED =
Expand Down