-
Notifications
You must be signed in to change notification settings - Fork 315
Fix notify-slo-breaches interaction with POPULATE_CACHE #9247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyKuznetsov-DD
approved these changes
Jul 25, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~bb32861554, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041901
Total [baseline] (10.791 s) : 0, 10791177
Agent [candidate] (1.044 s) : 0, 1043787
Total [candidate] (10.754 s) : 0, 10754408
section appsec
Agent [baseline] (1.23 s) : 0, 1230152
Total [baseline] (10.833 s) : 0, 10832848
Agent [candidate] (1.219 s) : 0, 1219083
Total [candidate] (10.759 s) : 0, 10758776
section iast
Agent [baseline] (1.181 s) : 0, 1180591
Total [baseline] (10.863 s) : 0, 10862898
Agent [candidate] (1.175 s) : 0, 1175355
Total [candidate] (10.919 s) : 0, 10918867
section profiling
Agent [baseline] (1.198 s) : 0, 1198034
Total [baseline] (10.887 s) : 0, 10887151
Agent [candidate] (1.192 s) : 0, 1191977
Total [candidate] (10.952 s) : 0, 10951829
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~bb32861554, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (731.016 ms) : 0, 731016
BytebuddyAgent [candidate] (730.044 ms) : 0, 730044
GlobalTracer [baseline] (241.706 ms) : 0, 241706
GlobalTracer [candidate] (242.156 ms) : 0, 242156
AppSec [baseline] (30.277 ms) : 0, 30277
AppSec [candidate] (30.527 ms) : 0, 30527
Debugger [baseline] (6.06 ms) : 0, 6060
Debugger [candidate] (6.048 ms) : 0, 6048
Remote Config [baseline] (644.153 µs) : 0, 644
Remote Config [candidate] (644.099 µs) : 0, 644
Telemetry [baseline] (9.765 ms) : 0, 9765
Telemetry [candidate] (11.873 ms) : 0, 11873
section appsec
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (759.797 ms) : 0, 759797
BytebuddyAgent [candidate] (751.684 ms) : 0, 751684
GlobalTracer [baseline] (237.174 ms) : 0, 237174
GlobalTracer [candidate] (235.092 ms) : 0, 235092
AppSec [baseline] (170.975 ms) : 0, 170975
AppSec [candidate] (168.977 ms) : 0, 168977
Debugger [baseline] (5.717 ms) : 0, 5717
Debugger [candidate] (7.172 ms) : 0, 7172
Remote Config [baseline] (618.394 µs) : 0, 618
Remote Config [candidate] (617.077 µs) : 0, 617
Telemetry [baseline] (9.049 ms) : 0, 9049
Telemetry [candidate] (9.086 ms) : 0, 9086
IAST [baseline] (23.873 ms) : 0, 23873
IAST [candidate] (23.639 ms) : 0, 23639
section iast
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (853.064 ms) : 0, 853064
BytebuddyAgent [candidate] (848.105 ms) : 0, 848105
GlobalTracer [baseline] (233.073 ms) : 0, 233073
GlobalTracer [candidate] (232.207 ms) : 0, 232207
AppSec [baseline] (28.262 ms) : 0, 28262
AppSec [candidate] (28.093 ms) : 0, 28093
Debugger [baseline] (7.541 ms) : 0, 7541
Debugger [candidate] (7.481 ms) : 0, 7481
Remote Config [baseline] (587.725 µs) : 0, 588
Remote Config [candidate] (594.512 µs) : 0, 595
Telemetry [baseline] (8.119 ms) : 0, 8119
Telemetry [candidate] (8.145 ms) : 0, 8145
IAST [baseline] (27.418 ms) : 0, 27418
IAST [candidate] (28.222 ms) : 0, 28222
section profiling
crashtracking [baseline] (1.404 ms) : 0, 1404
crashtracking [candidate] (1.395 ms) : 0, 1395
BytebuddyAgent [baseline] (763.922 ms) : 0, 763922
BytebuddyAgent [candidate] (759.368 ms) : 0, 759368
GlobalTracer [baseline] (222.353 ms) : 0, 222353
GlobalTracer [candidate] (220.414 ms) : 0, 220414
AppSec [baseline] (30.596 ms) : 0, 30596
AppSec [candidate] (30.439 ms) : 0, 30439
Debugger [baseline] (6.299 ms) : 0, 6299
Debugger [candidate] (6.317 ms) : 0, 6317
Remote Config [baseline] (682.238 µs) : 0, 682
Remote Config [candidate] (679.063 µs) : 0, 679
Telemetry [baseline] (15.263 ms) : 0, 15263
Telemetry [candidate] (15.726 ms) : 0, 15726
ProfilingAgent [baseline] (108.14 ms) : 0, 108140
ProfilingAgent [candidate] (108.371 ms) : 0, 108371
Profiling [baseline] (108.763 ms) : 0, 108763
Profiling [candidate] (109.044 ms) : 0, 109044
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~bb32861554, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047650
Total [baseline] (8.616 s) : 0, 8616155
Agent [candidate] (1.041 s) : 0, 1041108
Total [candidate] (8.583 s) : 0, 8583220
section iast
Agent [baseline] (1.174 s) : 0, 1174003
Total [baseline] (9.335 s) : 0, 9335444
Agent [candidate] (1.172 s) : 0, 1172164
Total [candidate] (9.338 s) : 0, 9337806
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~bb32861554, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (733.342 ms) : 0, 733342
BytebuddyAgent [candidate] (728.701 ms) : 0, 728701
GlobalTracer [baseline] (242.571 ms) : 0, 242571
GlobalTracer [candidate] (241.303 ms) : 0, 241303
AppSec [baseline] (30.533 ms) : 0, 30533
AppSec [candidate] (30.233 ms) : 0, 30233
Debugger [baseline] (6.077 ms) : 0, 6077
Debugger [candidate] (6.028 ms) : 0, 6028
Remote Config [baseline] (653.772 µs) : 0, 654
Remote Config [candidate] (647.241 µs) : 0, 647
Telemetry [baseline] (12.041 ms) : 0, 12041
Telemetry [candidate] (11.856 ms) : 0, 11856
section iast
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.417 ms) : 0, 1417
BytebuddyAgent [baseline] (847.55 ms) : 0, 847550
BytebuddyAgent [candidate] (846.228 ms) : 0, 846228
GlobalTracer [baseline] (231.452 ms) : 0, 231452
GlobalTracer [candidate] (231.532 ms) : 0, 231532
AppSec [baseline] (26.459 ms) : 0, 26459
AppSec [candidate] (27.146 ms) : 0, 27146
Debugger [baseline] (7.633 ms) : 0, 7633
Debugger [candidate] (6.64 ms) : 0, 6640
Remote Config [baseline] (578.645 µs) : 0, 579
Remote Config [candidate] (594.239 µs) : 0, 594
Telemetry [baseline] (8.118 ms) : 0, 8118
Telemetry [candidate] (8.094 ms) : 0, 8094
IAST [baseline] (29.897 ms) : 0, 29897
IAST [candidate] (29.674 ms) : 0, 29674
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~bb32861554, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section baseline
no_agent (37.013 ms) : 36707, 37318
. : milestone, 37013,
appsec (49.256 ms) : 48814, 49697
. : milestone, 49256,
code_origins (45.365 ms) : 44962, 45767
. : milestone, 45365,
iast (45.321 ms) : 44919, 45723
. : milestone, 45321,
profiling (48.5 ms) : 48060, 48939
. : milestone, 48500,
tracing (42.915 ms) : 42553, 43278
. : milestone, 42915,
section candidate
no_agent (35.936 ms) : 35651, 36221
. : milestone, 35936,
appsec (47.059 ms) : 46642, 47475
. : milestone, 47059,
code_origins (46.203 ms) : 45806, 46599
. : milestone, 46203,
iast (45.556 ms) : 45152, 45961
. : milestone, 45556,
profiling (48.314 ms) : 47812, 48816
. : milestone, 48314,
tracing (42.687 ms) : 42322, 43053
. : milestone, 42687,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~bb32861554, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section baseline
no_agent (4.424 ms) : 4372, 4476
. : milestone, 4424,
iast (9.311 ms) : 9162, 9460
. : milestone, 9311,
iast_FULL (13.983 ms) : 13708, 14258
. : milestone, 13983,
iast_GLOBAL (10.021 ms) : 9845, 10198
. : milestone, 10021,
profiling (8.647 ms) : 8513, 8781
. : milestone, 8647,
tracing (7.559 ms) : 7456, 7663
. : milestone, 7559,
section candidate
no_agent (4.22 ms) : 4165, 4274
. : milestone, 4220,
iast (9.602 ms) : 9437, 9768
. : milestone, 9602,
iast_FULL (14.05 ms) : 13771, 14330
. : milestone, 14050,
iast_GLOBAL (10.013 ms) : 9824, 10202
. : milestone, 10013,
profiling (8.961 ms) : 8805, 9117
. : milestone, 8961,
tracing (7.685 ms) : 7571, 7799
. : milestone, 7685,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~bb32861554, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section baseline
no_agent (15.411 s) : 15411000, 15411000
. : milestone, 15411000,
appsec (15.03 s) : 15030000, 15030000
. : milestone, 15030000,
iast (18.357 s) : 18357000, 18357000
. : milestone, 18357000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
. : milestone, 18003000,
profiling (15.829 s) : 15829000, 15829000
. : milestone, 15829000,
tracing (15.07 s) : 15070000, 15070000
. : milestone, 15070000,
section candidate
no_agent (15.576 s) : 15576000, 15576000
. : milestone, 15576000,
appsec (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
iast (18.191 s) : 18191000, 18191000
. : milestone, 18191000,
iast_GLOBAL (17.873 s) : 17873000, 17873000
. : milestone, 17873000,
profiling (15.609 s) : 15609000, 15609000
. : milestone, 15609000,
tracing (14.742 s) : 14742000, 14742000
. : milestone, 14742000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~bb32861554, baseline=1.51.1-SNAPSHOT~ae34f27d9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.455 ms) : 2402, 2508
. : milestone, 2455,
iast (2.193 ms) : 2131, 2256
. : milestone, 2193,
iast_GLOBAL (2.233 ms) : 2171, 2296
. : milestone, 2233,
profiling (2.056 ms) : 2004, 2108
. : milestone, 2056,
tracing (2.017 ms) : 1968, 2066
. : milestone, 2017,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.655 ms) : 3440, 3871
. : milestone, 3655,
iast (2.204 ms) : 2141, 2267
. : milestone, 2204,
iast_GLOBAL (2.237 ms) : 2174, 2300
. : milestone, 2237,
profiling (2.036 ms) : 1985, 2086
. : milestone, 2036,
tracing (2.004 ms) : 1955, 2052
. : milestone, 2004,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
I missed a job in #9243 . This add a rule not to run
notify-slo-breachesduringPOPULATE_CACHEMotivation
During POPULATE_CACHE pipelines, none of the jobs that the slo check depends on are run and the pipeline is broken. This PR aligns the slo check with the benchmark runs
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]