-
Notifications
You must be signed in to change notification settings - Fork 315
Replaced abandoned lib com.github.kstyrc with actively maintained com.github.codemonstur lib.
#9225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…th actively maintained `com.github.codemonstur` lib.
com.github.kstyrc (no updates since 2018) with actively maintained com.github.codemonstur lib.com.github.kstyrc with actively maintained com.github.codemonstur lib.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~f261a41e9e, baseline=1.51.1-SNAPSHOT~24694471cf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042835
Total [baseline] (10.741 s) : 0, 10741352
Agent [candidate] (1.043 s) : 0, 1043300
Total [candidate] (10.711 s) : 0, 10711413
section appsec
Agent [baseline] (1.221 s) : 0, 1220550
Total [baseline] (10.827 s) : 0, 10826571
Agent [candidate] (1.218 s) : 0, 1217974
Total [candidate] (10.82 s) : 0, 10820331
section iast
Agent [baseline] (1.173 s) : 0, 1173153
Total [baseline] (10.91 s) : 0, 10909867
Agent [candidate] (1.182 s) : 0, 1182456
Total [candidate] (10.971 s) : 0, 10970806
section profiling
Agent [baseline] (1.198 s) : 0, 1197684
Total [baseline] (10.952 s) : 0, 10952065
Agent [candidate] (1.19 s) : 0, 1190387
Total [candidate] (10.923 s) : 0, 10923101
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~f261a41e9e, baseline=1.51.1-SNAPSHOT~24694471cf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.411 ms) : 0, 1411
BytebuddyAgent [baseline] (729.315 ms) : 0, 729315
BytebuddyAgent [candidate] (729.591 ms) : 0, 729591
GlobalTracer [baseline] (241.072 ms) : 0, 241072
GlobalTracer [candidate] (241.239 ms) : 0, 241239
AppSec [baseline] (30.15 ms) : 0, 30150
AppSec [candidate] (30.324 ms) : 0, 30324
Debugger [baseline] (5.961 ms) : 0, 5961
Debugger [candidate] (5.956 ms) : 0, 5956
Remote Config [baseline] (643.579 µs) : 0, 644
Remote Config [candidate] (651.078 µs) : 0, 651
Telemetry [baseline] (13.224 ms) : 0, 13224
Telemetry [candidate] (13.172 ms) : 0, 13172
section appsec
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.42 ms) : 0, 1420
BytebuddyAgent [baseline] (754.327 ms) : 0, 754327
BytebuddyAgent [candidate] (751.46 ms) : 0, 751460
GlobalTracer [baseline] (234.561 ms) : 0, 234561
GlobalTracer [candidate] (234.71 ms) : 0, 234710
AppSec [baseline] (168.621 ms) : 0, 168621
AppSec [candidate] (170.177 ms) : 0, 170177
Debugger [baseline] (7.949 ms) : 0, 7949
Debugger [candidate] (6.4 ms) : 0, 6400
Remote Config [baseline] (636.379 µs) : 0, 636
Remote Config [candidate] (626.401 µs) : 0, 626
Telemetry [baseline] (8.183 ms) : 0, 8183
Telemetry [candidate] (8.319 ms) : 0, 8319
IAST [baseline] (23.48 ms) : 0, 23480
IAST [candidate] (23.616 ms) : 0, 23616
section iast
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (847.617 ms) : 0, 847617
BytebuddyAgent [candidate] (854.394 ms) : 0, 854394
GlobalTracer [baseline] (230.801 ms) : 0, 230801
GlobalTracer [candidate] (232.467 ms) : 0, 232467
AppSec [baseline] (27.304 ms) : 0, 27304
AppSec [candidate] (27.557 ms) : 0, 27557
Debugger [baseline] (5.751 ms) : 0, 5751
Debugger [candidate] (6.575 ms) : 0, 6575
Remote Config [baseline] (589.512 µs) : 0, 590
Remote Config [candidate] (593.067 µs) : 0, 593
Telemetry [baseline] (8.128 ms) : 0, 8128
Telemetry [candidate] (8.261 ms) : 0, 8261
IAST [baseline] (30.617 ms) : 0, 30617
IAST [candidate] (30.124 ms) : 0, 30124
section profiling
ProfilingAgent [baseline] (110.249 ms) : 0, 110249
ProfilingAgent [candidate] (109.739 ms) : 0, 109739
crashtracking [baseline] (1.395 ms) : 0, 1395
crashtracking [candidate] (1.393 ms) : 0, 1393
BytebuddyAgent [baseline] (762.795 ms) : 0, 762795
BytebuddyAgent [candidate] (757.677 ms) : 0, 757677
GlobalTracer [baseline] (221.477 ms) : 0, 221477
GlobalTracer [candidate] (220.496 ms) : 0, 220496
AppSec [baseline] (30.533 ms) : 0, 30533
AppSec [candidate] (30.113 ms) : 0, 30113
Debugger [baseline] (6.265 ms) : 0, 6265
Debugger [candidate] (6.241 ms) : 0, 6241
Remote Config [baseline] (679.801 µs) : 0, 680
Remote Config [candidate] (682.807 µs) : 0, 683
Telemetry [baseline] (15.849 ms) : 0, 15849
Telemetry [candidate] (15.748 ms) : 0, 15748
Profiling [baseline] (110.274 ms) : 0, 110274
Profiling [candidate] (109.765 ms) : 0, 109765
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~f261a41e9e, baseline=1.51.1-SNAPSHOT~24694471cf
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054342
Total [baseline] (8.616 s) : 0, 8615630
Agent [candidate] (1.042 s) : 0, 1041574
Total [candidate] (8.628 s) : 0, 8628469
section iast
Agent [baseline] (1.172 s) : 0, 1172239
Total [baseline] (9.296 s) : 0, 9295791
Agent [candidate] (1.18 s) : 0, 1180174
Total [candidate] (9.338 s) : 0, 9337643
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~f261a41e9e, baseline=1.51.1-SNAPSHOT~24694471cf
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.419 ms) : 0, 1419
BytebuddyAgent [baseline] (737.208 ms) : 0, 737208
BytebuddyAgent [candidate] (729.217 ms) : 0, 729217
GlobalTracer [baseline] (243.097 ms) : 0, 243097
GlobalTracer [candidate] (241.392 ms) : 0, 241392
AppSec [baseline] (30.724 ms) : 0, 30724
AppSec [candidate] (30.303 ms) : 0, 30303
Debugger [baseline] (5.993 ms) : 0, 5993
Debugger [candidate] (5.936 ms) : 0, 5936
Remote Config [baseline] (657.699 µs) : 0, 658
Remote Config [candidate] (646.576 µs) : 0, 647
Telemetry [baseline] (14.015 ms) : 0, 14015
Telemetry [candidate] (11.729 ms) : 0, 11729
section iast
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (845.864 ms) : 0, 845864
BytebuddyAgent [candidate] (852.959 ms) : 0, 852959
GlobalTracer [baseline] (231.314 ms) : 0, 231314
GlobalTracer [candidate] (232.393 ms) : 0, 232393
AppSec [baseline] (26.542 ms) : 0, 26542
AppSec [candidate] (27.158 ms) : 0, 27158
Debugger [baseline] (8.261 ms) : 0, 8261
Debugger [candidate] (7.469 ms) : 0, 7469
Remote Config [baseline] (617.857 µs) : 0, 618
Remote Config [candidate] (578.805 µs) : 0, 579
Telemetry [baseline] (8.099 ms) : 0, 8099
Telemetry [candidate] (8.039 ms) : 0, 8039
IAST [baseline] (29.148 ms) : 0, 29148
IAST [candidate] (29.153 ms) : 0, 29153
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~f261a41e9e, baseline=1.51.1-SNAPSHOT~24694471cf
dateFormat X
axisFormat %s
section baseline
no_agent (37.474 ms) : 37173, 37775
. : milestone, 37474,
appsec (48.376 ms) : 47954, 48797
. : milestone, 48376,
code_origins (45.887 ms) : 45498, 46277
. : milestone, 45887,
iast (45.925 ms) : 45523, 46328
. : milestone, 45925,
profiling (46.735 ms) : 46299, 47172
. : milestone, 46735,
tracing (43.492 ms) : 43129, 43855
. : milestone, 43492,
section candidate
no_agent (38.12 ms) : 37803, 38438
. : milestone, 38120,
appsec (47.592 ms) : 47172, 48012
. : milestone, 47592,
code_origins (44.41 ms) : 44038, 44783
. : milestone, 44410,
iast (42.71 ms) : 42353, 43067
. : milestone, 42710,
profiling (47.359 ms) : 46914, 47804
. : milestone, 47359,
tracing (44.699 ms) : 44323, 45075
. : milestone, 44699,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~f261a41e9e, baseline=1.51.1-SNAPSHOT~24694471cf
dateFormat X
axisFormat %s
section baseline
no_agent (4.455 ms) : 4406, 4505
. : milestone, 4455,
iast (9.297 ms) : 9145, 9449
. : milestone, 9297,
iast_FULL (13.993 ms) : 13714, 14272
. : milestone, 13993,
iast_GLOBAL (10.323 ms) : 10120, 10526
. : milestone, 10323,
profiling (8.861 ms) : 8721, 9002
. : milestone, 8861,
tracing (7.627 ms) : 7508, 7746
. : milestone, 7627,
section candidate
no_agent (4.354 ms) : 4306, 4402
. : milestone, 4354,
iast (9.364 ms) : 9210, 9518
. : milestone, 9364,
iast_FULL (13.622 ms) : 13357, 13886
. : milestone, 13622,
iast_GLOBAL (10.258 ms) : 10072, 10445
. : milestone, 10258,
profiling (9.455 ms) : 9291, 9618
. : milestone, 9455,
tracing (7.385 ms) : 7278, 7493
. : milestone, 7385,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~f261a41e9e, baseline=1.51.1-SNAPSHOT~24694471cf
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.642 ms) : 3425, 3858
. : milestone, 3642,
iast (2.198 ms) : 2136, 2260
. : milestone, 2198,
iast_GLOBAL (2.247 ms) : 2184, 2310
. : milestone, 2247,
profiling (2.066 ms) : 2014, 2117
. : milestone, 2066,
tracing (2.011 ms) : 1963, 2059
. : milestone, 2011,
section candidate
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.641 ms) : 3425, 3858
. : milestone, 3641,
iast (2.207 ms) : 2144, 2270
. : milestone, 2207,
iast_GLOBAL (2.248 ms) : 2185, 2310
. : milestone, 2248,
profiling (2.057 ms) : 2005, 2108
. : milestone, 2057,
tracing (2.014 ms) : 1965, 2062
. : milestone, 2014,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~f261a41e9e, baseline=1.51.1-SNAPSHOT~24694471cf
dateFormat X
axisFormat %s
section baseline
no_agent (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
appsec (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
iast (18.181 s) : 18181000, 18181000
. : milestone, 18181000,
iast_GLOBAL (17.941 s) : 17941000, 17941000
. : milestone, 17941000,
profiling (15.359 s) : 15359000, 15359000
. : milestone, 15359000,
tracing (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
section candidate
no_agent (15.475 s) : 15475000, 15475000
. : milestone, 15475000,
appsec (14.701 s) : 14701000, 14701000
. : milestone, 14701000,
iast (18.544 s) : 18544000, 18544000
. : milestone, 18544000,
iast_GLOBAL (18.311 s) : 18311000, 18311000
. : milestone, 18311000,
profiling (15.946 s) : 15946000, 15946000
. : milestone, 15946000,
tracing (14.708 s) : 14708000, 14708000
. : milestone, 14708000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool find!
What Does This Do
Replaced abandoned lib
com.github.kstyrc(no updates since 2018) with actively maintainedcom.github.codemonsturlib.Motivation
Clean code.
Additional Notes
Also there is a chance that old library was a root cause of
lettuce-4tests timeout on CI.