-
Notifications
You must be signed in to change notification settings - Fork 314
Update Spock framework to v2.3. #9138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~001f525109, baseline=1.52.0-SNAPSHOT~0054831f0b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.586 ms) : 0, 996586
Total [baseline] (10.75 s) : 0, 10750433
Agent [candidate] (1.002 s) : 0, 1001672
Total [candidate] (10.661 s) : 0, 10660959
section appsec
Agent [baseline] (1.175 s) : 0, 1175206
Total [baseline] (10.78 s) : 0, 10779854
Agent [candidate] (1.173 s) : 0, 1173201
Total [candidate] (10.738 s) : 0, 10737729
section iast
Agent [baseline] (1.135 s) : 0, 1134633
Total [baseline] (10.855 s) : 0, 10854889
Agent [candidate] (1.136 s) : 0, 1135701
Total [candidate] (10.853 s) : 0, 10852526
section profiling
Agent [baseline] (1.244 s) : 0, 1243756
Total [baseline] (10.93 s) : 0, 10930016
Agent [candidate] (1.246 s) : 0, 1246349
Total [candidate] (11.042 s) : 0, 11041651
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~001f525109, baseline=1.52.0-SNAPSHOT~0054831f0b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.225 ms) : 0, 688225
BytebuddyAgent [candidate] (691.56 ms) : 0, 691560
GlobalTracer [baseline] (242.308 ms) : 0, 242308
GlobalTracer [candidate] (243.601 ms) : 0, 243601
AppSec [baseline] (30.208 ms) : 0, 30208
AppSec [candidate] (30.456 ms) : 0, 30456
Debugger [baseline] (6.004 ms) : 0, 6004
Debugger [candidate] (6.081 ms) : 0, 6081
Remote Config [baseline] (681.848 µs) : 0, 682
Remote Config [candidate] (694.768 µs) : 0, 695
Telemetry [baseline] (8.212 ms) : 0, 8212
Telemetry [candidate] (8.289 ms) : 0, 8289
section appsec
BytebuddyAgent [baseline] (710.614 ms) : 0, 710614
BytebuddyAgent [candidate] (709.328 ms) : 0, 709328
GlobalTracer [baseline] (235.165 ms) : 0, 235165
GlobalTracer [candidate] (234.769 ms) : 0, 234769
AppSec [baseline] (170.814 ms) : 0, 170814
AppSec [candidate] (170.827 ms) : 0, 170827
Debugger [baseline] (5.705 ms) : 0, 5705
Debugger [candidate] (5.692 ms) : 0, 5692
Remote Config [baseline] (608.175 µs) : 0, 608
Remote Config [candidate] (608.669 µs) : 0, 609
Telemetry [baseline] (8.134 ms) : 0, 8134
Telemetry [candidate] (8.047 ms) : 0, 8047
IAST [baseline] (23.204 ms) : 0, 23204
IAST [candidate] (23.014 ms) : 0, 23014
section iast
BytebuddyAgent [baseline] (809.159 ms) : 0, 809159
BytebuddyAgent [candidate] (809.521 ms) : 0, 809521
GlobalTracer [baseline] (232.557 ms) : 0, 232557
GlobalTracer [candidate] (232.831 ms) : 0, 232831
AppSec [baseline] (30.735 ms) : 0, 30735
AppSec [candidate] (30.909 ms) : 0, 30909
Debugger [baseline] (5.757 ms) : 0, 5757
Debugger [candidate] (5.766 ms) : 0, 5766
Remote Config [baseline] (580.829 µs) : 0, 581
Remote Config [candidate] (586.067 µs) : 0, 586
Telemetry [baseline] (7.918 ms) : 0, 7918
Telemetry [candidate] (8.06 ms) : 0, 8060
IAST [baseline] (26.97 ms) : 0, 26970
IAST [candidate] (27.095 ms) : 0, 27095
section profiling
BytebuddyAgent [baseline] (677.071 ms) : 0, 677071
BytebuddyAgent [candidate] (678.276 ms) : 0, 678276
GlobalTracer [baseline] (361.23 ms) : 0, 361230
GlobalTracer [candidate] (362.237 ms) : 0, 362237
AppSec [baseline] (32.179 ms) : 0, 32179
AppSec [candidate] (31.596 ms) : 0, 31596
Debugger [baseline] (9.787 ms) : 0, 9787
Debugger [candidate] (10.663 ms) : 0, 10663
Remote Config [baseline] (663.632 µs) : 0, 664
Remote Config [candidate] (684.345 µs) : 0, 684
Telemetry [baseline] (9.55 ms) : 0, 9550
Telemetry [candidate] (10.206 ms) : 0, 10206
ProfilingAgent [baseline] (104.586 ms) : 0, 104586
ProfilingAgent [candidate] (104.002 ms) : 0, 104002
Profiling [baseline] (104.609 ms) : 0, 104609
Profiling [candidate] (104.026 ms) : 0, 104026
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~001f525109, baseline=1.52.0-SNAPSHOT~0054831f0b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.002 s) : 0, 1002018
Total [baseline] (8.588 s) : 0, 8587659
Agent [candidate] (1.004 s) : 0, 1004214
Total [candidate] (8.632 s) : 0, 8632214
section iast
Agent [baseline] (1.135 s) : 0, 1134743
Total [baseline] (9.287 s) : 0, 9286891
Agent [candidate] (1.136 s) : 0, 1136257
Total [candidate] (9.282 s) : 0, 9282180
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~001f525109, baseline=1.52.0-SNAPSHOT~0054831f0b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.469 ms) : 0, 692469
BytebuddyAgent [candidate] (693.582 ms) : 0, 693582
GlobalTracer [baseline] (243.136 ms) : 0, 243136
GlobalTracer [candidate] (244.212 ms) : 0, 244212
AppSec [baseline] (30.488 ms) : 0, 30488
AppSec [candidate] (30.472 ms) : 0, 30472
Debugger [baseline] (6.02 ms) : 0, 6020
Debugger [candidate] (6.016 ms) : 0, 6016
Remote Config [baseline] (672.46 µs) : 0, 672
Remote Config [candidate] (693.509 µs) : 0, 694
Telemetry [baseline] (8.281 ms) : 0, 8281
Telemetry [candidate] (8.34 ms) : 0, 8340
section iast
BytebuddyAgent [baseline] (809.955 ms) : 0, 809955
BytebuddyAgent [candidate] (809.864 ms) : 0, 809864
GlobalTracer [baseline] (232.375 ms) : 0, 232375
GlobalTracer [candidate] (232.8 ms) : 0, 232800
AppSec [baseline] (28.936 ms) : 0, 28936
AppSec [candidate] (31.761 ms) : 0, 31761
Debugger [baseline] (5.751 ms) : 0, 5751
Debugger [candidate] (5.768 ms) : 0, 5768
Remote Config [baseline] (597.485 µs) : 0, 597
Remote Config [candidate] (587.261 µs) : 0, 587
Telemetry [baseline] (7.925 ms) : 0, 7925
Telemetry [candidate] (8.027 ms) : 0, 8027
IAST [baseline] (28.383 ms) : 0, 28383
IAST [candidate] (26.523 ms) : 0, 26523
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~001f525109, baseline=1.52.0-SNAPSHOT~0054831f0b
dateFormat X
axisFormat %s
section baseline
no_agent (36.679 ms) : 36385, 36974
. : milestone, 36679,
appsec (47.729 ms) : 47314, 48143
. : milestone, 47729,
code_origins (45.638 ms) : 45258, 46017
. : milestone, 45638,
iast (45.06 ms) : 44672, 45448
. : milestone, 45060,
profiling (49.753 ms) : 49283, 50222
. : milestone, 49753,
tracing (44.89 ms) : 44523, 45258
. : milestone, 44890,
section candidate
no_agent (38.222 ms) : 37911, 38532
. : milestone, 38222,
appsec (46.17 ms) : 45759, 46580
. : milestone, 46170,
code_origins (44.635 ms) : 44236, 45033
. : milestone, 44635,
iast (42.871 ms) : 42508, 43233
. : milestone, 42871,
profiling (49.284 ms) : 48786, 49782
. : milestone, 49284,
tracing (43.845 ms) : 43480, 44210
. : milestone, 43845,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~001f525109, baseline=1.52.0-SNAPSHOT~0054831f0b
dateFormat X
axisFormat %s
section baseline
no_agent (4.443 ms) : 4393, 4494
. : milestone, 4443,
iast (9.276 ms) : 9126, 9425
. : milestone, 9276,
iast_FULL (13.84 ms) : 13566, 14114
. : milestone, 13840,
iast_GLOBAL (10.052 ms) : 9866, 10238
. : milestone, 10052,
profiling (8.563 ms) : 8433, 8693
. : milestone, 8563,
tracing (7.828 ms) : 7708, 7949
. : milestone, 7828,
section candidate
no_agent (4.434 ms) : 4383, 4485
. : milestone, 4434,
iast (9.68 ms) : 9524, 9837
. : milestone, 9680,
iast_FULL (13.727 ms) : 13455, 13999
. : milestone, 13727,
iast_GLOBAL (10.385 ms) : 10203, 10568
. : milestone, 10385,
profiling (8.381 ms) : 8245, 8517
. : milestone, 8381,
tracing (7.512 ms) : 7405, 7619
. : milestone, 7512,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~001f525109, baseline=1.52.0-SNAPSHOT~0054831f0b
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.407 ms) : 2358, 2456
. : milestone, 2407,
iast (2.189 ms) : 2127, 2251
. : milestone, 2189,
iast_GLOBAL (2.227 ms) : 2165, 2289
. : milestone, 2227,
profiling (2.486 ms) : 2311, 2661
. : milestone, 2486,
tracing (2.003 ms) : 1955, 2051
. : milestone, 2003,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.403 ms) : 2354, 2453
. : milestone, 2403,
iast (2.18 ms) : 2118, 2242
. : milestone, 2180,
iast_GLOBAL (2.234 ms) : 2171, 2296
. : milestone, 2234,
profiling (2.045 ms) : 1994, 2096
. : milestone, 2045,
tracing (2.007 ms) : 1959, 2055
. : milestone, 2007,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~001f525109, baseline=1.52.0-SNAPSHOT~0054831f0b
dateFormat X
axisFormat %s
section baseline
no_agent (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
appsec (14.763 s) : 14763000, 14763000
. : milestone, 14763000,
iast (18.615 s) : 18615000, 18615000
. : milestone, 18615000,
iast_GLOBAL (17.957 s) : 17957000, 17957000
. : milestone, 17957000,
profiling (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
tracing (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
section candidate
no_agent (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
appsec (15.081 s) : 15081000, 15081000
. : milestone, 15081000,
iast (18.648 s) : 18648000, 18648000
. : milestone, 18648000,
iast_GLOBAL (17.863 s) : 17863000, 17863000
. : milestone, 17863000,
profiling (14.759 s) : 14759000, 14759000
. : milestone, 14759000,
tracing (14.927 s) : 14927000, 14927000
. : milestone, 14927000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, as a followup this could land into the gradle version catalog ?
Yes, I'm thinking about it. |
What Does This Do
Update Spock framework to v2.3.
Motivation
Code cleanup.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]