- 
                Notifications
    You must be signed in to change notification settings 
- Fork 315
Check sonatype auth beforehand #9113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to: 
 If you need help, please check our contributing guidelines. | 
77e46e7    to
    518a054      
    Compare
  
    | BenchmarksStartupParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
    title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~518a054503, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.003 s) : 0, 1002571
Total [baseline] (10.659 s) : 0, 10659247
Agent [candidate] (995.526 ms) : 0, 995526
Total [candidate] (10.624 s) : 0, 10624170
section appsec
Agent [baseline] (1.175 s) : 0, 1175266
Total [baseline] (10.802 s) : 0, 10802057
Agent [candidate] (1.185 s) : 0, 1184662
Total [candidate] (10.769 s) : 0, 10769496
section iast
Agent [baseline] (1.136 s) : 0, 1136095
Total [baseline] (10.867 s) : 0, 10867207
Agent [candidate] (1.135 s) : 0, 1135045
Total [candidate] (10.815 s) : 0, 10814811
section profiling
Agent [baseline] (1.245 s) : 0, 1245453
Total [baseline] (10.929 s) : 0, 10928620
Agent [candidate] (1.244 s) : 0, 1244463
Total [candidate] (10.953 s) : 0, 10952766
 
 
 
 gantt
    title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~518a054503, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.282 ms) : 0, 692282
BytebuddyAgent [candidate] (687.777 ms) : 0, 687777
GlobalTracer [baseline] (243.591 ms) : 0, 243591
GlobalTracer [candidate] (241.846 ms) : 0, 241846
AppSec [baseline] (30.689 ms) : 0, 30689
AppSec [candidate] (30.157 ms) : 0, 30157
Debugger [baseline] (6.082 ms) : 0, 6082
Debugger [candidate] (6.043 ms) : 0, 6043
Remote Config [baseline] (686.08 µs) : 0, 686
Remote Config [candidate] (679.41 µs) : 0, 679
Telemetry [baseline] (8.305 ms) : 0, 8305
Telemetry [candidate] (8.183 ms) : 0, 8183
section appsec
BytebuddyAgent [baseline] (709.155 ms) : 0, 709155
BytebuddyAgent [candidate] (715.866 ms) : 0, 715866
GlobalTracer [baseline] (236.332 ms) : 0, 236332
GlobalTracer [candidate] (237.334 ms) : 0, 237334
AppSec [baseline] (171.204 ms) : 0, 171204
AppSec [candidate] (172.52 ms) : 0, 172520
Debugger [baseline] (5.725 ms) : 0, 5725
Debugger [candidate] (5.78 ms) : 0, 5780
Remote Config [baseline] (596.672 µs) : 0, 597
Remote Config [candidate] (602.597 µs) : 0, 603
Telemetry [baseline] (8.038 ms) : 0, 8038
Telemetry [candidate] (8.073 ms) : 0, 8073
IAST [baseline] (23.332 ms) : 0, 23332
IAST [candidate] (23.535 ms) : 0, 23535
section iast
BytebuddyAgent [baseline] (809.383 ms) : 0, 809383
BytebuddyAgent [candidate] (809.44 ms) : 0, 809440
GlobalTracer [baseline] (233.766 ms) : 0, 233766
GlobalTracer [candidate] (232.857 ms) : 0, 232857
AppSec [baseline] (28.645 ms) : 0, 28645
AppSec [candidate] (27.885 ms) : 0, 27885
Debugger [baseline] (5.899 ms) : 0, 5899
Debugger [candidate] (5.869 ms) : 0, 5869
Remote Config [baseline] (585.225 µs) : 0, 585
Remote Config [candidate] (597.323 µs) : 0, 597
Telemetry [baseline] (8.058 ms) : 0, 8058
Telemetry [candidate] (8.034 ms) : 0, 8034
IAST [baseline] (28.843 ms) : 0, 28843
IAST [candidate] (29.527 ms) : 0, 29527
section profiling
BytebuddyAgent [baseline] (678.582 ms) : 0, 678582
BytebuddyAgent [candidate] (678.044 ms) : 0, 678044
GlobalTracer [baseline] (361.784 ms) : 0, 361784
GlobalTracer [candidate] (361.673 ms) : 0, 361673
AppSec [baseline] (30.981 ms) : 0, 30981
AppSec [candidate] (31.69 ms) : 0, 31690
Debugger [baseline] (13.639 ms) : 0, 13639
Debugger [candidate] (11.462 ms) : 0, 11462
Remote Config [baseline] (669.933 µs) : 0, 670
Remote Config [candidate] (671.574 µs) : 0, 672
Telemetry [baseline] (8.042 ms) : 0, 8042
Telemetry [candidate] (9.444 ms) : 0, 9444
ProfilingAgent [baseline] (103.077 ms) : 0, 103077
ProfilingAgent [candidate] (102.976 ms) : 0, 102976
Profiling [baseline] (103.102 ms) : 0, 103102
Profiling [candidate] (103.0 ms) : 0, 103000
Startup time reports for insecure-bankgantt
    title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~518a054503, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (994.832 ms) : 0, 994832
Total [baseline] (8.575 s) : 0, 8575183
Agent [candidate] (998.603 ms) : 0, 998603
Total [candidate] (8.563 s) : 0, 8562648
section iast
Agent [baseline] (1.134 s) : 0, 1134116
Total [baseline] (9.292 s) : 0, 9291527
Agent [candidate] (1.132 s) : 0, 1132422
Total [candidate] (9.251 s) : 0, 9251146
 
 
 
 gantt
    title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~518a054503, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.984 ms) : 0, 686984
BytebuddyAgent [candidate] (689.507 ms) : 0, 689507
GlobalTracer [baseline] (241.749 ms) : 0, 241749
GlobalTracer [candidate] (243.023 ms) : 0, 243023
AppSec [baseline] (30.333 ms) : 0, 30333
AppSec [candidate] (30.316 ms) : 0, 30316
Debugger [baseline] (6.109 ms) : 0, 6109
Debugger [candidate] (6.081 ms) : 0, 6081
Remote Config [baseline] (677.262 µs) : 0, 677
Remote Config [candidate] (672.476 µs) : 0, 672
Telemetry [baseline] (8.22 ms) : 0, 8220
Telemetry [candidate] (8.206 ms) : 0, 8206
section iast
BytebuddyAgent [baseline] (808.454 ms) : 0, 808454
BytebuddyAgent [candidate] (806.786 ms) : 0, 806786
GlobalTracer [baseline] (233.342 ms) : 0, 233342
GlobalTracer [candidate] (232.785 ms) : 0, 232785
AppSec [baseline] (30.161 ms) : 0, 30161
AppSec [candidate] (30.423 ms) : 0, 30423
Debugger [baseline] (5.817 ms) : 0, 5817
Debugger [candidate] (5.847 ms) : 0, 5847
Remote Config [baseline] (584.223 µs) : 0, 584
Remote Config [candidate] (584.682 µs) : 0, 585
Telemetry [baseline] (8.122 ms) : 0, 8122
Telemetry [candidate] (8.052 ms) : 0, 8052
IAST [baseline] (26.767 ms) : 0, 26767
IAST [candidate] (27.123 ms) : 0, 27123
LoadParameters
 See matching parameters
 SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics. 
 Request duration reports for insecure-bankgantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~518a054503, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.43 ms) : 4369, 4492
.   : milestone, 4430,
iast (9.14 ms) : 8990, 9290
.   : milestone, 9140,
iast_FULL (14.053 ms) : 13775, 14331
.   : milestone, 14053,
iast_GLOBAL (10.057 ms) : 9879, 10236
.   : milestone, 10057,
profiling (8.403 ms) : 8275, 8531
.   : milestone, 8403,
tracing (7.674 ms) : 7563, 7785
.   : milestone, 7674,
section candidate
no_agent (4.368 ms) : 4319, 4417
.   : milestone, 4368,
iast (9.364 ms) : 9209, 9519
.   : milestone, 9364,
iast_FULL (14.219 ms) : 13938, 14500
.   : milestone, 14219,
iast_GLOBAL (10.522 ms) : 10335, 10710
.   : milestone, 10522,
profiling (9.12 ms) : 8982, 9257
.   : milestone, 9120,
tracing (7.529 ms) : 7409, 7650
.   : milestone, 7529,
 
 
 
 Request duration reports for petclinicgantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~518a054503, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.096 ms) : 36805, 37387
.   : milestone, 37096,
appsec (47.107 ms) : 46685, 47529
.   : milestone, 47107,
code_origins (44.613 ms) : 44226, 45000
.   : milestone, 44613,
iast (44.473 ms) : 44083, 44863
.   : milestone, 44473,
profiling (48.811 ms) : 48342, 49280
.   : milestone, 48811,
tracing (45.055 ms) : 44672, 45439
.   : milestone, 45055,
section candidate
no_agent (37.553 ms) : 37245, 37860
.   : milestone, 37553,
appsec (47.361 ms) : 46947, 47775
.   : milestone, 47361,
code_origins (45.267 ms) : 44883, 45651
.   : milestone, 45267,
iast (41.9 ms) : 41521, 42280
.   : milestone, 41900,
profiling (49.444 ms) : 48924, 49964
.   : milestone, 49444,
tracing (44.323 ms) : 43971, 44675
.   : milestone, 44323,
 
 
 
 DacapoParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
    title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~518a054503, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.824 s) : 14824000, 14824000
.   : milestone, 14824000,
appsec (14.953 s) : 14953000, 14953000
.   : milestone, 14953000,
iast (18.206 s) : 18206000, 18206000
.   : milestone, 18206000,
iast_GLOBAL (18.036 s) : 18036000, 18036000
.   : milestone, 18036000,
profiling (15.191 s) : 15191000, 15191000
.   : milestone, 15191000,
tracing (14.921 s) : 14921000, 14921000
.   : milestone, 14921000,
section candidate
no_agent (15.003 s) : 15003000, 15003000
.   : milestone, 15003000,
appsec (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
iast (18.242 s) : 18242000, 18242000
.   : milestone, 18242000,
iast_GLOBAL (18.06 s) : 18060000, 18060000
.   : milestone, 18060000,
profiling (15.224 s) : 15224000, 15224000
.   : milestone, 15224000,
tracing (14.816 s) : 14816000, 14816000
.   : milestone, 14816000,
 
 
 
 Execution time for tomcatgantt
    title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~518a054503, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
.   : milestone, 1480,
appsec (2.416 ms) : 2367, 2465
.   : milestone, 2416,
iast (2.205 ms) : 2142, 2267
.   : milestone, 2205,
iast_GLOBAL (2.241 ms) : 2179, 2303
.   : milestone, 2241,
profiling (2.053 ms) : 2002, 2103
.   : milestone, 2053,
tracing (2.008 ms) : 1961, 2056
.   : milestone, 2008,
section candidate
no_agent (1.481 ms) : 1469, 1492
.   : milestone, 1481,
appsec (2.414 ms) : 2365, 2463
.   : milestone, 2414,
iast (2.196 ms) : 2134, 2257
.   : milestone, 2196,
iast_GLOBAL (2.246 ms) : 2184, 2308
.   : milestone, 2246,
profiling (2.056 ms) : 2005, 2106
.   : milestone, 2056,
tracing (2.013 ms) : 1965, 2061
.   : milestone, 2013,
 
 
 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful, thanks!
What Does This Do
When generating a new user generated token on central publisher portal, the old are invalidated.
This PR a check early to see if these credentials are valid. Only when releasing from a tag.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]