-
Couldn't load subscription status.
- Fork 315
Revert "Update ddapm-test-agent from v1.11.0 to v1.24.1 (#9043)" #9084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Update ddapm-test-agent from v1.11.0 to v1.24.1 (#9043)" #9084
Conversation
This reverts commit 0f66a88.
|
Quick question: what was the rational to revert the upgrade? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the motivation, for people who might look at upgrading this in the future
Added |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~ec9c09df34, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (997.747 ms) : 0, 997747
Total [baseline] (10.703 s) : 0, 10703413
Agent [candidate] (999.973 ms) : 0, 999973
Total [candidate] (10.686 s) : 0, 10686469
section appsec
Agent [baseline] (1.177 s) : 0, 1177374
Total [baseline] (10.821 s) : 0, 10820659
Agent [candidate] (1.18 s) : 0, 1179978
Total [candidate] (10.799 s) : 0, 10799069
section iast
Agent [baseline] (1.142 s) : 0, 1142213
Total [baseline] (10.866 s) : 0, 10865515
Agent [candidate] (1.138 s) : 0, 1138425
Total [candidate] (10.828 s) : 0, 10828357
section profiling
Agent [baseline] (1.257 s) : 0, 1257132
Total [baseline] (11.155 s) : 0, 11154686
Agent [candidate] (1.246 s) : 0, 1246223
Total [candidate] (11.014 s) : 0, 11014167
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~ec9c09df34, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.683 ms) : 0, 688683
BytebuddyAgent [candidate] (690.517 ms) : 0, 690517
GlobalTracer [baseline] (243.134 ms) : 0, 243134
GlobalTracer [candidate] (243.322 ms) : 0, 243322
AppSec [baseline] (30.285 ms) : 0, 30285
AppSec [candidate] (30.295 ms) : 0, 30295
Debugger [baseline] (5.987 ms) : 0, 5987
Debugger [candidate] (6.044 ms) : 0, 6044
Remote Config [baseline] (677.78 µs) : 0, 678
Remote Config [candidate] (682.513 µs) : 0, 683
Telemetry [baseline] (8.217 ms) : 0, 8217
Telemetry [candidate] (8.244 ms) : 0, 8244
section appsec
BytebuddyAgent [baseline] (712.066 ms) : 0, 712066
BytebuddyAgent [candidate] (713.542 ms) : 0, 713542
GlobalTracer [baseline] (236.304 ms) : 0, 236304
GlobalTracer [candidate] (236.937 ms) : 0, 236937
AppSec [baseline] (171.456 ms) : 0, 171456
AppSec [candidate] (171.85 ms) : 0, 171850
Debugger [baseline] (5.803 ms) : 0, 5803
Debugger [candidate] (5.801 ms) : 0, 5801
Remote Config [baseline] (603.942 µs) : 0, 604
Remote Config [candidate] (605.962 µs) : 0, 606
Telemetry [baseline] (8.152 ms) : 0, 8152
Telemetry [candidate] (8.117 ms) : 0, 8117
IAST [baseline] (22.182 ms) : 0, 22182
IAST [candidate] (22.274 ms) : 0, 22274
section iast
BytebuddyAgent [baseline] (814.962 ms) : 0, 814962
BytebuddyAgent [candidate] (814.274 ms) : 0, 814274
GlobalTracer [baseline] (235.443 ms) : 0, 235443
GlobalTracer [candidate] (233.767 ms) : 0, 233767
AppSec [baseline] (28.847 ms) : 0, 28847
AppSec [candidate] (27.412 ms) : 0, 27412
Debugger [baseline] (5.876 ms) : 0, 5876
Debugger [candidate] (5.79 ms) : 0, 5790
Remote Config [baseline] (592.874 µs) : 0, 593
Remote Config [candidate] (585.37 µs) : 0, 585
Telemetry [baseline] (8.08 ms) : 0, 8080
Telemetry [candidate] (7.957 ms) : 0, 7957
IAST [baseline] (26.681 ms) : 0, 26681
IAST [candidate] (27.755 ms) : 0, 27755
section profiling
BytebuddyAgent [baseline] (685.193 ms) : 0, 685193
BytebuddyAgent [candidate] (678.381 ms) : 0, 678381
GlobalTracer [baseline] (365.064 ms) : 0, 365064
GlobalTracer [candidate] (362.418 ms) : 0, 362418
AppSec [baseline] (33.115 ms) : 0, 33115
AppSec [candidate] (30.841 ms) : 0, 30841
Debugger [baseline] (9.879 ms) : 0, 9879
Debugger [candidate] (11.538 ms) : 0, 11538
Remote Config [baseline] (1.59 ms) : 0, 1590
Remote Config [candidate] (1.38 ms) : 0, 1380
Telemetry [baseline] (8.869 ms) : 0, 8869
Telemetry [candidate] (9.529 ms) : 0, 9529
ProfilingAgent [baseline] (104.259 ms) : 0, 104259
ProfilingAgent [candidate] (103.559 ms) : 0, 103559
Profiling [baseline] (104.285 ms) : 0, 104285
Profiling [candidate] (103.583 ms) : 0, 103583
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~ec9c09df34, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.415 ms) : 0, 996415
Total [baseline] (8.591 s) : 0, 8590622
Agent [candidate] (1.004 s) : 0, 1004286
Total [candidate] (8.635 s) : 0, 8635270
section iast
Agent [baseline] (1.131 s) : 0, 1131033
Total [baseline] (9.257 s) : 0, 9256896
Agent [candidate] (1.133 s) : 0, 1133429
Total [candidate] (9.282 s) : 0, 9281701
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~ec9c09df34, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.981 ms) : 0, 687981
BytebuddyAgent [candidate] (692.689 ms) : 0, 692689
GlobalTracer [baseline] (242.274 ms) : 0, 242274
GlobalTracer [candidate] (244.847 ms) : 0, 244847
AppSec [baseline] (30.461 ms) : 0, 30461
AppSec [candidate] (30.727 ms) : 0, 30727
Debugger [baseline] (6.029 ms) : 0, 6029
Debugger [candidate] (6.082 ms) : 0, 6082
Remote Config [baseline] (668.454 µs) : 0, 668
Remote Config [candidate] (681.607 µs) : 0, 682
Telemetry [baseline] (8.192 ms) : 0, 8192
Telemetry [candidate] (8.279 ms) : 0, 8279
section iast
BytebuddyAgent [baseline] (807.586 ms) : 0, 807586
BytebuddyAgent [candidate] (809.074 ms) : 0, 809074
GlobalTracer [baseline] (233.326 ms) : 0, 233326
GlobalTracer [candidate] (233.274 ms) : 0, 233274
AppSec [baseline] (25.77 ms) : 0, 25770
AppSec [candidate] (28.538 ms) : 0, 28538
Debugger [baseline] (5.835 ms) : 0, 5835
Debugger [candidate] (5.884 ms) : 0, 5884
Remote Config [baseline] (581.57 µs) : 0, 582
Remote Config [candidate] (594.413 µs) : 0, 594
Telemetry [baseline] (7.93 ms) : 0, 7930
Telemetry [candidate] (8.084 ms) : 0, 8084
IAST [baseline] (29.241 ms) : 0, 29241
IAST [candidate] (27.159 ms) : 0, 27159
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~ec9c09df34, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section baseline
no_agent (36.351 ms) : 36058, 36644
. : milestone, 36351,
appsec (45.171 ms) : 44772, 45570
. : milestone, 45171,
code_origins (46.763 ms) : 46357, 47168
. : milestone, 46763,
iast (44.592 ms) : 44209, 44975
. : milestone, 44592,
profiling (46.276 ms) : 45849, 46703
. : milestone, 46276,
tracing (44.519 ms) : 44154, 44885
. : milestone, 44519,
section candidate
no_agent (35.524 ms) : 35237, 35811
. : milestone, 35524,
appsec (47.26 ms) : 46851, 47669
. : milestone, 47260,
code_origins (44.536 ms) : 44155, 44918
. : milestone, 44536,
iast (42.919 ms) : 42547, 43291
. : milestone, 42919,
profiling (49.675 ms) : 49205, 50146
. : milestone, 49675,
tracing (43.997 ms) : 43617, 44377
. : milestone, 43997,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~ec9c09df34, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section baseline
no_agent (4.313 ms) : 4266, 4361
. : milestone, 4313,
iast (9.11 ms) : 8961, 9260
. : milestone, 9110,
iast_FULL (14.093 ms) : 13814, 14373
. : milestone, 14093,
iast_GLOBAL (10.098 ms) : 9912, 10284
. : milestone, 10098,
profiling (8.638 ms) : 8508, 8769
. : milestone, 8638,
tracing (7.703 ms) : 7590, 7816
. : milestone, 7703,
section candidate
no_agent (4.415 ms) : 4365, 4464
. : milestone, 4415,
iast (9.36 ms) : 9208, 9511
. : milestone, 9360,
iast_FULL (14.164 ms) : 13888, 14440
. : milestone, 14164,
iast_GLOBAL (10.185 ms) : 10009, 10361
. : milestone, 10185,
profiling (8.759 ms) : 8616, 8903
. : milestone, 8759,
tracing (7.775 ms) : 7662, 7889
. : milestone, 7775,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~ec9c09df34, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1481
. : milestone, 1470,
appsec (2.399 ms) : 2350, 2449
. : milestone, 2399,
iast (2.179 ms) : 2117, 2240
. : milestone, 2179,
iast_GLOBAL (2.225 ms) : 2163, 2287
. : milestone, 2225,
profiling (2.035 ms) : 1984, 2086
. : milestone, 2035,
tracing (2.018 ms) : 1970, 2067
. : milestone, 2018,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.398 ms) : 2349, 2448
. : milestone, 2398,
iast (2.187 ms) : 2124, 2249
. : milestone, 2187,
iast_GLOBAL (2.232 ms) : 2170, 2294
. : milestone, 2232,
profiling (2.037 ms) : 1987, 2088
. : milestone, 2037,
tracing (2.018 ms) : 1969, 2066
. : milestone, 2018,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~ec9c09df34, baseline=1.51.0-SNAPSHOT~0c891b79c1
dateFormat X
axisFormat %s
section baseline
no_agent (14.989 s) : 14989000, 14989000
. : milestone, 14989000,
appsec (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
iast (18.466 s) : 18466000, 18466000
. : milestone, 18466000,
iast_GLOBAL (18.15 s) : 18150000, 18150000
. : milestone, 18150000,
profiling (15.883 s) : 15883000, 15883000
. : milestone, 15883000,
tracing (14.815 s) : 14815000, 14815000
. : milestone, 14815000,
section candidate
no_agent (15.225 s) : 15225000, 15225000
. : milestone, 15225000,
appsec (14.852 s) : 14852000, 14852000
. : milestone, 14852000,
iast (18.267 s) : 18267000, 18267000
. : milestone, 18267000,
iast_GLOBAL (18.192 s) : 18192000, 18192000
. : milestone, 18192000,
profiling (15.345 s) : 15345000, 15345000
. : milestone, 15345000,
tracing (14.989 s) : 14989000, 14989000
. : milestone, 14989000,
|
This reverts commit 0f66a88.
What Does This Do
After upgrade service container not able to come up, so better to revert to working version. The service error was hidden logic flaw in
check_agent_results.sh. The script assumes if the test-agent is not running, it was not supposed to run because only certain jobs use the test-agent. A followup PR will correct the logicMotivation
Additional Notes
We need to investigate why service container can not start after version update and what is the root cause of error:
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]