Skip to content

Widen lazy coroutine matcher to cover all definitions of onStart #8838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Widen lazy coroutine matcher to cover all definitions of onStart #8838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions ...in/java/datadog/trace/instrumentation/kotlin/coroutines/LazyCoroutineInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,34 @@
package datadog.trace.instrumentation.kotlin.coroutines;

import static datadog.trace.agent.tooling.bytebuddy.matcher.HierarchyMatchers.extendsClass;
import static datadog.trace.agent.tooling.bytebuddy.matcher.NameMatchers.named;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
import static net.bytebuddy.matcher.ElementMatchers.takesNoArguments;

import datadog.trace.agent.tooling.Instrumenter;
import kotlinx.coroutines.AbstractCoroutine;
import net.bytebuddy.asm.Advice;
import net.bytebuddy.description.type.TypeDescription;
import net.bytebuddy.matcher.ElementMatcher;

/** Captures the Datadog context when lazy coroutines start. */
public class LazyCoroutineInstrumentation
implements Instrumenter.ForSingleType, Instrumenter.HasMethodAdvice {
implements Instrumenter.ForTypeHierarchy, Instrumenter.HasMethodAdvice {

@Override
public String instrumentedType() {
return "kotlinx.coroutines.LazyDeferredCoroutine";
public String hierarchyMarkerType() {
return "kotlinx.coroutines.AbstractCoroutine";
}

@Override
public ElementMatcher<TypeDescription> hierarchyMatcher() {
return extendsClass(named(hierarchyMarkerType()));
}

@Override
public void methodAdvice(MethodTransformer transformer) {
transformer.applyAdvice(
isMethod().and(named("onStart")),
isMethod().and(named("onStart")).and(takesNoArguments()),
LazyCoroutineInstrumentation.class.getName() + "$OnStartAdvice");
}

Expand Down
Loading