Skip to content

Remove unused ScopeStateAware API #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Remove unused ScopeStateAware API #8529

merged 1 commit into from
Mar 10, 2025
+3 −133

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 8, 2025 •
edited by atlassian bot
Loading

Motivation

With the kotlin coroutines and zio fiber instrumentations migrated to use the new Context API, the ScopeStateAware API can be removed.

Additional Notes

Tests are expected to fail while the scope manager has not yet been replaced.

That's why the final target of this stacked PR is the project/context feature branch.

Contributor Checklist

Jira ticket: APMAPI-963

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 8, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 8, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-scopestateaware-api
git_commit_date 1741423605 1741473826
git_commit_sha 04b1afd 5e870d7
release_version 1.48.0-SNAPSHOT~04b1afde28 1.48.0-SNAPSHOT~5e870d71c2
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741476199 1741476199
ci_job_id 839249086 839249086
ci_pipeline_id 58202326 58202326
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-2wkmbgws-project-304-concurrent-5-6jdi0gno 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-2wkmbgws-project-304-concurrent-5-6jdi0gno 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~5e870d71c2, baseline=1.48.0-SNAPSHOT~04b1afde28

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045970
Total [baseline] (10.483 s) : 0, 10483101
Agent [candidate] (1.047 s) : 0, 1047296
Total [candidate] (10.443 s) : 0, 10443356
section appsec
Agent [baseline] (1.186 s) : 0, 1185610
Total [baseline] (10.802 s) : 0, 10802136
Agent [candidate] (1.184 s) : 0, 1184448
Total [candidate] (10.739 s) : 0, 10739103
section iast
Agent [baseline] (1.182 s) : 0, 1182474
Total [baseline] (10.966 s) : 0, 10966396
Agent [candidate] (1.175 s) : 0, 1175093
Total [candidate] (10.99 s) : 0, 10989557
section profiling
Agent [baseline] (1.259 s) : 0, 1259160
Total [baseline] (10.822 s) : 0, 10821812
Agent [candidate] (1.267 s) : 0, 1266556
Total [candidate] (10.861 s) : 0, 10861010
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.186 s 139.64 ms (13.4%)
Agent iast 1.182 s 136.504 ms (13.1%)
Agent profiling 1.259 s 213.19 ms (20.4%)
Total tracing 10.483 s -
Total appsec 10.802 s 319.035 ms (3.0%)
Total iast 10.966 s 483.295 ms (4.6%)
Total profiling 10.822 s 338.711 ms (3.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.184 s 137.151 ms (13.1%)
Agent iast 1.175 s 127.797 ms (12.2%)
Agent profiling 1.267 s 219.26 ms (20.9%)
Total tracing 10.443 s -
Total appsec 10.739 s 295.746 ms (2.8%)
Total iast 10.99 s 546.2 ms (5.2%)
Total profiling 10.861 s 417.654 ms (4.0%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~5e870d71c2, baseline=1.48.0-SNAPSHOT~04b1afde28

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.867 ms) : 0, 719867
BytebuddyAgent [candidate] (724.357 ms) : 0, 724357
GlobalTracer [baseline] (241.712 ms) : 0, 241712
GlobalTracer [candidate] (241.497 ms) : 0, 241497
AppSec [baseline] (55.793 ms) : 0, 55793
AppSec [candidate] (55.663 ms) : 0, 55663
Remote Config [baseline] (690.775 µs) : 0, 691
Remote Config [candidate] (700.497 µs) : 0, 700
Telemetry [baseline] (12.948 ms) : 0, 12948
Telemetry [candidate] (10.075 ms) : 0, 10075
section appsec
BytebuddyAgent [baseline] (737.672 ms) : 0, 737672
BytebuddyAgent [candidate] (735.45 ms) : 0, 735450
GlobalTracer [baseline] (236.675 ms) : 0, 236675
GlobalTracer [candidate] (237.06 ms) : 0, 237060
AppSec [baseline] (176.645 ms) : 0, 176645
AppSec [candidate] (176.821 ms) : 0, 176821
Remote Config [baseline] (660.739 µs) : 0, 661
Remote Config [candidate] (669.8 µs) : 0, 670
Telemetry [baseline] (8.295 ms) : 0, 8295
Telemetry [candidate] (8.677 ms) : 0, 8677
IAST [baseline] (21.442 ms) : 0, 21442
IAST [candidate] (21.635 ms) : 0, 21635
section iast
BytebuddyAgent [baseline] (844.855 ms) : 0, 844855
BytebuddyAgent [candidate] (840.099 ms) : 0, 840099
GlobalTracer [baseline] (233.177 ms) : 0, 233177
GlobalTracer [candidate] (230.618 ms) : 0, 230618
AppSec [baseline] (56.819 ms) : 0, 56819
AppSec [candidate] (56.917 ms) : 0, 56917
Remote Config [baseline] (614.063 µs) : 0, 614
Remote Config [candidate] (614.15 µs) : 0, 614
Telemetry [baseline] (8.673 ms) : 0, 8673
Telemetry [candidate] (8.771 ms) : 0, 8771
IAST [baseline] (23.338 ms) : 0, 23338
IAST [candidate] (23.062 ms) : 0, 23062
section profiling
BytebuddyAgent [baseline] (708.89 ms) : 0, 708890
BytebuddyAgent [candidate] (713.369 ms) : 0, 713369
GlobalTracer [baseline] (349.167 ms) : 0, 349167
GlobalTracer [candidate] (351.152 ms) : 0, 351152
AppSec [baseline] (55.128 ms) : 0, 55128
AppSec [candidate] (54.586 ms) : 0, 54586
Remote Config [baseline] (683.59 µs) : 0, 684
Remote Config [candidate] (695.04 µs) : 0, 695
Telemetry [baseline] (8.914 ms) : 0, 8914
Telemetry [candidate] (9.023 ms) : 0, 9023
ProfilingAgent [baseline] (96.078 ms) : 0, 96078
ProfilingAgent [candidate] (96.9 ms) : 0, 96900
Profiling [baseline] (96.104 ms) : 0, 96104
Profiling [candidate] (96.924 ms) : 0, 96924
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~5e870d71c2, baseline=1.48.0-SNAPSHOT~04b1afde28

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042357
Total [baseline] (8.654 s) : 0, 8654462
Agent [candidate] (1.042 s) : 0, 1041709
Total [candidate] (8.648 s) : 0, 8648061
section iast
Agent [baseline] (1.169 s) : 0, 1168936
Total [baseline] (9.238 s) : 0, 9238421
Agent [candidate] (1.175 s) : 0, 1175010
Total [candidate] (9.284 s) : 0, 9283530
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1171115
Total [baseline] (9.175 s) : 0, 9175258
Agent [candidate] (1.176 s) : 0, 1176100
Total [candidate] (9.193 s) : 0, 9193240
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168805
Total [baseline] (9.267 s) : 0, 9266666
Agent [candidate] (1.171 s) : 0, 1170795
Total [candidate] (9.227 s) : 0, 9227134
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent iast 1.169 s 126.578 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 128.758 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.169 s 126.448 ms (12.1%)
Total tracing 8.654 s -
Total iast 9.238 s 583.959 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.175 s 520.796 ms (6.0%)
Total iast_TELEMETRY_OFF 9.267 s 612.203 ms (7.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent iast 1.175 s 133.302 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 134.391 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.171 s 129.086 ms (12.4%)
Total tracing 8.648 s -
Total iast 9.284 s 635.469 ms (7.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.193 s 545.179 ms (6.3%)
Total iast_TELEMETRY_OFF 9.227 s 579.073 ms (6.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~5e870d71c2, baseline=1.48.0-SNAPSHOT~04b1afde28

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.057 ms) : 0, 719057
BytebuddyAgent [candidate] (718.943 ms) : 0, 718943
GlobalTracer [baseline] (240.165 ms) : 0, 240165
GlobalTracer [candidate] (239.709 ms) : 0, 239709
AppSec [baseline] (55.294 ms) : 0, 55294
AppSec [candidate] (55.345 ms) : 0, 55345
Remote Config [baseline] (692.457 µs) : 0, 692
Remote Config [candidate] (694.142 µs) : 0, 694
Telemetry [baseline] (12.23 ms) : 0, 12230
Telemetry [candidate] (12.139 ms) : 0, 12139
section iast
BytebuddyAgent [baseline] (835.827 ms) : 0, 835827
BytebuddyAgent [candidate] (840.048 ms) : 0, 840048
GlobalTracer [baseline] (229.6 ms) : 0, 229600
GlobalTracer [candidate] (231.231 ms) : 0, 231231
AppSec [baseline] (56.649 ms) : 0, 56649
AppSec [candidate] (55.769 ms) : 0, 55769
Remote Config [baseline] (614.43 µs) : 0, 614
Remote Config [candidate] (603.974 µs) : 0, 604
Telemetry [baseline] (8.647 ms) : 0, 8647
Telemetry [candidate] (8.748 ms) : 0, 8748
IAST [baseline] (22.697 ms) : 0, 22697
IAST [candidate] (23.625 ms) : 0, 23625
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.854 ms) : 0, 836854
BytebuddyAgent [candidate] (840.321 ms) : 0, 840321
GlobalTracer [baseline] (230.35 ms) : 0, 230350
GlobalTracer [candidate] (231.642 ms) : 0, 231642
AppSec [baseline] (55.895 ms) : 0, 55895
AppSec [candidate] (56.827 ms) : 0, 56827
Remote Config [baseline] (615.477 µs) : 0, 615
Remote Config [candidate] (602.69 µs) : 0, 603
Telemetry [baseline] (8.717 ms) : 0, 8717
Telemetry [candidate] (8.739 ms) : 0, 8739
IAST [baseline] (23.704 ms) : 0, 23704
IAST [candidate] (22.973 ms) : 0, 22973
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.193 ms) : 0, 835193
BytebuddyAgent [candidate] (835.19 ms) : 0, 835190
GlobalTracer [baseline] (230.303 ms) : 0, 230303
GlobalTracer [candidate] (231.233 ms) : 0, 231233
AppSec [baseline] (56.861 ms) : 0, 56861
AppSec [candidate] (57.562 ms) : 0, 57562
Remote Config [baseline] (616.112 µs) : 0, 616
Remote Config [candidate] (615.99 µs) : 0, 616
Telemetry [baseline] (8.646 ms) : 0, 8646
Telemetry [candidate] (8.737 ms) : 0, 8737
IAST [baseline] (22.277 ms) : 0, 22277
IAST [candidate] (22.481 ms) : 0, 22481
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-08T22:53:38 2025-03-08T23:01:23
git_branch master mcculls/remove-scopestateaware-api
git_commit_date 1741423605 1741473826
git_commit_sha 04b1afd 5e870d7
release_version 1.48.0-SNAPSHOT~04b1afde28 1.48.0-SNAPSHOT~5e870d71c2
start_time 2025-03-08T22:53:24 2025-03-08T23:01:09
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741475282 1741475282
ci_job_id 839249087 839249087
ci_pipeline_id 58202326 58202326
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-2wkmbgws-project-304-concurrent-6-ivzfpjw0 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-2wkmbgws-project-304-concurrent-6-ivzfpjw0 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~5e870d71c2, baseline=1.48.0-SNAPSHOT~04b1afde28
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.369 ms) : 1350, 1389
.   : milestone, 1369,
appsec (1.738 ms) : 1715, 1762
.   : milestone, 1738,
appsec_no_iast (1.738 ms) : 1714, 1762
.   : milestone, 1738,
code_origins (1.685 ms) : 1651, 1719
.   : milestone, 1685,
iast (1.505 ms) : 1480, 1529
.   : milestone, 1505,
profiling (1.514 ms) : 1490, 1538
.   : milestone, 1514,
tracing (1.497 ms) : 1472, 1522
.   : milestone, 1497,
section candidate
no_agent (1.355 ms) : 1336, 1374
.   : milestone, 1355,
appsec (1.754 ms) : 1731, 1777
.   : milestone, 1754,
appsec_no_iast (1.745 ms) : 1721, 1769
.   : milestone, 1745,
code_origins (1.652 ms) : 1618, 1685
.   : milestone, 1652,
iast (1.52 ms) : 1495, 1544
.   : milestone, 1520,
profiling (1.524 ms) : 1501, 1547
.   : milestone, 1524,
tracing (1.502 ms) : 1474, 1530
.   : milestone, 1502,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.369 ms [1.35 ms, 1.389 ms] -
appsec 1.738 ms [1.715 ms, 1.762 ms] 368.937 µs (26.9%)
appsec_no_iast 1.738 ms [1.714 ms, 1.762 ms] 368.357 µs (26.9%)
code_origins 1.685 ms [1.651 ms, 1.719 ms] 315.97 µs (23.1%)
iast 1.505 ms [1.48 ms, 1.529 ms] 135.494 µs (9.9%)
profiling 1.514 ms [1.49 ms, 1.538 ms] 144.727 µs (10.6%)
tracing 1.497 ms [1.472 ms, 1.522 ms] 127.521 µs (9.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.374 ms] -
appsec 1.754 ms [1.731 ms, 1.777 ms] 398.952 µs (29.4%)
appsec_no_iast 1.745 ms [1.721 ms, 1.769 ms] 390.382 µs (28.8%)
code_origins 1.652 ms [1.618 ms, 1.685 ms] 296.876 µs (21.9%)
iast 1.52 ms [1.495 ms, 1.544 ms] 164.848 µs (12.2%)
profiling 1.524 ms [1.501 ms, 1.547 ms] 169.272 µs (12.5%)
tracing 1.502 ms [1.474 ms, 1.53 ms] 146.972 µs (10.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~5e870d71c2, baseline=1.48.0-SNAPSHOT~04b1afde28
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.925 µs) : 359, 399
.   : milestone, 379,
iast (516.164 µs) : 494, 538
.   : milestone, 516,
iast_FULL (733.785 µs) : 712, 756
.   : milestone, 734,
iast_GLOBAL (559.719 µs) : 537, 582
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (507.508 µs) : 486, 529
.   : milestone, 508,
iast_INACTIVE (464.576 µs) : 443, 486
.   : milestone, 465,
iast_TELEMETRY_OFF (498.374 µs) : 476, 521
.   : milestone, 498,
tracing (461.605 µs) : 440, 483
.   : milestone, 462,
section candidate
no_agent (382.774 µs) : 363, 402
.   : milestone, 383,
iast (510.426 µs) : 489, 532
.   : milestone, 510,
iast_FULL (727.859 µs) : 706, 750
.   : milestone, 728,
iast_GLOBAL (567.711 µs) : 545, 591
.   : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (514.185 µs) : 492, 537
.   : milestone, 514,
iast_INACTIVE (465.595 µs) : 444, 488
.   : milestone, 466,
iast_TELEMETRY_OFF (507.434 µs) : 486, 529
.   : milestone, 507,
tracing (461.749 µs) : 441, 483
.   : milestone, 462,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.925 µs [359.191 µs, 398.659 µs] -
iast 516.164 µs [494.387 µs, 537.942 µs] 137.239 µs (36.2%)
iast_FULL 733.785 µs [711.899 µs, 755.671 µs] 354.86 µs (93.6%)
iast_GLOBAL 559.719 µs [537.451 µs, 581.987 µs] 180.794 µs (47.7%)
iast_HARDCODED_SECRET_DISABLED 507.508 µs [486.038 µs, 528.977 µs] 128.583 µs (33.9%)
iast_INACTIVE 464.576 µs [443.095 µs, 486.058 µs] 85.652 µs (22.6%)
iast_TELEMETRY_OFF 498.374 µs [475.829 µs, 520.919 µs] 119.45 µs (31.5%)
tracing 461.605 µs [440.058 µs, 483.151 µs] 82.68 µs (21.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.774 µs [363.126 µs, 402.423 µs] -
iast 510.426 µs [488.891 µs, 531.961 µs] 127.652 µs (33.3%)
iast_FULL 727.859 µs [705.848 µs, 749.87 µs] 345.085 µs (90.2%)
iast_GLOBAL 567.711 µs [544.717 µs, 590.706 µs] 184.937 µs (48.3%)
iast_HARDCODED_SECRET_DISABLED 514.185 µs [491.769 µs, 536.6 µs] 131.41 µs (34.3%)
iast_INACTIVE 465.595 µs [443.546 µs, 487.644 µs] 82.82 µs (21.6%)
iast_TELEMETRY_OFF 507.434 µs [485.887 µs, 528.981 µs] 124.66 µs (32.6%)
tracing 461.749 µs [440.574 µs, 482.925 µs] 78.975 µs (20.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/remove-scopestateaware-api
git_commit_date 1741423605 1741473826
git_commit_sha 04b1afd 5e870d7
release_version 1.48.0-SNAPSHOT~04b1afde28 1.48.0-SNAPSHOT~5e870d71c2
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741475802 1741475802
ci_job_id 839249088 839249088
ci_pipeline_id 58202326 58202326
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-2wkmbgws-project-304-concurrent-7-7kxvmkxh 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-2wkmbgws-project-304-concurrent-7-7kxvmkxh 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~5e870d71c2, baseline=1.48.0-SNAPSHOT~04b1afde28
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.907 s) : 14907000, 14907000
.   : milestone, 14907000,
appsec (15.143 s) : 15143000, 15143000
.   : milestone, 15143000,
iast (18.674 s) : 18674000, 18674000
.   : milestone, 18674000,
iast_GLOBAL (18.137 s) : 18137000, 18137000
.   : milestone, 18137000,
profiling (15.113 s) : 15113000, 15113000
.   : milestone, 15113000,
tracing (14.692 s) : 14692000, 14692000
.   : milestone, 14692000,
section candidate
no_agent (15.48 s) : 15480000, 15480000
.   : milestone, 15480000,
appsec (15.198 s) : 15198000, 15198000
.   : milestone, 15198000,
iast (18.798 s) : 18798000, 18798000
.   : milestone, 18798000,
iast_GLOBAL (18.07 s) : 18070000, 18070000
.   : milestone, 18070000,
profiling (15.084 s) : 15084000, 15084000
.   : milestone, 15084000,
tracing (15.186 s) : 15186000, 15186000
.   : milestone, 15186000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.907 s [14.907 s, 14.907 s] -
appsec 15.143 s [15.143 s, 15.143 s] 236.0 ms (1.6%)
iast 18.674 s [18.674 s, 18.674 s] 3.767 s (25.3%)
iast_GLOBAL 18.137 s [18.137 s, 18.137 s] 3.23 s (21.7%)
profiling 15.113 s [15.113 s, 15.113 s] 206.0 ms (1.4%)
tracing 14.692 s [14.692 s, 14.692 s] -215.0 ms (-1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.48 s [15.48 s, 15.48 s] -
appsec 15.198 s [15.198 s, 15.198 s] -282.0 ms (-1.8%)
iast 18.798 s [18.798 s, 18.798 s] 3.318 s (21.4%)
iast_GLOBAL 18.07 s [18.07 s, 18.07 s] 2.59 s (16.7%)
profiling 15.084 s [15.084 s, 15.084 s] -396.0 ms (-2.6%)
tracing 15.186 s [15.186 s, 15.186 s] -294.0 ms (-1.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~5e870d71c2, baseline=1.48.0-SNAPSHOT~04b1afde28
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.322 ms) : 2279, 2365
.   : milestone, 2322,
iast (2.103 ms) : 2049, 2157
.   : milestone, 2103,
iast_GLOBAL (2.147 ms) : 2092, 2201
.   : milestone, 2147,
profiling (1.985 ms) : 1941, 2029
.   : milestone, 1985,
tracing (1.94 ms) : 1898, 1981
.   : milestone, 1940,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.33 ms) : 2287, 2373
.   : milestone, 2330,
iast (2.101 ms) : 2047, 2156
.   : milestone, 2101,
iast_GLOBAL (2.158 ms) : 2103, 2213
.   : milestone, 2158,
profiling (2.412 ms) : 2236, 2588
.   : milestone, 2412,
tracing (1.951 ms) : 1908, 1993
.   : milestone, 1951,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.322 ms [2.279 ms, 2.365 ms] 853.469 µs (58.1%)
iast 2.103 ms [2.049 ms, 2.157 ms] 634.428 µs (43.2%)
iast_GLOBAL 2.147 ms [2.092 ms, 2.201 ms] 677.835 µs (46.2%)
profiling 1.985 ms [1.941 ms, 2.029 ms] 516.601 µs (35.2%)
tracing 1.94 ms [1.898 ms, 1.981 ms] 470.865 µs (32.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 2.33 ms [2.287 ms, 2.373 ms] 857.668 µs (58.3%)
iast 2.101 ms [2.047 ms, 2.156 ms] 629.069 µs (42.7%)
iast_GLOBAL 2.158 ms [2.103 ms, 2.213 ms] 685.879 µs (46.6%)
profiling 2.412 ms [2.236 ms, 2.588 ms] 939.824 µs (63.8%)
tracing 1.951 ms [1.908 ms, 1.993 ms] 478.479 µs (32.5%)

@mcculls mcculls requested a review from PerfectSlayer March 9, 2025 22:26
PerfectSlayer
PerfectSlayer approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Glad this goes away :)

@mcculls mcculls force-pushed the mcculls/use-context-in-kotlin-coroutines branch from f3c421a to 8861c68 Compare March 10, 2025 13:03
Base automatically changed from mcculls/use-context-in-kotlin-coroutines to project/context March 10, 2025 13:05
@mcculls mcculls force-pushed the mcculls/remove-scopestateaware-api branch from 5e870d7 to 7724a95 Compare March 10, 2025 13:05
@mcculls mcculls marked this pull request as ready for review March 10, 2025 13:06
@mcculls mcculls requested a review from a team as a code owner March 10, 2025 13:06
@mcculls mcculls requested a review from ygree March 10, 2025 13:06
@mcculls mcculls merged commit 2512090 into project/context Mar 10, 2025
2 of 13 checks passed
@mcculls mcculls deleted the mcculls/remove-scopestateaware-api branch March 10, 2025 13:06
mcculls added a commit that referenced this pull request Mar 15, 2025
@mcculls
Remove unused ScopeStateAware API (#8529)
8d4fb04
mcculls added a commit that referenced this pull request Mar 17, 2025
@mcculls
Remove unused ScopeStateAware API (#8529)
f84f5d9
mcculls added a commit that referenced this pull request Mar 18, 2025
@mcculls
Remove unused ScopeStateAware API (#8529)
ab36a1a
mcculls added a commit that referenced this pull request Mar 18, 2025
@mcculls
Remove unused ScopeStateAware API (#8529)
0b4a19d
mcculls added a commit that referenced this pull request Mar 18, 2025
@mcculls
Remove unused ScopeStateAware API (#8529)
79ba55c
mcculls added a commit that referenced this pull request Mar 19, 2025
@mcculls
Remove unused ScopeStateAware API (#8529)
d63c070
mcculls added a commit that referenced this pull request Mar 21, 2025
@mcculls
Remove unused ScopeStateAware API (#8529)
2181a98
mcculls added a commit that referenced this pull request Mar 26, 2025
@mcculls
Remove unused ScopeStateAware API (#8529)
9a869ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcculls @PerfectSlayer