Skip to content

Do not generate Muzzle references for primitive arrays in method body #8361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Do not generate Muzzle references for primitive arrays in method body #8361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...gent/agent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/ReferenceCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,9 @@ public void visitMethodInsn(

@Override
public void visitTypeInsn(final int opcode, final String stype) {
if (ignoreReference(stype)) {
return;
}
Type type = underlyingType(Type.getObjectType(stype));

if (ignoreReference(type.getInternalName())) {
Expand Down
4 changes: 4 additions & 0 deletions ...ent/agent-tooling/src/test/java/datadog/trace/agent/tooling/muzzle/TestAdviceClasses.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ public static void methodBodyAdvice() {
a.b.aMethodWithArrays(new String[0]);
B.aStaticMethod();
A.staticB.aMethod("bar");
Object barr = new byte[0];
if (barr instanceof byte[]) {
barr = null;
}
}

public static class A {
Expand Down
Loading