-
Notifications
You must be signed in to change notification settings - Fork 315
Add APPSEC_WAF_TELEMETRY to system-tests #8329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
approved these changes
Feb 3, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~fb28effa70, baseline=1.47.0-SNAPSHOT~eef31bc8ed
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049239
Total [baseline] (8.647 s) : 0, 8646969
Agent [candidate] (1.043 s) : 0, 1043046
Total [candidate] (8.636 s) : 0, 8635805
section iast
Agent [baseline] (1.172 s) : 0, 1171823
Total [baseline] (9.212 s) : 0, 9212009
Agent [candidate] (1.174 s) : 0, 1174286
Total [candidate] (9.252 s) : 0, 9252352
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.187 s) : 0, 1187491
Total [baseline] (9.283 s) : 0, 9282783
Agent [candidate] (1.194 s) : 0, 1193918
Total [candidate] (9.295 s) : 0, 9294609
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170187
Total [baseline] (9.271 s) : 0, 9270960
Agent [candidate] (1.168 s) : 0, 1167888
Total [candidate] (9.254 s) : 0, 9254217
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~fb28effa70, baseline=1.47.0-SNAPSHOT~eef31bc8ed
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.667 ms) : 0, 719667
BytebuddyAgent [candidate] (715.25 ms) : 0, 715250
GlobalTracer [baseline] (245.417 ms) : 0, 245417
GlobalTracer [candidate] (243.115 ms) : 0, 243115
AppSec [baseline] (55.207 ms) : 0, 55207
AppSec [candidate] (55.13 ms) : 0, 55130
Remote Config [baseline] (716.609 µs) : 0, 717
Remote Config [candidate] (708.741 µs) : 0, 709
Telemetry [baseline] (12.936 ms) : 0, 12936
Telemetry [candidate] (13.69 ms) : 0, 13690
section iast
BytebuddyAgent [baseline] (833.764 ms) : 0, 833764
BytebuddyAgent [candidate] (837.681 ms) : 0, 837681
GlobalTracer [baseline] (233.841 ms) : 0, 233841
GlobalTracer [candidate] (233.188 ms) : 0, 233188
IAST [baseline] (22.604 ms) : 0, 22604
IAST [candidate] (26.233 ms) : 0, 26233
AppSec [baseline] (57.113 ms) : 0, 57113
AppSec [candidate] (52.638 ms) : 0, 52638
Remote Config [baseline] (605.856 µs) : 0, 606
Remote Config [candidate] (601.342 µs) : 0, 601
Telemetry [baseline] (8.67 ms) : 0, 8670
Telemetry [candidate] (8.633 ms) : 0, 8633
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (845.969 ms) : 0, 845969
BytebuddyAgent [candidate] (850.016 ms) : 0, 850016
GlobalTracer [baseline] (236.173 ms) : 0, 236173
GlobalTracer [candidate] (237.565 ms) : 0, 237565
IAST [baseline] (26.953 ms) : 0, 26953
IAST [candidate] (28.023 ms) : 0, 28023
AppSec [baseline] (53.333 ms) : 0, 53333
AppSec [candidate] (53.023 ms) : 0, 53023
Remote Config [baseline] (619.179 µs) : 0, 619
Remote Config [candidate] (634.266 µs) : 0, 634
Telemetry [baseline] (8.882 ms) : 0, 8882
Telemetry [candidate] (9.031 ms) : 0, 9031
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.15 ms) : 0, 832150
BytebuddyAgent [candidate] (830.615 ms) : 0, 830615
GlobalTracer [baseline] (234.258 ms) : 0, 234258
GlobalTracer [candidate] (233.733 ms) : 0, 233733
IAST [baseline] (26.294 ms) : 0, 26294
IAST [candidate] (26.911 ms) : 0, 26911
AppSec [baseline] (53.027 ms) : 0, 53027
AppSec [candidate] (52.158 ms) : 0, 52158
Remote Config [baseline] (610.074 µs) : 0, 610
Remote Config [candidate] (622.038 µs) : 0, 622
Telemetry [baseline] (8.586 ms) : 0, 8586
Telemetry [candidate] (8.586 ms) : 0, 8586
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~fb28effa70, baseline=1.47.0-SNAPSHOT~eef31bc8ed
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049463
Total [baseline] (10.573 s) : 0, 10572875
Agent [candidate] (1.042 s) : 0, 1042211
Total [candidate] (10.502 s) : 0, 10501715
section appsec
Agent [baseline] (1.186 s) : 0, 1185865
Total [baseline] (10.785 s) : 0, 10785174
Agent [candidate] (1.186 s) : 0, 1186466
Total [candidate] (10.793 s) : 0, 10792641
section iast
Agent [baseline] (1.176 s) : 0, 1175542
Total [baseline] (11.012 s) : 0, 11011860
Agent [candidate] (1.19 s) : 0, 1189807
Total [candidate] (11.007 s) : 0, 11007360
section profiling
Agent [baseline] (1.262 s) : 0, 1261913
Total [baseline] (10.895 s) : 0, 10895092
Agent [candidate] (1.262 s) : 0, 1261510
Total [candidate] (10.917 s) : 0, 10917003
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~fb28effa70, baseline=1.47.0-SNAPSHOT~eef31bc8ed
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.489 ms) : 0, 718489
BytebuddyAgent [candidate] (715.265 ms) : 0, 715265
GlobalTracer [baseline] (243.652 ms) : 0, 243652
GlobalTracer [candidate] (243.13 ms) : 0, 243130
AppSec [baseline] (55.172 ms) : 0, 55172
AppSec [candidate] (55.16 ms) : 0, 55160
Remote Config [baseline] (722.562 µs) : 0, 723
Remote Config [candidate] (718.771 µs) : 0, 719
Telemetry [baseline] (16.152 ms) : 0, 16152
Telemetry [candidate] (12.719 ms) : 0, 12719
section appsec
BytebuddyAgent [baseline] (734.509 ms) : 0, 734509
BytebuddyAgent [candidate] (734.453 ms) : 0, 734453
GlobalTracer [baseline] (240.506 ms) : 0, 240506
GlobalTracer [candidate] (240.909 ms) : 0, 240909
AppSec [baseline] (175.411 ms) : 0, 175411
AppSec [candidate] (175.893 ms) : 0, 175893
Remote Config [baseline] (660.95 µs) : 0, 661
Remote Config [candidate] (648.027 µs) : 0, 648
Telemetry [baseline] (8.642 ms) : 0, 8642
Telemetry [candidate] (8.612 ms) : 0, 8612
IAST [baseline] (21.635 ms) : 0, 21635
IAST [candidate] (21.39 ms) : 0, 21390
section iast
BytebuddyAgent [baseline] (836.508 ms) : 0, 836508
BytebuddyAgent [candidate] (846.973 ms) : 0, 846973
GlobalTracer [baseline] (234.567 ms) : 0, 234567
GlobalTracer [candidate] (237.17 ms) : 0, 237170
AppSec [baseline] (54.866 ms) : 0, 54866
AppSec [candidate] (56.656 ms) : 0, 56656
Remote Config [baseline] (613.575 µs) : 0, 614
Remote Config [candidate] (640.714 µs) : 0, 641
Telemetry [baseline] (8.724 ms) : 0, 8724
Telemetry [candidate] (8.835 ms) : 0, 8835
IAST [baseline] (24.932 ms) : 0, 24932
IAST [candidate] (23.957 ms) : 0, 23957
section profiling
ProfilingAgent [baseline] (95.94 ms) : 0, 95940
ProfilingAgent [candidate] (94.77 ms) : 0, 94770
BytebuddyAgent [baseline] (705.737 ms) : 0, 705737
BytebuddyAgent [candidate] (707.176 ms) : 0, 707176
GlobalTracer [baseline] (353.205 ms) : 0, 353205
GlobalTracer [candidate] (353.436 ms) : 0, 353436
AppSec [baseline] (55.12 ms) : 0, 55120
AppSec [candidate] (54.16 ms) : 0, 54160
Remote Config [baseline] (702.323 µs) : 0, 702
Remote Config [candidate] (707.642 µs) : 0, 708
Telemetry [baseline] (8.851 ms) : 0, 8851
Telemetry [candidate] (8.939 ms) : 0, 8939
Profiling [baseline] (95.965 ms) : 0, 95965
Profiling [candidate] (94.795 ms) : 0, 94795
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~fb28effa70, baseline=1.47.0-SNAPSHOT~eef31bc8ed
dateFormat X
axisFormat %s
section baseline
no_agent (385.7 µs) : 366, 405
. : milestone, 386,
iast (515.066 µs) : 493, 537
. : milestone, 515,
iast_FULL (748.296 µs) : 726, 770
. : milestone, 748,
iast_GLOBAL (561.179 µs) : 539, 584
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (512.395 µs) : 491, 534
. : milestone, 512,
iast_INACTIVE (466.08 µs) : 445, 487
. : milestone, 466,
iast_TELEMETRY_OFF (505.071 µs) : 482, 528
. : milestone, 505,
tracing (461.849 µs) : 441, 483
. : milestone, 462,
section candidate
no_agent (386.162 µs) : 366, 406
. : milestone, 386,
iast (520.424 µs) : 498, 543
. : milestone, 520,
iast_FULL (745.088 µs) : 723, 767
. : milestone, 745,
iast_GLOBAL (570.617 µs) : 548, 594
. : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (512.819 µs) : 491, 535
. : milestone, 513,
iast_INACTIVE (473.32 µs) : 452, 495
. : milestone, 473,
iast_TELEMETRY_OFF (505.603 µs) : 482, 529
. : milestone, 506,
tracing (457.457 µs) : 436, 478
. : milestone, 457,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~fb28effa70, baseline=1.47.0-SNAPSHOT~eef31bc8ed
dateFormat X
axisFormat %s
section baseline
no_agent (1.377 ms) : 1357, 1396
. : milestone, 1377,
appsec (1.754 ms) : 1731, 1778
. : milestone, 1754,
appsec_no_iast (1.75 ms) : 1727, 1774
. : milestone, 1750,
iast (1.526 ms) : 1501, 1550
. : milestone, 1526,
profiling (1.515 ms) : 1492, 1538
. : milestone, 1515,
tracing (1.488 ms) : 1463, 1513
. : milestone, 1488,
section candidate
no_agent (1.367 ms) : 1348, 1386
. : milestone, 1367,
appsec (1.771 ms) : 1748, 1794
. : milestone, 1771,
appsec_no_iast (1.746 ms) : 1721, 1771
. : milestone, 1746,
iast (1.525 ms) : 1500, 1550
. : milestone, 1525,
profiling (1.546 ms) : 1522, 1571
. : milestone, 1546,
tracing (1.506 ms) : 1482, 1530
. : milestone, 1506,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~fb28effa70, baseline=1.47.0-SNAPSHOT~eef31bc8ed
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.373 ms) : 2330, 2417
. : milestone, 2373,
iast (2.112 ms) : 2057, 2167
. : milestone, 2112,
iast_GLOBAL (2.156 ms) : 2101, 2211
. : milestone, 2156,
profiling (1.981 ms) : 1937, 2026
. : milestone, 1981,
tracing (1.947 ms) : 1905, 1989
. : milestone, 1947,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.362 ms) : 2319, 2405
. : milestone, 2362,
iast (2.1 ms) : 2046, 2155
. : milestone, 2100,
iast_GLOBAL (2.163 ms) : 2108, 2218
. : milestone, 2163,
profiling (1.974 ms) : 1930, 2018
. : milestone, 1974,
tracing (1.952 ms) : 1910, 1994
. : milestone, 1952,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~fb28effa70, baseline=1.47.0-SNAPSHOT~eef31bc8ed
dateFormat X
axisFormat %s
section baseline
no_agent (15.049 s) : 15049000, 15049000
. : milestone, 15049000,
appsec (14.984 s) : 14984000, 14984000
. : milestone, 14984000,
iast (19.025 s) : 19025000, 19025000
. : milestone, 19025000,
iast_GLOBAL (18.068 s) : 18068000, 18068000
. : milestone, 18068000,
profiling (14.978 s) : 14978000, 14978000
. : milestone, 14978000,
tracing (14.756 s) : 14756000, 14756000
. : milestone, 14756000,
section candidate
no_agent (14.74 s) : 14740000, 14740000
. : milestone, 14740000,
appsec (15.2 s) : 15200000, 15200000
. : milestone, 15200000,
iast (19.022 s) : 19022000, 19022000
. : milestone, 19022000,
iast_GLOBAL (18.163 s) : 18163000, 18163000
. : milestone, 18163000,
profiling (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
tracing (15.176 s) : 15176000, 15176000
. : milestone, 15176000,
|
manuel-alvarez-alvarez
approved these changes
Feb 4, 2025
770a887 to
fb28eff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
comp: testing
Testing
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This introduces a new scenario for running WAF telemetry tests within the system-tests.
Motivation
Currently, changes to WAF telemetry do not verify whether the system-tests execute correctly. We aim to prevent misalignment between the system-tests and the tracer.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-56478