Skip to content

Fix debugger batch upload URL when using UDS #7166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix debugger batch upload URL when using UDS #7166

merged 1 commit into from
Jun 12, 2024

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Jun 11, 2024

These direct uses of Config.agentUrl were missed in #7094

This PR fixes them the same way we fixed uses of Config.getAgentUrl() in the original PR; i.e. when using UDS any endpoint using Config.agentUrl directly rather than SharedCommunicationObjects should use a placeholder of http://${agentHost}:${agentPort} instead of unix:... to satisfy OkHttp's HttpUrl.get.

This is necessary because the agentUrl captured in Config will now preserve the original connection string, which when using UDS will start with unix:. This protocol will be rejected by OkHttp's HttpUrl.get, so to satisfy that call we use the above http: placeholder - note the actual connection will be tunnelled over UDS, which is why the URL is a placeholder.

Ideally all remote connections to the agent will eventually migrate to use SharedCommunicationObjects to avoid having to repeat this.

@mcculls mcculls added the comp: debugger Dynamic Instrumentation label Jun 11, 2024
@mcculls mcculls requested a review from a team as a code owner June 11, 2024 23:21
@mcculls mcculls requested review from am312 and dougqh June 11, 2024 23:21
@mcculls mcculls mentioned this pull request Jun 11, 2024
Closed
@mcculls mcculls requested a review from jpbempel June 11, 2024 23:31
@pr-commenter
Copy link

pr-commenter bot commented Jun 12, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/fix-debugger-endpoints-with-uds
git_commit_date 1718118542 1718146820
git_commit_sha 54461ee 7145fa8
release_version 1.36.0-SNAPSHOT~54461eefea 1.36.0-SNAPSHOT~7145fa8107
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718150808 1718150808
ci_job_id 540112218 540112218
ci_pipeline_id 36473002 36473002
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 17 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~7145fa8107, baseline=1.36.0-SNAPSHOT~54461eefea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.578 s) : 0, 1578417
Total [baseline] (11.917 s) : 0, 11917389
Agent [candidate] (1.577 s) : 0, 1577447
Total [candidate] (11.9 s) : 0, 11900100
section iast
Agent [baseline] (1.706 s) : 0, 1705724
Total [baseline] (12.544 s) : 0, 12543683
Agent [candidate] (1.709 s) : 0, 1708712
Total [candidate] (12.561 s) : 0, 12561397
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.719 s) : 0, 1719120
Total [baseline] (12.534 s) : 0, 12533865
Agent [candidate] (1.714 s) : 0, 1714420
Total [candidate] (12.505 s) : 0, 12505429
section iast_TELEMETRY_OFF
Agent [baseline] (1.707 s) : 0, 1707049
Total [baseline] (12.544 s) : 0, 12544382
Agent [candidate] (1.711 s) : 0, 1710812
Total [candidate] (12.573 s) : 0, 12572823
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.578 s -
Agent iast 1.706 s 127.307 ms (8.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.719 s 140.703 ms (8.9%)
Agent iast_TELEMETRY_OFF 1.707 s 128.632 ms (8.1%)
Total tracing 11.917 s -
Total iast 12.544 s 626.293 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 12.534 s 616.476 ms (5.2%)
Total iast_TELEMETRY_OFF 12.544 s 626.993 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.577 s -
Agent iast 1.709 s 131.265 ms (8.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.714 s 136.973 ms (8.7%)
Agent iast_TELEMETRY_OFF 1.711 s 133.365 ms (8.5%)
Total tracing 11.9 s -
Total iast 12.561 s 661.297 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 12.505 s 605.329 ms (5.1%)
Total iast_TELEMETRY_OFF 12.573 s 672.723 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~7145fa8107, baseline=1.36.0-SNAPSHOT~54461eefea

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (984.745 ms) : 0, 984745
BytebuddyAgent [candidate] (984.687 ms) : 0, 984687
GlobalTracer [baseline] (450.409 ms) : 0, 450409
GlobalTracer [candidate] (449.784 ms) : 0, 449784
AppSec [baseline] (71.65 ms) : 0, 71650
AppSec [candidate] (71.403 ms) : 0, 71403
Logs Intake [baseline] (419.946 µs) : 0, 420
Logs Intake [candidate] (410.967 µs) : 0, 411
Remote Config [baseline] (870.268 µs) : 0, 870
Remote Config [candidate] (897.999 µs) : 0, 898
Telemetry [baseline] (9.845 ms) : 0, 9845
Telemetry [candidate] (9.778 ms) : 0, 9778
section iast
BytebuddyAgent [baseline] (1.144 s) : 0, 1144457
BytebuddyAgent [candidate] (1.146 s) : 0, 1146194
GlobalTracer [baseline] (431.47 ms) : 0, 431470
GlobalTracer [candidate] (432.583 ms) : 0, 432583
AppSec [baseline] (67.126 ms) : 0, 67126
AppSec [candidate] (66.348 ms) : 0, 66348
IAST [baseline] (27.445 ms) : 0, 27445
IAST [candidate] (30.208 ms) : 0, 30208
Logs Intake [baseline] (398.57 µs) : 0, 399
Logs Intake [candidate] (389.702 µs) : 0, 390
Remote Config [baseline] (761.475 µs) : 0, 761
Remote Config [candidate] (1.518 ms) : 0, 1518
Telemetry [baseline] (14.397 ms) : 0, 14397
Telemetry [candidate] (11.72 ms) : 0, 11720
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.152 s) : 0, 1152231
BytebuddyAgent [candidate] (1.149 s) : 0, 1149154
GlobalTracer [baseline] (434.172 ms) : 0, 434172
GlobalTracer [candidate] (433.719 ms) : 0, 433719
AppSec [baseline] (67.364 ms) : 0, 67364
AppSec [candidate] (67.488 ms) : 0, 67488
IAST [baseline] (32.675 ms) : 0, 32675
IAST [candidate] (33.948 ms) : 0, 33948
Logs Intake [baseline] (400.787 µs) : 0, 401
Logs Intake [candidate] (387.003 µs) : 0, 387
Remote Config [baseline] (773.256 µs) : 0, 773
Remote Config [candidate] (760.907 µs) : 0, 761
Telemetry [baseline] (11.612 ms) : 0, 11612
Telemetry [candidate] (9.077 ms) : 0, 9077
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.143 s) : 0, 1143298
BytebuddyAgent [candidate] (1.146 s) : 0, 1145840
GlobalTracer [baseline] (434.207 ms) : 0, 434207
GlobalTracer [candidate] (433.236 ms) : 0, 433236
AppSec [baseline] (68.292 ms) : 0, 68292
AppSec [candidate] (68.161 ms) : 0, 68161
IAST [baseline] (29.726 ms) : 0, 29726
IAST [candidate] (33.534 ms) : 0, 33534
Logs Intake [baseline] (392.957 µs) : 0, 393
Logs Intake [candidate] (389.054 µs) : 0, 389
Remote Config [baseline] (752.696 µs) : 0, 753
Remote Config [candidate] (750.693 µs) : 0, 751
Telemetry [baseline] (10.611 ms) : 0, 10611
Telemetry [candidate] (8.94 ms) : 0, 8940
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~7145fa8107, baseline=1.36.0-SNAPSHOT~54461eefea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.58 s) : 0, 1579729
Total [baseline] (14.384 s) : 0, 14383946
Agent [candidate] (1.583 s) : 0, 1583262
Total [candidate] (14.421 s) : 0, 14420777
section appsec
Agent [baseline] (1.759 s) : 0, 1759323
Total [baseline] (14.45 s) : 0, 14449749
Agent [candidate] (1.757 s) : 0, 1757222
Total [candidate] (14.449 s) : 0, 14448552
section iast
Agent [baseline] (1.705 s) : 0, 1704907
Total [baseline] (14.721 s) : 0, 14720857
Agent [candidate] (1.725 s) : 0, 1724665
Total [candidate] (14.891 s) : 0, 14891297
section profiling
Agent [baseline] (1.894 s) : 0, 1893716
Total [baseline] (14.745 s) : 0, 14744533
Agent [candidate] (1.895 s) : 0, 1894926
Total [candidate] (14.665 s) : 0, 14665313
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.58 s -
Agent appsec 1.759 s 179.594 ms (11.4%)
Agent iast 1.705 s 125.179 ms (7.9%)
Agent profiling 1.894 s 313.988 ms (19.9%)
Total tracing 14.384 s -
Total appsec 14.45 s 65.803 ms (0.5%)
Total iast 14.721 s 336.911 ms (2.3%)
Total profiling 14.745 s 360.587 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.583 s -
Agent appsec 1.757 s 173.961 ms (11.0%)
Agent iast 1.725 s 141.404 ms (8.9%)
Agent profiling 1.895 s 311.665 ms (19.7%)
Total tracing 14.421 s -
Total appsec 14.449 s 27.775 ms (0.2%)
Total iast 14.891 s 470.521 ms (3.3%)
Total profiling 14.665 s 244.536 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~7145fa8107, baseline=1.36.0-SNAPSHOT~54461eefea

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (985.644 ms) : 0, 985644
BytebuddyAgent [candidate] (989.182 ms) : 0, 989182
GlobalTracer [baseline] (451.056 ms) : 0, 451056
GlobalTracer [candidate] (451.097 ms) : 0, 451097
AppSec [baseline] (71.527 ms) : 0, 71527
AppSec [candidate] (71.167 ms) : 0, 71167
Logs Intake [baseline] (413.659 µs) : 0, 414
Logs Intake [candidate] (416.608 µs) : 0, 417
Remote Config [baseline] (859.185 µs) : 0, 859
Remote Config [candidate] (863.499 µs) : 0, 863
Telemetry [baseline] (9.754 ms) : 0, 9754
Telemetry [candidate] (9.831 ms) : 0, 9831
section appsec
BytebuddyAgent [baseline] (1.003 s) : 0, 1003186
BytebuddyAgent [candidate] (1.001 s) : 0, 1000986
GlobalTracer [baseline] (441.248 ms) : 0, 441248
GlobalTracer [candidate] (441.679 ms) : 0, 441679
AppSec [baseline] (231.758 ms) : 0, 231758
AppSec [candidate] (231.457 ms) : 0, 231457
Logs Intake [baseline] (416.917 µs) : 0, 417
Logs Intake [candidate] (413.375 µs) : 0, 413
Remote Config [baseline] (787.299 µs) : 0, 787
Remote Config [candidate] (770.837 µs) : 0, 771
Telemetry [baseline] (8.903 ms) : 0, 8903
Telemetry [candidate] (9.226 ms) : 0, 9226
IAST [baseline] (24.913 ms) : 0, 24913
IAST [candidate] (24.142 ms) : 0, 24142
section iast
BytebuddyAgent [baseline] (1.145 s) : 0, 1145299
BytebuddyAgent [candidate] (1.158 s) : 0, 1157531
GlobalTracer [baseline] (431.948 ms) : 0, 431948
GlobalTracer [candidate] (436.409 ms) : 0, 436409
AppSec [baseline] (65.807 ms) : 0, 65807
AppSec [candidate] (67.354 ms) : 0, 67354
Logs Intake [baseline] (390.707 µs) : 0, 391
Logs Intake [candidate] (415.541 µs) : 0, 416
Remote Config [baseline] (757.969 µs) : 0, 758
Remote Config [candidate] (788.038 µs) : 0, 788
Telemetry [baseline] (10.961 ms) : 0, 10961
Telemetry [candidate] (11.788 ms) : 0, 11788
IAST [baseline] (30.095 ms) : 0, 30095
IAST [candidate] (30.474 ms) : 0, 30474
section profiling
ProfilingAgent [baseline] (153.617 ms) : 0, 153617
ProfilingAgent [candidate] (155.696 ms) : 0, 155696
BytebuddyAgent [baseline] (983.08 ms) : 0, 983080
BytebuddyAgent [candidate] (983.256 ms) : 0, 983256
GlobalTracer [baseline] (579.526 ms) : 0, 579526
GlobalTracer [candidate] (578.689 ms) : 0, 578689
AppSec [baseline] (73.121 ms) : 0, 73121
AppSec [candidate] (72.932 ms) : 0, 72932
Logs Intake [baseline] (419.246 µs) : 0, 419
Logs Intake [candidate] (412.435 µs) : 0, 412
Remote Config [baseline] (950.676 µs) : 0, 951
Remote Config [candidate] (961.305 µs) : 0, 961
Telemetry [baseline] (9.514 ms) : 0, 9514
Telemetry [candidate] (9.442 ms) : 0, 9442
Profiling [baseline] (153.685 ms) : 0, 153685
Profiling [candidate] (155.772 ms) : 0, 155772
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-11T23:26:20 2024-06-11T23:35:23
git_branch master mcculls/fix-debugger-endpoints-with-uds
git_commit_date 1718118542 1718146820
git_commit_sha 54461ee 7145fa8
release_version 1.36.0-SNAPSHOT~54461eefea 1.36.0-SNAPSHOT~7145fa8107
start_time 2024-06-11T23:26:04 2024-06-11T23:35:06
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718149380 1718149380
ci_job_id 540112219 540112219
ci_pipeline_id 36473002 36473002
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 22 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~7145fa8107, baseline=1.36.0-SNAPSHOT~54461eefea
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.707 ms) : 1682, 1731
.   : milestone, 1707,
appsec (2.179 ms) : 2148, 2210
.   : milestone, 2179,
appsec_no_iast (2.191 ms) : 2159, 2223
.   : milestone, 2191,
iast (1.881 ms) : 1852, 1911
.   : milestone, 1881,
profiling (1.929 ms) : 1892, 1965
.   : milestone, 1929,
tracing (1.86 ms) : 1828, 1892
.   : milestone, 1860,
section candidate
no_agent (1.708 ms) : 1683, 1733
.   : milestone, 1708,
appsec (2.195 ms) : 2164, 2226
.   : milestone, 2195,
appsec_no_iast (2.169 ms) : 2138, 2201
.   : milestone, 2169,
iast (1.854 ms) : 1824, 1884
.   : milestone, 1854,
profiling (1.954 ms) : 1917, 1991
.   : milestone, 1954,
tracing (1.879 ms) : 1847, 1910
.   : milestone, 1879,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.707 ms [1.682 ms, 1.731 ms] -
appsec 2.179 ms [2.148 ms, 2.21 ms] 472.145 µs (27.7%)
appsec_no_iast 2.191 ms [2.159 ms, 2.223 ms] 483.951 µs (28.4%)
iast 1.881 ms [1.852 ms, 1.911 ms] 174.584 µs (10.2%)
profiling 1.929 ms [1.892 ms, 1.965 ms] 221.83 µs (13.0%)
tracing 1.86 ms [1.828 ms, 1.892 ms] 153.213 µs (9.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.708 ms [1.683 ms, 1.733 ms] -
appsec 2.195 ms [2.164 ms, 2.226 ms] 487.299 µs (28.5%)
appsec_no_iast 2.169 ms [2.138 ms, 2.201 ms] 461.47 µs (27.0%)
iast 1.854 ms [1.824 ms, 1.884 ms] 146.198 µs (8.6%)
profiling 1.954 ms [1.917 ms, 1.991 ms] 246.16 µs (14.4%)
tracing 1.879 ms [1.847 ms, 1.91 ms] 170.945 µs (10.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~7145fa8107, baseline=1.36.0-SNAPSHOT~54461eefea
    dateFormat X
    axisFormat %s
section baseline
no_agent (451.894 µs) : 423, 481
.   : milestone, 452,
iast (588.942 µs) : 557, 621
.   : milestone, 589,
iast_FULL (684.696 µs) : 653, 716
.   : milestone, 685,
iast_GLOBAL (623.608 µs) : 592, 655
.   : milestone, 624,
iast_HARDCODED_SECRET_DISABLED (589.237 µs) : 558, 621
.   : milestone, 589,
iast_INACTIVE (553.164 µs) : 522, 584
.   : milestone, 553,
iast_TELEMETRY_OFF (578.504 µs) : 547, 610
.   : milestone, 579,
tracing (539.03 µs) : 509, 569
.   : milestone, 539,
section candidate
no_agent (448.502 µs) : 420, 477
.   : milestone, 449,
iast (587.207 µs) : 555, 619
.   : milestone, 587,
iast_FULL (680.987 µs) : 649, 713
.   : milestone, 681,
iast_GLOBAL (622.328 µs) : 591, 654
.   : milestone, 622,
iast_HARDCODED_SECRET_DISABLED (584.97 µs) : 554, 616
.   : milestone, 585,
iast_INACTIVE (559.999 µs) : 529, 591
.   : milestone, 560,
iast_TELEMETRY_OFF (576.907 µs) : 545, 608
.   : milestone, 577,
tracing (543.973 µs) : 514, 574
.   : milestone, 544,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 451.894 µs [422.803 µs, 480.985 µs] -
iast 588.942 µs [557.119 µs, 620.766 µs] 137.048 µs (30.3%)
iast_FULL 684.696 µs [653.132 µs, 716.26 µs] 232.802 µs (51.5%)
iast_GLOBAL 623.608 µs [591.866 µs, 655.35 µs] 171.714 µs (38.0%)
iast_HARDCODED_SECRET_DISABLED 589.237 µs [557.517 µs, 620.958 µs] 137.343 µs (30.4%)
iast_INACTIVE 553.164 µs [521.845 µs, 584.484 µs] 101.27 µs (22.4%)
iast_TELEMETRY_OFF 578.504 µs [547.477 µs, 609.53 µs] 126.61 µs (28.0%)
tracing 539.03 µs [509.074 µs, 568.985 µs] 87.136 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 448.502 µs [419.748 µs, 477.255 µs] -
iast 587.207 µs [555.138 µs, 619.275 µs] 138.705 µs (30.9%)
iast_FULL 680.987 µs [648.858 µs, 713.115 µs] 232.485 µs (51.8%)
iast_GLOBAL 622.328 µs [590.518 µs, 654.137 µs] 173.826 µs (38.8%)
iast_HARDCODED_SECRET_DISABLED 584.97 µs [553.64 µs, 616.301 µs] 136.469 µs (30.4%)
iast_INACTIVE 559.999 µs [528.826 µs, 591.171 µs] 111.497 µs (24.9%)
iast_TELEMETRY_OFF 576.907 µs [545.367 µs, 608.447 µs] 128.405 µs (28.6%)
tracing 543.973 µs [514.204 µs, 573.741 µs] 95.471 µs (21.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/fix-debugger-endpoints-with-uds
git_commit_date 1718118542 1718146820
git_commit_sha 54461ee 7145fa8
release_version 1.36.0-SNAPSHOT~54461eefea 1.36.0-SNAPSHOT~7145fa8107
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718150175 1718150175
ci_job_id 540112220 540112220
ci_pipeline_id 36473002 36473002
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~7145fa8107, baseline=1.36.0-SNAPSHOT~54461eefea
    dateFormat X
    axisFormat %s
section baseline
no_agent (21.086 s) : 21086000, 21086000
.   : milestone, 21086000,
appsec (21.648 s) : 21648000, 21648000
.   : milestone, 21648000,
iast (24.649 s) : 24649000, 24649000
.   : milestone, 24649000,
iast_GLOBAL (25.065 s) : 25065000, 25065000
.   : milestone, 25065000,
profiling (21.173 s) : 21173000, 21173000
.   : milestone, 21173000,
tracing (21.346 s) : 21346000, 21346000
.   : milestone, 21346000,
section candidate
no_agent (20.882 s) : 20882000, 20882000
.   : milestone, 20882000,
appsec (21.789 s) : 21789000, 21789000
.   : milestone, 21789000,
iast (24.221 s) : 24221000, 24221000
.   : milestone, 24221000,
iast_GLOBAL (24.38 s) : 24380000, 24380000
.   : milestone, 24380000,
profiling (21.015 s) : 21015000, 21015000
.   : milestone, 21015000,
tracing (21.737 s) : 21737000, 21737000
.   : milestone, 21737000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 21.086 s [21.086 s, 21.086 s] -
appsec 21.648 s [21.648 s, 21.648 s] 562.0 ms (2.7%)
iast 24.649 s [24.649 s, 24.649 s] 3.563 s (16.9%)
iast_GLOBAL 25.065 s [25.065 s, 25.065 s] 3.979 s (18.9%)
profiling 21.173 s [21.173 s, 21.173 s] 87.0 ms (0.4%)
tracing 21.346 s [21.346 s, 21.346 s] 260.0 ms (1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.882 s [20.882 s, 20.882 s] -
appsec 21.789 s [21.789 s, 21.789 s] 907.0 ms (4.3%)
iast 24.221 s [24.221 s, 24.221 s] 3.339 s (16.0%)
iast_GLOBAL 24.38 s [24.38 s, 24.38 s] 3.498 s (16.8%)
profiling 21.015 s [21.015 s, 21.015 s] 133.0 ms (0.6%)
tracing 21.737 s [21.737 s, 21.737 s] 855.0 ms (4.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~7145fa8107, baseline=1.36.0-SNAPSHOT~54461eefea
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.544 ms) : 1531, 1557
.   : milestone, 1544,
appsec (2.685 ms) : 2624, 2745
.   : milestone, 2685,
iast (2.346 ms) : 2275, 2417
.   : milestone, 2346,
iast_GLOBAL (2.399 ms) : 2328, 2470
.   : milestone, 2399,
profiling (2.22 ms) : 2159, 2281
.   : milestone, 2220,
tracing (2.174 ms) : 2116, 2232
.   : milestone, 2174,
section candidate
no_agent (1.542 ms) : 1530, 1555
.   : milestone, 1542,
appsec (2.682 ms) : 2621, 2742
.   : milestone, 2682,
iast (2.34 ms) : 2270, 2410
.   : milestone, 2340,
iast_GLOBAL (2.412 ms) : 2339, 2485
.   : milestone, 2412,
profiling (2.887 ms) : 2629, 3146
.   : milestone, 2887,
tracing (2.163 ms) : 2106, 2221
.   : milestone, 2163,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.544 ms [1.531 ms, 1.557 ms] -
appsec 2.685 ms [2.624 ms, 2.745 ms] 1.14 ms (73.9%)
iast 2.346 ms [2.275 ms, 2.417 ms] 802.174 µs (52.0%)
iast_GLOBAL 2.399 ms [2.328 ms, 2.47 ms] 855.222 µs (55.4%)
profiling 2.22 ms [2.159 ms, 2.281 ms] 675.982 µs (43.8%)
tracing 2.174 ms [2.116 ms, 2.232 ms] 629.686 µs (40.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.542 ms [1.53 ms, 1.555 ms] -
appsec 2.682 ms [2.621 ms, 2.742 ms] 1.139 ms (73.9%)
iast 2.34 ms [2.27 ms, 2.41 ms] 797.567 µs (51.7%)
iast_GLOBAL 2.412 ms [2.339 ms, 2.485 ms] 869.679 µs (56.4%)
profiling 2.887 ms [2.629 ms, 3.146 ms] 1.345 ms (87.2%)
tracing 2.163 ms [2.106 ms, 2.221 ms] 620.855 µs (40.3%)

@mcculls mcculls merged commit 222ce2c into master Jun 12, 2024
@mcculls mcculls deleted the mcculls/fix-debugger-endpoints-with-uds branch June 12, 2024 08:16
@github-actions github-actions bot added this to the 1.35.1 milestone Jun 12, 2024
mcculls added a commit that referenced this pull request Jun 12, 2024
@mcculls
Fix debugger batch upload URL when using UDS (#7166)
cf0ffb4
@mcculls mcculls mentioned this pull request Jun 12, 2024
Merged
@mcculls mcculls added the type: bug Bug report and fix label Jun 12, 2024
@mcculls mcculls modified the milestones: 1.35.1, 1.36.0 Jun 12, 2024
mcculls added a commit that referenced this pull request Jun 12, 2024
@mcculls
Fix debugger batch upload URL when using UDS (#7166)
12bbb14
mcculls added a commit that referenced this pull request Jun 12, 2024
@mcculls
Fix debugger batch upload URL when using UDS (#7166)
082445e
mcculls added a commit that referenced this pull request Jun 12, 2024
@mcculls
Fix debugger batch upload URL when using UDS (#7166)
3e989c5
@jpbempel jpbempel mentioned this pull request Oct 15, 2024
Merged
5 tasks
@amuraco amuraco mentioned this pull request Aug 21, 2025
Open
@jbachorik jbachorik mentioned this pull request Aug 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpbempel jpbempel jpbempel approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation type: bug Bug report and fix

Projects

None yet

Milestone

1.36.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @jpbempel