Skip to content

Revert "Run CI only for changed modules in pull requests #6610" #6699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2024
Merged

Revert "Run CI only for changed modules in pull requests #6610" #6699

merged 3 commits into from
Feb 20, 2024

Conversation

@smola
Copy link
Member

@smola smola commented Feb 19, 2024 •
edited
Loading

What Does This Do

Motivation

It seems https://github.com/dropbox/AffectedModuleDetector cannot see dependencies through custom configurations (or testFixtures), like this:

iastTestImplementation(testFixtures(project(':dd-java-agent:agent-iast')))
iastTestCompileOnly group: 'de.thetaphi', name: 'forbiddenapis', version: '3.4'
iastTestRuntimeOnly project(':dd-java-agent:instrumentation:jackson-core')
iastTestRuntimeOnly project(':dd-java-agent:instrumentation:iast-instrumenter')
iastTestRuntimeOnly project(':dd-java-agent:instrumentation:akka-http-10.2-iast')

This led to missing relevant tests at #6675

Additional Notes

@smola smola added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Feb 19, 2024
@smola smola requested a review from a team February 19, 2024 15:56
@smola smola requested a review from a team as a code owner February 19, 2024 15:56
@smola smola changed the title Smola/revert pr 6610 Revert "Run CI only for changed modules in pull requests #6610" Feb 19, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 20, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/revert-pr-6610
git_commit_date 1708419839 1708421100
git_commit_sha 4ff3736 ca57d56
release_version 1.31.0-SNAPSHOT~4ff37362e6 1.31.0-SNAPSHOT~ca57d56c1a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1708423971 1708423971
ci_job_id 437782327 437782327
ci_pipeline_id 28539769 28539769
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 11 unstable metrics.

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-20T09:49:22 2024-02-20T10:07:53
git_branch master smola/revert-pr-6610
git_commit_date 1708419839 1708421100
git_commit_sha 4ff3736 ca57d56
release_version 1.31.0-SNAPSHOT~4ff37362e6 1.31.0-SNAPSHOT~ca57d56c1a
start_time 2024-02-20T09:49:09 2024-02-20T10:07:40
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1708423971 1708423971
ci_job_id 437782327 437782327
ci_pipeline_id 28539769 28539769
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~ca57d56c1a, baseline=1.31.0-SNAPSHOT~4ff37362e6
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.349 µs) : 344, 387
.   : milestone, 365,
iast (469.619 µs) : 449, 490
.   : milestone, 470,
iast_FULL (534.818 µs) : 514, 555
.   : milestone, 535,
iast_GLOBAL (488.927 µs) : 469, 509
.   : milestone, 489,
iast_HARDCODED_SECRET_DISABLED (475.004 µs) : 454, 496
.   : milestone, 475,
iast_INACTIVE (445.745 µs) : 425, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (467.134 µs) : 446, 488
.   : milestone, 467,
tracing (439.333 µs) : 419, 460
.   : milestone, 439,
section candidate
no_agent (364.495 µs) : 343, 386
.   : milestone, 364,
iast (475.145 µs) : 454, 496
.   : milestone, 475,
iast_FULL (532.838 µs) : 512, 553
.   : milestone, 533,
iast_GLOBAL (493.807 µs) : 473, 515
.   : milestone, 494,
iast_HARDCODED_SECRET_DISABLED (469.285 µs) : 448, 490
.   : milestone, 469,
iast_INACTIVE (446.986 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (471.153 µs) : 450, 492
.   : milestone, 471,
tracing (433.143 µs) : 413, 453
.   : milestone, 433,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.349 µs [343.995 µs, 386.702 µs] -
iast 469.619 µs [448.941 µs, 490.298 µs] 104.271 µs (28.5%)
iast_FULL 534.818 µs [514.272 µs, 555.364 µs] 169.47 µs (46.4%)
iast_GLOBAL 488.927 µs [468.853 µs, 509.001 µs] 123.579 µs (33.8%)
iast_HARDCODED_SECRET_DISABLED 475.004 µs [454.103 µs, 495.906 µs] 109.656 µs (30.0%)
iast_INACTIVE 445.745 µs [425.007 µs, 466.484 µs] 80.397 µs (22.0%)
iast_TELEMETRY_OFF 467.134 µs [446.301 µs, 487.966 µs] 101.785 µs (27.9%)
tracing 439.333 µs [418.856 µs, 459.81 µs] 73.985 µs (20.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.495 µs [343.356 µs, 385.635 µs] -
iast 475.145 µs [454.396 µs, 495.893 µs] 110.649 µs (30.4%)
iast_FULL 532.838 µs [512.431 µs, 553.246 µs] 168.343 µs (46.2%)
iast_GLOBAL 493.807 µs [472.561 µs, 515.052 µs] 129.311 µs (35.5%)
iast_HARDCODED_SECRET_DISABLED 469.285 µs [448.324 µs, 490.245 µs] 104.789 µs (28.7%)
iast_INACTIVE 446.986 µs [426.093 µs, 467.88 µs] 82.491 µs (22.6%)
iast_TELEMETRY_OFF 471.153 µs [450.149 µs, 492.157 µs] 106.657 µs (29.3%)
tracing 433.143 µs [412.934 µs, 453.352 µs] 68.648 µs (18.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~ca57d56c1a, baseline=1.31.0-SNAPSHOT~4ff37362e6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1331, 1368
.   : milestone, 1349,
appsec (1.747 ms) : 1723, 1770
.   : milestone, 1747,
iast (1.542 ms) : 1519, 1564
.   : milestone, 1542,
profiling (1.503 ms) : 1480, 1526
.   : milestone, 1503,
tracing (1.5 ms) : 1477, 1523
.   : milestone, 1500,
section candidate
no_agent (1.342 ms) : 1323, 1361
.   : milestone, 1342,
appsec (1.748 ms) : 1725, 1772
.   : milestone, 1748,
iast (1.535 ms) : 1512, 1559
.   : milestone, 1535,
profiling (1.541 ms) : 1515, 1566
.   : milestone, 1541,
tracing (1.48 ms) : 1457, 1504
.   : milestone, 1480,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.331 ms, 1.368 ms] -
appsec 1.747 ms [1.723 ms, 1.77 ms] 397.303 µs (29.4%)
iast 1.542 ms [1.519 ms, 1.564 ms] 192.162 µs (14.2%)
profiling 1.503 ms [1.48 ms, 1.526 ms] 153.819 µs (11.4%)
tracing 1.5 ms [1.477 ms, 1.523 ms] 151.002 µs (11.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.323 ms, 1.361 ms] -
appsec 1.748 ms [1.725 ms, 1.772 ms] 406.849 µs (30.3%)
iast 1.535 ms [1.512 ms, 1.559 ms] 193.713 µs (14.4%)
profiling 1.541 ms [1.515 ms, 1.566 ms] 199.231 µs (14.9%)
tracing 1.48 ms [1.457 ms, 1.504 ms] 138.86 µs (10.4%)

@smola smola merged commit 0a14718 into master Feb 20, 2024
@smola smola deleted the smola/revert-pr-6610 branch February 20, 2024 14:10
@github-actions github-actions bot added this to the 1.31.0 milestone Feb 20, 2024
jandro996 pushed a commit that referenced this pull request Feb 29, 2024
@smola @jandro996
Revert "Run CI only for changed modules in pull requests #6610" (#6699)
44e7ec7 
* Revert "Fix setup job in CI (#6688)"

This reverts commit 85a5f5a.

* Revert "Run CI only for changed modules in pull requests (#6610)"

This reverts commit f66853f.
@smola smola mentioned this pull request Aug 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov was automatically assigned from DataDog/asm-java

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.31.0

Development

Successfully merging this pull request may close these issues.

4 participants

@smola @mcculls @manuel-alvarez-alvarez