-
Notifications
You must be signed in to change notification settings - Fork 317
Do not ignore caught exceptions in CI Visibility code #6671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/do-not-swallow-exceptions-in-ci-vis
Feb 13, 2024
Merged
Do not ignore caught exceptions in CI Visibility code #6671
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/do-not-swallow-exceptions-in-ci-vis
Feb 13, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
b749a5c to
91afe0b
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 10 unstable metrics. LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~91afe0b3fe, baseline=1.31.0-SNAPSHOT~c42d72c221
dateFormat X
axisFormat %s
section baseline
no_agent (372.148 µs) : 350, 394
. : milestone, 372,
iast (476.091 µs) : 456, 497
. : milestone, 476,
iast_FULL (545.006 µs) : 525, 565
. : milestone, 545,
iast_GLOBAL (504.397 µs) : 483, 526
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (475.017 µs) : 455, 495
. : milestone, 475,
iast_INACTIVE (450.733 µs) : 429, 472
. : milestone, 451,
iast_TELEMETRY_OFF (479.335 µs) : 458, 501
. : milestone, 479,
tracing (442.518 µs) : 422, 463
. : milestone, 443,
section candidate
no_agent (374.987 µs) : 355, 395
. : milestone, 375,
iast (475.86 µs) : 455, 497
. : milestone, 476,
iast_FULL (532.512 µs) : 512, 553
. : milestone, 533,
iast_GLOBAL (514.989 µs) : 493, 537
. : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (473.01 µs) : 452, 494
. : milestone, 473,
iast_INACTIVE (454.62 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (475.683 µs) : 455, 496
. : milestone, 476,
tracing (450.765 µs) : 430, 472
. : milestone, 451,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~91afe0b3fe, baseline=1.31.0-SNAPSHOT~c42d72c221
dateFormat X
axisFormat %s
section baseline
no_agent (1.385 ms) : 1366, 1404
. : milestone, 1385,
appsec (1.78 ms) : 1754, 1805
. : milestone, 1780,
iast (1.501 ms) : 1477, 1526
. : milestone, 1501,
profiling (1.612 ms) : 1585, 1638
. : milestone, 1612,
tracing (1.501 ms) : 1477, 1526
. : milestone, 1501,
section candidate
no_agent (1.357 ms) : 1338, 1375
. : milestone, 1357,
appsec (1.772 ms) : 1746, 1798
. : milestone, 1772,
iast (1.5 ms) : 1476, 1525
. : milestone, 1500,
profiling (1.518 ms) : 1493, 1544
. : milestone, 1518,
tracing (1.516 ms) : 1491, 1541
. : milestone, 1516,
|
juan-fernandez
approved these changes
Feb 13, 2024
jandro996
pushed a commit
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates CI Visibility core and instrumentations so that caught exceptions are never swallowed.
Motivation
In future releases of the tracer it will be possible to report exceptions in the tracer code to Datadog using telemetry.
The goal is to see if there are any unexpected exceptions when CI Visibility is used in various envs.
Jira ticket: CIVIS-2427