Skip to content

Conversation

@amarziali
Copy link
Contributor

What Does This Do

This PR allows to override the default service name when the user is not supplying one explicitely. This service name is then use as a default one for span not having one set (typically local roots) and it's pinned to the dynamic config current snapshot for other further usages.

The entry point for overriding (if possible) this service name will be through the already existing SpanNaming object

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added the comp: core Tracer core label Feb 8, 2024
@amarziali amarziali requested a review from a team as a code owner February 8, 2024 13:05
@amarziali amarziali requested review from am312 and mcculls February 8, 2024 13:05
@pr-commenter
Copy link

pr-commenter bot commented Feb 8, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/dynamic-config-preferred-service
git_commit_date 1707594080 1707660731
git_commit_sha 7edd7aa f0684f6
release_version 1.31.0-SNAPSHOT~7edd7aaa9e 1.31.0-SNAPSHOT~f0684f6d7f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1707663967 1707663967
ci_job_id 431176144 431176144
ci_pipeline_id 28091550 28091550
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 9 unstable metrics.

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-11T14:42:09 2024-02-11T15:01:04
git_branch master andrea.marziali/dynamic-config-preferred-service
git_commit_date 1707594080 1707660731
git_commit_sha 7edd7aa f0684f6
release_version 1.31.0-SNAPSHOT~7edd7aaa9e 1.31.0-SNAPSHOT~f0684f6d7f
start_time 2024-02-11T14:41:56 2024-02-11T15:00:51
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1707663967 1707663967
ci_job_id 431176144 431176144
ci_pipeline_id 28091550 28091550
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~f0684f6d7f, baseline=1.31.0-SNAPSHOT~7edd7aaa9e
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.086 µs) : 351, 391
.   : milestone, 371,
iast (471.41 µs) : 451, 492
.   : milestone, 471,
iast_FULL (536.924 µs) : 516, 558
.   : milestone, 537,
iast_GLOBAL (507.317 µs) : 485, 530
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (476.446 µs) : 455, 498
.   : milestone, 476,
iast_INACTIVE (444.681 µs) : 423, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (466.771 µs) : 446, 487
.   : milestone, 467,
tracing (443.976 µs) : 423, 465
.   : milestone, 444,
section candidate
no_agent (365.089 µs) : 345, 385
.   : milestone, 365,
iast (473.787 µs) : 453, 495
.   : milestone, 474,
iast_FULL (536.136 µs) : 515, 557
.   : milestone, 536,
iast_GLOBAL (505.449 µs) : 484, 526
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (480.023 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (447.086 µs) : 425, 469
.   : milestone, 447,
iast_TELEMETRY_OFF (469.51 µs) : 448, 491
.   : milestone, 470,
tracing (442.59 µs) : 421, 464
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.086 µs [350.743 µs, 391.429 µs] -
iast 471.41 µs [450.741 µs, 492.078 µs] 100.324 µs (27.0%)
iast_FULL 536.924 µs [516.111 µs, 557.737 µs] 165.838 µs (44.7%)
iast_GLOBAL 507.317 µs [484.568 µs, 530.065 µs] 136.231 µs (36.7%)
iast_HARDCODED_SECRET_DISABLED 476.446 µs [455.31 µs, 497.583 µs] 105.36 µs (28.4%)
iast_INACTIVE 444.681 µs [423.338 µs, 466.024 µs] 73.595 µs (19.8%)
iast_TELEMETRY_OFF 466.771 µs [446.385 µs, 487.157 µs] 95.685 µs (25.8%)
tracing 443.976 µs [423.263 µs, 464.688 µs] 72.889 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.089 µs [344.966 µs, 385.213 µs] -
iast 473.787 µs [452.627 µs, 494.946 µs] 108.697 µs (29.8%)
iast_FULL 536.136 µs [515.295 µs, 556.977 µs] 171.046 µs (46.9%)
iast_GLOBAL 505.449 µs [484.445 µs, 526.453 µs] 140.359 µs (38.4%)
iast_HARDCODED_SECRET_DISABLED 480.023 µs [458.552 µs, 501.495 µs] 114.934 µs (31.5%)
iast_INACTIVE 447.086 µs [425.152 µs, 469.021 µs] 81.997 µs (22.5%)
iast_TELEMETRY_OFF 469.51 µs [448.183 µs, 490.837 µs] 104.42 µs (28.6%)
tracing 442.59 µs [421.497 µs, 463.683 µs] 77.5 µs (21.2%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~f0684f6d7f, baseline=1.31.0-SNAPSHOT~7edd7aaa9e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.36 ms) : 1341, 1379
.   : milestone, 1360,
appsec (1.778 ms) : 1752, 1803
.   : milestone, 1778,
iast (1.525 ms) : 1501, 1549
.   : milestone, 1525,
profiling (1.536 ms) : 1511, 1561
.   : milestone, 1536,
tracing (1.501 ms) : 1476, 1525
.   : milestone, 1501,
section candidate
no_agent (1.365 ms) : 1346, 1384
.   : milestone, 1365,
appsec (1.753 ms) : 1727, 1779
.   : milestone, 1753,
iast (1.514 ms) : 1490, 1539
.   : milestone, 1514,
profiling (1.534 ms) : 1507, 1561
.   : milestone, 1534,
tracing (1.51 ms) : 1485, 1535
.   : milestone, 1510,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.341 ms, 1.379 ms] -
appsec 1.778 ms [1.752 ms, 1.803 ms] 417.827 µs (30.7%)
iast 1.525 ms [1.501 ms, 1.549 ms] 164.923 µs (12.1%)
profiling 1.536 ms [1.511 ms, 1.561 ms] 175.967 µs (12.9%)
tracing 1.501 ms [1.476 ms, 1.525 ms] 140.727 µs (10.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.346 ms, 1.384 ms] -
appsec 1.753 ms [1.727 ms, 1.779 ms] 387.555 µs (28.4%)
iast 1.514 ms [1.49 ms, 1.539 ms] 149.0 µs (10.9%)
profiling 1.534 ms [1.507 ms, 1.561 ms] 168.577 µs (12.3%)
tracing 1.51 ms [1.485 ms, 1.535 ms] 144.734 µs (10.6%)

@amarziali amarziali force-pushed the andrea.marziali/dynamic-config-preferred-service branch from 3a38cd6 to f0684f6 Compare February 11, 2024 14:17
@amarziali amarziali merged commit c42d72c into master Feb 12, 2024
@amarziali amarziali deleted the andrea.marziali/dynamic-config-preferred-service branch February 12, 2024 14:40
@github-actions github-actions bot added this to the 1.30.0 milestone Feb 12, 2024
manuel-alvarez-alvarez pushed a commit that referenced this pull request Feb 12, 2024
)

* Override tracing preferred service name and pin to dynamic config

* refactor
jandro996 pushed a commit that referenced this pull request Feb 16, 2024
)

* Override tracing preferred service name and pin to dynamic config

* refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants