-
Notifications
You must be signed in to change notification settings - Fork 318
Override tracing preferred service name and pin to dynamic config #6648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amarziali
merged 2 commits into
master
from
andrea.marziali/dynamic-config-preferred-service
Feb 12, 2024
Merged
Override tracing preferred service name and pin to dynamic config #6648
amarziali
merged 2 commits into
master
from
andrea.marziali/dynamic-config-preferred-service
Feb 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 9 unstable metrics. LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~f0684f6d7f, baseline=1.31.0-SNAPSHOT~7edd7aaa9e
dateFormat X
axisFormat %s
section baseline
no_agent (371.086 µs) : 351, 391
. : milestone, 371,
iast (471.41 µs) : 451, 492
. : milestone, 471,
iast_FULL (536.924 µs) : 516, 558
. : milestone, 537,
iast_GLOBAL (507.317 µs) : 485, 530
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (476.446 µs) : 455, 498
. : milestone, 476,
iast_INACTIVE (444.681 µs) : 423, 466
. : milestone, 445,
iast_TELEMETRY_OFF (466.771 µs) : 446, 487
. : milestone, 467,
tracing (443.976 µs) : 423, 465
. : milestone, 444,
section candidate
no_agent (365.089 µs) : 345, 385
. : milestone, 365,
iast (473.787 µs) : 453, 495
. : milestone, 474,
iast_FULL (536.136 µs) : 515, 557
. : milestone, 536,
iast_GLOBAL (505.449 µs) : 484, 526
. : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (480.023 µs) : 459, 501
. : milestone, 480,
iast_INACTIVE (447.086 µs) : 425, 469
. : milestone, 447,
iast_TELEMETRY_OFF (469.51 µs) : 448, 491
. : milestone, 470,
tracing (442.59 µs) : 421, 464
. : milestone, 443,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~f0684f6d7f, baseline=1.31.0-SNAPSHOT~7edd7aaa9e
dateFormat X
axisFormat %s
section baseline
no_agent (1.36 ms) : 1341, 1379
. : milestone, 1360,
appsec (1.778 ms) : 1752, 1803
. : milestone, 1778,
iast (1.525 ms) : 1501, 1549
. : milestone, 1525,
profiling (1.536 ms) : 1511, 1561
. : milestone, 1536,
tracing (1.501 ms) : 1476, 1525
. : milestone, 1501,
section candidate
no_agent (1.365 ms) : 1346, 1384
. : milestone, 1365,
appsec (1.753 ms) : 1727, 1779
. : milestone, 1753,
iast (1.514 ms) : 1490, 1539
. : milestone, 1514,
profiling (1.534 ms) : 1507, 1561
. : milestone, 1534,
tracing (1.51 ms) : 1485, 1535
. : milestone, 1510,
|
am312
approved these changes
Feb 8, 2024
3a38cd6 to
f0684f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR allows to override the default service name when the user is not supplying one explicitely. This service name is then use as a default one for span not having one set (typically local roots) and it's pinned to the dynamic config current snapshot for other further usages.
The entry point for overriding (if possible) this service name will be through the already existing
SpanNamingobjectMotivation
Additional Notes
Jira ticket: [PROJ-IDENT]